New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 143442: ctrl + w (close tab) doesnt work on going full screen

Reported by jasneet@chromium.org, Aug 17 2012 Project Member

Issue description

Chrome Version: 22.0.1229.8 (Official Build 151840)
Chrome OS Version: 2723.18.0
Chrome OS Platform: <Make/model of computer running Chrome OS>
Network info: <network, encryption type, router model (if known)>

Please specify Area-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
1.Open a tab
2.Go full screen
3.Hit Ctrl + W to close tab

Expected Result:
Tab should close

Actual Result:
Tab doesn't close

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
always

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.
Is it related to issue  crbug.com/142422  ?
 

Comment 1 by ddrew@chromium.org, Aug 17 2012

Labels: -Type-Bug -Pri-2 -ReleaseBlock-Beta Type-Regression Pri-1 ReleaseBlock-Stable Noteworthy
Owner: zelidrag@chromium.org
Status: Assigned
Is there a workaround to be able to exit full screen mode?

Comment 2 by jasneet@chromium.org, Aug 17 2012

Yes we can exit full screen mode by pressing full screen keyboard button or clicking exit full screen link. The issue is Ctrl + w to close tab in full screen doesn't work.

Comment 3 by zelidrag@chromium.org, Aug 17 2012

Labels: Iteration-63
Owner: yusukes@chromium.org

Comment 4 by yusukes@chromium.org, Aug 20 2012

Status: Started

Comment 5 by zelidrag@chromium.org, Aug 20 2012

Labels: Feature-Ash

Comment 6 by yusukes@chromium.org, Aug 20 2012

Cc: skuhne@chromium.org
I think this is a side effect of r151121 which disables C-w and C-S-w when Pepper window is maximized. I'm going to modify the change so that it does not disable C-w/C-S-w when a browser (ie. non-Pepper) window is maximized.

Comment 8 by skuhne@chromium.org, Aug 20 2012

When that CL is landed we will probably see the crash dupms again. There is an issue filed to take care of that -> see  issue 142422 .

Please do not submit this until the real reason for the crash dumps is fixed.

Comment 9 by yusukes@chromium.org, Aug 22 2012

Note: Talked with skuhne and got LGTM from him and Ben. The CL (#7) does not trigger the crash bug on full-screen Flash.

Comment 10 by yusukes@chromium.org, Aug 22 2012

Cc: kerz@chromium.org ben@chromium.org
Labels: Merge-Requested
I would like to submit http://codereview.chromium.org/10834421/ (one line change) directly to the M22 branch because the code the CL modifies no longer exists on trunk.

Since the code I patched is guarded by #if defined(USE_ASH), the patch does not affect Windows/Mac/Linux Chrome. It's Chrome OS only.

Comment 11 by skuhne@chromium.org, Aug 22 2012

Yes, sorry - forgotten to mark this yesterday night. Ben asked me to remove the fix yesterday evening which I did. The real fix (not creating a new window and instead fullscreen'ing the video player) is on another .

So I suppose *this* issue is fixed.

Comment 12 by yusukes@chromium.org, Aug 22 2012

> So I suppose *this* issue is fixed.

This issue is fixed on trunk (since you removed your temporary workaround for  Issue 134465  from trunk yesterday), but it's still not fixed on M22, correct? Since this is M22 Stable Blocker, I think I still need to merge http://codereview.chromium.org/10834421/ to M22.

Comment 13 by skuhne@chromium.org, Aug 22 2012

Yes, that is correct. It won't help for M22. So you are right. Needs to be merged to M22. Somehow I missed that this was a ReleaseBlocker for M22. Sorry.

Comment 14 by k...@google.com, Aug 23 2012

Labels: -Merge-Requested Merge-Approved

Comment 15 by bugdroid1@chromium.org, Aug 24 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153206

------------------------------------------------------------------------
r153206 | yusukes@chromium.org | 2012-08-24T14:44:51.578099Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_command_controller.cc?r1=153206&r2=153205&pathrev=153206

Re-enable Ctrl-w and Ctrl-Shift-w when a non-Pepper window is maximized.

This is a temporary fix for M22 for  crbug.com/143442 , and should be reverted on trunk as part of  crbug.com/142422 . This CL is basically a second trial of r151121 which was also a temporary fix for M22.  r151121 disabled Ctrl-w and Ctrl-Shift-w when any kind of full screen window was active, but it turned out that the limitation was too strict; we should not disable Ctrl-w and Ctrl-Shift-w when a non-Pepper window was maximized.

BUG= 143442 , 142422 
TEST=confirmed that C-w/C-S-w do not crash when a browser window is maximized.

Review URL: https://chromiumcodereview.appspot.com/10834421
------------------------------------------------------------------------

Comment 16 by bugdroid1@chromium.org, Aug 24 2012

Project Member
Labels: -Merge-Approved merge-merged-1229
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153208

------------------------------------------------------------------------
r153208 | yusukes@chromium.org | 2012-08-24T14:47:00.087656Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/ui/browser_command_controller.cc?r1=153208&r2=153207&pathrev=153208

Merge 153206 - Re-enable Ctrl-w and Ctrl-Shift-w when a non-Pepper window is maximized.

This is a temporary fix for M22 for  crbug.com/143442 , and should be reverted on trunk as part of  crbug.com/142422 . This CL is basically a second trial of r151121 which was also a temporary fix for M22.  r151121 disabled Ctrl-w and Ctrl-Shift-w when any kind of full screen window was active, but it turned out that the limitation was too strict; we should not disable Ctrl-w and Ctrl-Shift-w when a non-Pepper window was maximized.

BUG= 143442 , 142422 
TEST=confirmed that C-w/C-S-w do not crash when a browser window is maximized.

Review URL: https://chromiumcodereview.appspot.com/10834421

TBR=yusukes@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10879065
------------------------------------------------------------------------

Comment 17 by bugdroid1@chromium.org, Aug 24 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153210

------------------------------------------------------------------------
r153210 | yusukes@chromium.org | 2012-08-24T14:47:59.417290Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_command_controller.cc?r1=153210&r2=153209&pathrev=153210

Revert 153206 - Re-enable Ctrl-w and Ctrl-Shift-w when a non-Pepper window is maximized.

This is a temporary fix for M22 for  crbug.com/143442 , and should be reverted on trunk as part of  crbug.com/142422 . This CL is basically a second trial of r151121 which was also a temporary fix for M22.  r151121 disabled Ctrl-w and Ctrl-Shift-w when any kind of full screen window was active, but it turned out that the limitation was too strict; we should not disable Ctrl-w and Ctrl-Shift-w when a non-Pepper window was maximized.

BUG= 143442 , 142422 
TEST=confirmed that C-w/C-S-w do not crash when a browser window is maximized.

Review URL: https://chromiumcodereview.appspot.com/10834421

TBR=yusukes@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10867053
------------------------------------------------------------------------

Comment 18 by yusukes@chromium.org, Aug 24 2012

Status: Fixed

Comment 19 by abod...@chromium.org, Aug 24 2012

Cc: krisr@chromium.org
Not landed on ChromeOS 2723.37.0 (Chrome: 22.0.1229.21.
I will verify next coming build.

Comment 20 by bincheng@chromium.org, Aug 27 2012

Not landed on  ChromeOS 2723.43.0 (Chrome: 22.0.1229.24.0) will verify next coming build

Comment 21 by bincheng@chromium.org, Aug 27 2012

Status: Verified
ChromeOS 23.0.1246.0    dev
Platform 2812.0.0       dev-channel

Comment 22 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 23 by bugdroid1@chromium.org, Mar 9 2013

Project Member
Labels: -Type-Regression -Area-UI -Mstone-22 -Noteworthy -Feature-Ash Type-Bug-Regression Hotlist-Noteworthy Cr-UI-Shell Cr-UI M-22

Comment 24 by bugdroid1@chromium.org, Mar 14 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment