New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Verified
Owner:
User never visited
Closed: Aug 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 141180: DevTools: [REGRESSION] "save as" of edited source in developer mode fails to update saved file

Reported by imorth...@gmail.com, Aug 7 2012

Issue description

Chrome Version       : 21.0.1180.60
OS Version: 5.1 (Windows XP)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:

What steps will reproduce the problem?
1.modify a file in developer - sources (.css or .js)
2.right click to bring up context menu - select "save as"
3.agree to save in any pop-up box
4.open the save target - observe that the file is not the latest version

What is the expected result?
current version (within "sources" tab of developer menu) is saved, updating the file

What happens instead?
What appears to be happening is that the last version saved (using CTRL-S) is saved instead, ignoring any changes after that.



Please provide any additional information below. Attach a screenshot if possible.

In practice this means that it is difficult/impossible to save a forked version with a different name within developer mode - as the changes must be saved to the orginal file first (CTRL-S, or plain "Save") for the changes to take effect in "Save-As"

Assuming a bug not feature
 

Comment 1 by cbentzel@chromium.org, Aug 8 2012

Labels: Feature-DevTools

Comment 2 by pfeldman@chromium.org, Aug 10 2012

Labels: -Area-Undefined Area-WebKit Mstone-22
Owner: vsevik@chromium.org

Comment 3 by pfeldman@chromium.org, Aug 10 2012

Summary: DevTools: [REGRESSION] "save as" of edited source in developer mode fails to update saved file

Comment 4 by vsevik@chromium.org, Aug 15 2012

Cc: manoranj...@chromium.org ligim...@chromium.org pavanv@chromium.org
 Issue 140449  has been merged into this issue.

Comment 5 by ligim...@chromium.org, Aug 15 2012

Labels: Action-BisectNeeded

Comment 6 by pfeldman@chromium.org, Aug 15 2012

Labels: -Action-BisectNeeded
Status: Started
No Action-BisectNeeded - we know exactly what is wrong and why. The fix has already landed upstream.

Comment 7 by vsevik@chromium.org, Aug 15 2012

Status: Assigned
Committed r125668: <http://trac.webkit.org/changeset/125668>

Comment 8 by vsevik@chromium.org, Aug 15 2012

Labels: -OS-Windows Merge-Requested Mstone-21
This is a severe regression in Developer Tools and we need to merge it both in m21 and m22.
The fix is pretty innocent, one liner essentially.

Comment 9 by k...@google.com, Aug 15 2012

Labels: Merge-Approved-1229
Approved for 22.

Comment 10 by kareng@google.com, Aug 15 2012

once it's in M22. ping me and i'll approve after it's gone out.

Comment 11 by vsevik@chromium.org, Aug 16 2012

Labels: -Merge-Approved-1229 Merge-Merged-1229

Comment 12 by k...@google.com, Aug 16 2012

Labels: -Mstone-22

Comment 13 by ligim...@chromium.org, Aug 16 2012

I am still seeing the same issue , doesn't seem to be fixed in 22.0.1229.8

Steps
====
1. Launch chrome , open any URL - www.cnn.com
2. Open Dev Tools - > sources -> Open any .js file
3. Edited the .js file , added some null functions in between ( See attachment)
4. Context Menu ->Save As
5. Open the saved file & check

Expected
========
The saved file should be current .

Observed
========

The saved file shows the previously saved one and not the current file.

Additional Info
==============
Currently , in order to use save-as option , we need to save (CTRL-S) first & then save-as  to retrieve the current file. Otherwise we will get the previously saved file.
2_Nulls.JPG
43.3 KB View Download

Comment 14 by ligim...@chromium.org, Aug 16 2012

Cc: kerz@chromium.org

Comment 15 by k...@google.com, Aug 16 2012

This was merged after the cut for .8.  Please recheck in the next build.

Comment 16 by ddrew@chromium.org, Aug 17 2012

Labels: OS-Windows

Comment 17 by kareng@google.com, Aug 24 2012

Labels: -Merge-Requested Merge-Approved

Comment 18 by vsevik@chromium.org, Aug 24 2012

Labels: -OS-Windows
Nothing windows specific here.

Comment 19 by vsevik@chromium.org, Aug 24 2012

Labels: -Merge-Approved Merge-Merged-1180 Merge-Merged
Status: Fixed
Committed revision 126594.

Comment 20 by mbollu@chromium.org, Aug 27 2012

Status: Verified
Tested with steps in Comment 13. Fixed.

Comment 21 by mbollu@chromium.org, Aug 27 2012

Cc: mbollu@chromium.org

Comment 22 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 23 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-WebKit -Feature-DevTools -Mstone-21 Cr-Content Cr-Platform-DevTools M-21

Comment 24 by bugdroid1@chromium.org, Mar 14 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Comment 25 by bugdroid1@chromium.org, Apr 6 2013

Project Member
Labels: -Cr-Content Cr-Blink

Sign in to add a comment