New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2012
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 141081: THROTTLING_REJECTED_REQUEST with --disable-extensions-http-throttling

Reported by jamez...@gmail.com, Aug 7 2012

Issue description

Chrome Version       : 21.0.1180.60 m
OS Version: XP, Win7
URLs (if applicable) : N/A
Other browsers tested: N/A

What steps will reproduce the problem?
1. Use our private extension, fire a few URL requests to our website.

What is the expected result?
No errors. The flag should work.

What happens instead?
THROTTLING_REJECTED_REQUEST and stoppage (see attached)
 
WS_0251_cropped.JPG
79.6 KB View Download

Comment 1 by cbentzel@chromium.org, Aug 8 2012

Cc: joi@chromium.org
Labels: -Area-Undefined Area-Internals Internals-Network-HTTP
Status: Untriaged

Comment 2 by joi@chromium.org, Aug 8 2012

Owner: joi@chromium.org
Status: Assigned
Very weird.  I'll try to reproduce tomorrow.

Comment 3 by joi@chromium.org, Aug 9 2012

Cc: -joi@chromium.org
Labels: Mstone-21
Status: Started
I can confirm I can reproduce this bug and I believe I know the reason for it.  The flag ends up being stored on the ChromeNetworkDelegate initially created in IOThread::Init, but apparently this instance can end up being changed.

This bug seems to have been introduced in http://crrev.com/141000, so it just hit the stable channel about 10 days ago, and the first user reports came in a couple of days ago.  I will be suggesting that we merge the fix to the stable channel in a bug fix release.

While investigating this bug, I found a more serious issue that also needs to be fixed and is caused by the same change, see  issue 141643 .

Comment 4 by bugdroid1@chromium.org, Aug 9 2012

Project Member
Summary: THROTTLING_REJECTED_REQUEST with --disable-extensions-http-throttling
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=150928

------------------------------------------------------------------------
r150928 | joi@chromium.org | 2012-08-09T22:48:46.818922Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_network_delegate.cc?r1=150928&r2=150927&pathrev=150928
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_network_delegate.h?r1=150928&r2=150927&pathrev=150928

Fix a bad inversion of logic (see OnCanThrottleRequest) and a bug
related to how a flag was persisted.

BUG= 141081 , 141643 


Review URL: https://chromiumcodereview.appspot.com/10854069
------------------------------------------------------------------------

Comment 5 by joi@chromium.org, Aug 10 2012

Will test on Canary once available, and then request merge to Beta and Stable.

Comment 6 by joi@chromium.org, Aug 13 2012

Labels: ReleaseBlock-Stable Merge-Requested
I've tested on Canary that the fix works correctly.  Requesting to merge r150928 to the M21 branch.

Note that this is the same fix (r150928) as for  issue 141643 .

Comment 7 by bugdroid1@chromium.org, Aug 15 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=151683

------------------------------------------------------------------------
r151683 | joi@chromium.org | 2012-08-15T11:13:11.281900Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_network_delegate_unittest.cc?r1=151683&r2=151682&pathrev=151683
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_network_delegate.h?r1=151683&r2=151682&pathrev=151683
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=151683&r2=151682&pathrev=151683

Regression test for anti-DDoS bugs in ChromeNetworkDelegate.

This ensures:
a) That when g_never_throttle_requests_ is false, only
extension requests may be throttled (rather than the inverse);
b) That setting the flag applies to all instances of
ChromeNetworkDelegate, not just the one it is set on.

If we'd had these tests earlier, they would have prevented the
bugs below from being introduced.

TBR=thakis@chromium.org
BUG= 141081 , 141643 


Review URL: https://chromiumcodereview.appspot.com/10828284
------------------------------------------------------------------------

Comment 8 by kareng@google.com, Aug 15 2012

Labels: -Merge-Requested Merge-Approved
Status: Fixed

Comment 9 by joi@chromium.org, Aug 15 2012

I just landed the merge of r150928 to the Chrome 21 branch, so this is now fixed, and should go live with the first release of Chrome 21 that picks up the merge, r151761.

Comment 10 by bugdroid1@chromium.org, Aug 15 2012

Project Member
Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=151761

------------------------------------------------------------------------
r151761 | joi@chromium.org | 2012-08-15T21:55:53.903890Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/net/chrome_network_delegate.h?r1=151761&r2=151760&pathrev=151761
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/net/chrome_network_delegate.cc?r1=151761&r2=151760&pathrev=151761

Merge 150928 - Fix a bad inversion of logic (see OnCanThrottleRequest) and a bug
related to how a flag was persisted.

BUG= 141081 , 141643 


Review URL: https://chromiumcodereview.appspot.com/10854069

TBR=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10828333
------------------------------------------------------------------------

Comment 11 by joi@chromium.org, Aug 15 2012

Labels: -Mstone-21 Mstone-22 Merge-Requested
kerz:  The fix for this is the same revision as the fix for  issue 141643 .  It was already merged to the 21 branch, hence the merge-merged-1180 label, but it needs to be merged to 22 as well.

Comment 12 by joi@chromium.org, Aug 15 2012

Status: Started

Comment 13 by k...@google.com, Aug 15 2012

Labels: -Merge-Requested Merge-Approved

Comment 14 by bugdroid1@chromium.org, Aug 15 2012

Project Member
Labels: -Merge-Approved merge-merged-1229
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=151767

------------------------------------------------------------------------
r151767 | joi@chromium.org | 2012-08-15T22:20:57.909608Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/net/chrome_network_delegate.cc?r1=151767&r2=151766&pathrev=151767
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/chrome/browser/net/chrome_network_delegate.h?r1=151767&r2=151766&pathrev=151767

Merge 150928 - Fix a bad inversion of logic (see OnCanThrottleRequest) and a bug
related to how a flag was persisted.

BUG= 141081 , 141643 


Review URL: https://chromiumcodereview.appspot.com/10854069

TBR=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830344
------------------------------------------------------------------------

Comment 15 by joi@chromium.org, Aug 15 2012

Status: Fixed
This is now on trunk, 21 and 22, and trunk has an added regression test, so that should be the end of this problem.

Comment 16 by ligim...@chromium.org, Aug 17 2012

Can someone provide us with the link to install private extension?

Comment 17 by joi@google.com, Aug 17 2012

ligimole:  I was able to reproduce the problem described in the bug (before I fixed it) by following the manual testing instructions at http://www.chromium.org/for-testers/backend-testing/extensions-http-throttling-testing.  Thus, there is no need to get the private extension for testing.

Comment 18 by joi@chromium.org, Aug 22 2012

The first Chrome 21 version to have the fix is 21.0.1180.81 so if you have that version or later you should no longer experience it.  The versions currently being distributed on the stable channel are 21.0.1180.81 and later.

Comment 19 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 20 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-Internals -Internals-Network-HTTP -Mstone-22 M-22 Cr-Internals-Network-HTTP Cr-Internals

Comment 21 by bugdroid1@chromium.org, Mar 14 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Comment 22 by efoo@chromium.org, Jul 6 2018

Components: Internals>Network

Comment 23 by efoo@chromium.org, Jul 6 2018

Components: -Internals>Network>HTTP

Sign in to add a comment