New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression

Blocking:
issue 138366

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 140577: Pepper Flash: flash player shifting left and right on youtube/niconico video

Reported by kenjibaheux@chromium.org, Aug 3 2012 Project Member

Issue description

Version: 21.0.1180.60 m
OS: Windows 7
Shockwave Flash PPAPI
Description:	Shockwave Flash 11.3 r31
Version:	11.3.31.222

What steps will reproduce the problem?
1. Go to http://www.nicovideo.jp/watch/sm18240734 (for instance)
2. Login by clicking on the blue button that reads ログイン画面へ (I will send the test credentials by email)
3. Close the error dialog and Ad if any (right side of the player, covering the comments "コメント" area)
4. Maximize Chrome (not entirely sure this is needed)
5. Click on play (triangle button)

What is the expected output?
6. The player stay put.

 What do you see instead?
6. Sometime, the right side of the player UI (where the list of comments are) will shift left and right by 1 pixel
7. The video will stop playing after a bit (not entirely sure this is related to this issue)

Notes:
 - works fine with NPAPI on the same machine. No issue on Mac Chrome 22.0.1221.0 dev with Pepper Flash (Shockwave Flash 11.3 r31 Version:	11.3.31.307).
 - No repro on Windows 7 or Windows 8.

I am tempting to put a Pri-2 on this if we can fix #7 (meaning that 7 has nothing to do with this issue).
 

Comment 1 by kenjibaheux@chromium.org, Aug 4 2012

Apparently also affects Youtube according to report #370687663 (Google Feedback).

Comment 2 by viettrungluu@chromium.org, Aug 4 2012

Labels: -Pri-1 Pri-2
#7 sounds like  issue 139953 . In any case, it's almost certainly a different issue.

If #7 isn't fixed in the current Canary, please file another bug for it.

Comment 3 by kenjibaheux@google.com, Aug 4 2012

(The OS on which I have confirmed this bug was XP not 7)

I was able to repro item 7 on Canary 22.0.1226.0 PPAPI Shockwave Flash 11.3 r31 11.3.31.311 (windows XP).
I believe it is different than 139953 and was originally filed as  crbug.com/140602  which I have re-opened.

Comment 4 by Deleted ...@, Aug 8 2012

I have the same issue with flash games on Facebook. The player shifts side to side and won't let anything open on top of it. No pop up boxes or drop down menus, they fight for focus.

Comment 5 by raymes@chromium.org, Aug 14 2012

Cc: raymes@chromium.org viettrungluu@chromium.org
Owner: yzshen@chromium.org
Summary: Pepper Flash: flash player shifting left and right on youtube/niconico video
yzshen is looking at this.

We looked yesterday and this can be reproduced on Windows 7 by running Chrome with --disable-gpu. We also verified that it reproduces on Youtube.

Comment 6 by Deleted ...@, Aug 15 2012

Yeah. i have the same problem on XP sp3.

and it is because of the pepper flash. When i switch to NPAPI version (and disable pepper) all the issues dissapear.

Also i have some playback issues: from time to time the video "chokes" (only when pepper is enabled).

Comment 7 by yzshen@chromium.org, Aug 16 2012

This is a subpixel layout issue.
Working on the patch: https://bugs.webkit.org/show_bug.cgi?id=94257

Comment 8 by sh...@chromium.org, Aug 17 2012

Blocking: chromium:138366

Comment 10 by yzshen@chromium.org, Aug 21 2012

Cc: karen@chromium.org
 Issue 139235  has been merged into this issue.

Comment 11 Deleted

Comment 12 by sh...@chromium.org, Aug 22 2012

Are we planning to pull this into M-22 and M-21?  Even though those don't have Flapper,  issue 138366  from NPAPI Flash stems from the same cause.

Comment 13 by sh...@chromium.org, Aug 22 2012

Just verified that  issue 138366  works in OSX Canary 23.0.1242.0, and didn't work in 23.0.1236.0 (both testing with NPAPI flash).

Comment 14 by yzshen@chromium.org, Aug 22 2012

I am planning to. (If release manager agrees.)

However, I got a bug report of a nacl_integration test failure:
http://code.google.com/p/chromium/issues/detail?id=143973

I will look at it today to make sure that the patch is safe.

Comment 15 by yzshen@chromium.org, Aug 22 2012

Labels: Merge-Requested
I have looked into 143973 and this patch should be safe.

Comment 16 by kareng@google.com, Aug 24 2012

hmm loooks like it didnt' go into m22? i can take it but it will go straight to stable so i need to know it's super-duper safe :)

Comment 17 by parth.bh...@gmail.com, Aug 24 2012

Please merge to stable, tons of people waiting on this including anyone that does flash video chat. Thank you so much for your help!

Comment 18 by yzshen@chromium.org, Aug 24 2012

Hi, Karen.

No, it didn't. But I am planning to merge to both M21 and M22, if you think it is okay.

I believe this patch is safe. :)

Comment 19 by kareng@google.com, Aug 24 2012

Labels: -Merge-Requested Merge-Approved
ok go for it. approved for m21. pls merge cause i think i will spin today.

Comment 20 by kareng@google.com, Aug 24 2012

once you've merged, move it to m22 and request-merge :)

Comment 21 by yzshen@chromium.org, Aug 24 2012

Labels: -Mstone-21 -Merge-Approved Mstone-22 Merge-Requested
Has merged to M21.

Comment 22 by k...@google.com, Aug 24 2012

Labels: -Merge-Requested Merge-Approved merge-merged-1180

Comment 23 by bugdroid1@chromium.org, Aug 24 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153330

------------------------------------------------------------------------
r153330 | yzshen@chromium.org | 2012-08-24T22:44:28.511374Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/native_client/tests/ppapi_browser/ppp_input_event/ppapi_ppp_input_event.js?r1=153330&r2=153329&pathrev=153330
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/nacl_test_injection/buildbot_nacl_integration.py?r1=153330&r2=153329&pathrev=153330

Fix run_ppapi_ppp_input_event_browser_test and re-enable it.

The test has hard-coded coordinates which doesn't match the current layout anymore. It "passed" because there was this bug http://code.google.com/p/chromium/issues/detail?id=140577, which has been fixed.

BUG= 143973 
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10869017
------------------------------------------------------------------------

Comment 24 by scheib@chromium.org, Aug 24 2012

I have merged the webkit change
from trunk: http://trac.webkit.org/changeset/126042
to branch: http://trac.webkit.org/changeset/126645

Comment 25 by yzshen@chromium.org, Aug 24 2012

Labels: merge-merged-1229
Status: Fixed

Comment 26 by bugdroid1@chromium.org, Aug 25 2012

Project Member
Labels: -Merge-Approved
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153356

------------------------------------------------------------------------
r153356 | yzshen@chromium.org | 2012-08-25T00:11:24.213244Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/ppapi/native_client/tests/ppapi_browser/ppp_input_event/ppapi_ppp_input_event.js?r1=153356&r2=153355&pathrev=153356

Merge 153330 - Fix run_ppapi_ppp_input_event_browser_test and re-enable it.

The test has hard-coded coordinates which doesn't match the current layout anymore. It "passed" because there was this bug http://code.google.com/p/chromium/issues/detail?id=140577, which has been fixed.

BUG= 143973 
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10869017

TBR=yzshen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10876073
------------------------------------------------------------------------

Comment 27 by bugdroid1@chromium.org, Aug 27 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=153552

------------------------------------------------------------------------
r153552 | yzshen@chromium.org | 2012-08-27T21:52:53.821664Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1229/src/ppapi/native_client/tests/ppapi_browser/ppp_input_event/ppapi_ppp_input_event.js?r1=153552&r2=153551&pathrev=153552

Merge 153330 - Fix run_ppapi_ppp_input_event_browser_test and re-enable it.

The test has hard-coded coordinates which doesn't match the current layout anymore. It "passed" because there was this bug http://code.google.com/p/chromium/issues/detail?id=140577, which has been fixed.

BUG= 143973 
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10869017

TBR=yzshen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10875080
------------------------------------------------------------------------

Comment 28 by mbollu@chromium.org, Aug 27 2012

In order to verify this issue we need login credentials of http://www.nicovideo.jp/watch/sm18240734. Please send us in email.

Comment 29 by mbollu@chromium.org, Aug 27 2012

Cc: mbollu@chromium.org

Comment 30 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 31 by bugdroid1@chromium.org, Mar 9 2013

Project Member
Labels: -Type-Regression -Area-UI -Mstone-22 -Feature-Flash -Feature-Plugins-Pepper Type-Bug-Regression Cr-UI Cr-Content-Plugins-Flash M-22 Cr-Content-Plugins-Pepper

Comment 32 by bugdroid1@chromium.org, Mar 14 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Comment 33 by bugdroid1@chromium.org, Apr 6 2013

Project Member
Labels: Cr-Blink

Comment 34 by bugdroid1@chromium.org, Apr 6 2013

Project Member
Labels: -Cr-Content-Plugins-Flash Cr-Internals-Plugins-Flash

Comment 35 by bugdroid1@chromium.org, Apr 6 2013

Project Member
Labels: Cr-Internals-Plugins

Comment 36 by bugdroid1@chromium.org, Apr 6 2013

Project Member
Labels: -Cr-Content-Plugins-Pepper Cr-Internals-Plugins-Pepper

Sign in to add a comment