Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 140473 REGRESSION: An item in Node::attributes disappears
Starred by 11 users Reported by andrey.k...@gmail.com, Aug 3 2012 Back to list
Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
Chrome Version       : 21.0.1180.60
URLs (if applicable) :
http://download.fidel.ru/chromeBug.html
http://download.fidel.ru/chromeBug.mov
Other browsers tested:
     Chrome 21 (MAC OS): FAIL
Chrome 20 (Win and MAC): OK
               Safari 5: OK
            Firefox 4.x: OK
                 IE   9: OK

What steps will reproduce the problem?
1. Open example page
2. Click on the different links some times (about 30-60 times)

What is the expected result?
Anchor should be changed after each click

What happens instead?
After some clicks Anchor not changed, click event not raised.

Additional info:
Screencast link:
http://download.fidel.ru/chromeBug.mov
Example page link:
http://download.fidel.ru/chromeBug.html

When I attach event to elements via jQuery delegate style ($(window).on('click', '.link', function()...)), eventHandler stop calling after some time

$(window).on('click', '.link', function(){...})
problem in this line. When I precise elements selector ('.link') by adding some other container that in window, all works fine

$(window).on('click', 'ul .link', function(...){}) - this works fine
 
Comment 1 by reddu...@gmail.com, Aug 3 2012
I saw the exact same problem today, after last update Chrome 21.0.1180.60.
All of my jQuery delegated mouse event fail, no problem on other browsers.
Labels: -OS-Windows OS-Mac
Cc: ligim...@chromium.org smokana@chromium.org pavanv@chromium.org
Labels: -Type-Bug -Area-Undefined Type-Regression Area-UI
Status: Untriaged
I am able to repro the issue. 

This is a regression issue and below is the bisect info:
Good Build: 21.0.1175.0 beta
Bad Build: 21.0.1176.0 beta
Comment 4 by dhw@chromium.org, Aug 6 2012
Labels: -Pri-2 Pri-1 Mstone-22
Summary: REGRESSION: Click event is missing eventually in Chrome 21 stable browser (was: NULL)
Regression is between two Beta v.21 builds.  Merge any fix back to Chrome 21?
It is working fine on current stable 21.0.1180.57 on Mac 10.7.4
Broken between  21.0.1180.57 and 21.0.1180.60.

CHANGELOG URL:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=149061:149084
Built at revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=149084
Labels: ReleaseBlock-Stable
Comment 7 by kareng@google.com, Aug 6 2012
Owner: pavanv@chromium.org
Status: Assigned
the information here is conflicting. is the regression from .57 to .60 or 
Good Build: 21.0.1175.0 beta
Bad Build: 21.0.1176.0 beta

pavan can u please bisect again this bisect data makes no sense. 
Labels: -OS-Mac OS-All
Owner: ----
Status: Available
comment #3 holds good for me
I could repro this issue on 21.0.1176.0 on Win and Mac, while 21.0.1175.0 worked fine on both Mac OSX 10.7.4 and Win7 

Good Build: 21.0.1175.0 beta
Bad Build: 21.0.1176.0 beta
Comment 9 by k...@google.com, Aug 6 2012
Labels: -Mstone-22 Mstone-21
Please keep targeted at the mstone we see this in.
Comment 10 by kareng@google.com, Aug 6 2012
ok so was bisect able to give us more info? or bisecting between those two didn't work?
Comment 11 by kareng@google.com, Aug 6 2012
1175
Chrome code@142336
Webkit code@120368

1176
Chrome code@142499
Webkit code@120455

so chrome range:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=%2Ftrunk%2Fsrc&range=142336%3A142499&mode=html

webkit range:
http://trac.webkit.org/log/?rev=120455&stop_rev=120368&verbose=on


Comment 12 by kareng@google.com, Aug 6 2012
Cc: jam...@chromium.org abarth@chromium.org
Owner: tkent@chromium.org
Status: Assigned
adam is guessing it might be  http://trac.webkit.org/changeset/120389

tkent can u do a local build without and see if this is what regressed us?
Labels: -Area-UI Area-WebKit
The problem occurs in quickIs function of jQuery.

        quickIs = function( elem, m ) {
                var attrs = elem.attributes || {};
                return (
                        (!m[1] || elem.nodeName.toLowerCase() === m[1]) &&
                        (!m[2] || (attrs.id || {}).value === m[2]) &&
                        (!m[3] || m[3].test( (attrs[ "class" ] || {}).value ))
                );
        },

elem.attributes["class"] becomes undefined though it should be an Attr object for class="link" attribute and elem.className returns "link" correctly.


Cc: -jam...@chromium.org rniwa@chromium.org
Labels: WebKit-DOM WebKit-JavaScript
I confirmed reverting http://trac.webkit.org/changeset/120389 didn't fix the issue.
I reproduced this issue on 22.0.1228.2 canary, but couldn't reproduce on Safari + WebKit nightly.

I guess this is a GC issue, or a Node::attributes (NamedNodeMap) issue.


Labels: -WebKit-DOM
Owner: danno@chromium.org
My bisect result:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=142167%3A142181

Comment 16 by kareng@google.com, Aug 7 2012
Cc: jkummerow@chromium.org
danno tkent bisected to 
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=142167%3A142181

looks like it might be the v8 roll?
Cc: haraken@chromium.org
Summary: REGRESSION: An item in Node::elements disappears (was: NULL)
I attach a reproduction with readable jQuery and some console output.
* How to repeat
1. Download the attached click-stop-bug-cr140473.html
2. Open it with Google Chrome 21
3. Open the JavaScript console
4. Click one of the list items repeatedly.
   It's ok to click the same item many times.
   You'll see a message like the following on every click:
       NN: window.onclick fired:[object HTMLLIElement] 
  However, the message will stop by this issue.
  I needed to click 80 times to reproduce the issue on SnowLeopard.


If we access attrs.length before attrs["class"], the issue is resolved.
If we do GC manually in DevTools, the issue is resolved (the message will be shown again).

click-stop-bug-cr140473.html
396 KB View Download
Summary: REGRESSION: An item in Node::attributes disappears (was: NULL)
Cc: tkent@chromium.org
Cc: danno@chromium.org
Owner: erik.co...@gmail.com
It's a V8 bug.
I bisected it down to V8 bleeding_edge revision 11780.

"During" (i.e. triggered by) the last click that works as expected, the function quickIs() is optimized. The first click after that does not work as expected. I'm attaching --print-opt-code output for quickIs() for both the last good revision (11778) and current bleeding_edge, where it is still broken.

I suspect that the elem.attributes load works (as it calls into the runtime immediately), whereas the attrs["class"] load handles a bunch of cases in generated code and is probably what's broken. I haven't tested this theory, though.
quickis-working.txt
57.6 KB View Download
quickis-broken.txt
61.9 KB View Download
Thanks to everyone for narrowing this down.  It turned out to be an issue with Crankshaft and interceptors (catch-all getters in the DOM).  A fix has been committed to V8 bleeding edge (r12271), which we will be pushing to Chrome as testing verifies it.  https://chromiumcodereview.appspot.com/10837141

Cc: vivianz@chromium.org anan...@chromium.org
 Issue 140430  has been merged into this issue.
Comment 23 by k...@google.com, Aug 8 2012
Labels: Mstone-22
We'll likely need this on the M22 v8 branch when it's ready.
This issue is fixed . Build Used : 21.0.1180.77 (Official Build 150576)

OS : Win 7 , Mac & Linux Ubuntu 10.04/64 Bit 

Comment Regarding the dup- http://code.google.com/p/chromium/issues/detail?id=140430

Try navigating to www.infomaximum.com, Chrome seems to be blacklisted .. Two days before I have navigated to the site for getting the bisect Info .Attached the screenshot.



Firefox.JPG
58.5 KB View Download
chrome-blacklisted.JPG
39.4 KB View Download
 Issue 140430  has been merged into this issue.
 Issue 140430  has been merged into this issue.
Comment 27 by kareng@google.com, Aug 9 2012
Status: Fixed
Comment 28 by Deleted ...@, Aug 23 2012
I am a common user of Google Chrome.  I recently purchased an new HP notebook running Win 7 and I am having problems with chrome loading blank pages and sometimes static pages.  I think this string deals with that and what exactly was the fix?  
Comment 29 by tkent@chromium.org, Aug 24 2012
@edward.glasser
I don't think your issue is related to this.  Please search for a similar issue, or file a new issue.

Project Member Comment 30 by bugdroid1@chromium.org, Oct 13 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 31 by bugdroid1@chromium.org, Mar 9 2013
Labels: -Type-Regression -Area-WebKit -Mstone-21 -WebKit-JavaScript -Mstone-22 Cr-Content Type-Bug-Regression Cr-Content-JavaScript M-21 M-22
Project Member Comment 32 by bugdroid1@chromium.org, Mar 14 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member Comment 33 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content Cr-Blink
Project Member Comment 34 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content-JavaScript Cr-Blink-JavaScript
Sign in to add a comment