New issue
Advanced search Search tips
Starred by 16 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2014
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----


Sign in to add a comment
link

Issue 140205: Implementing the HTML <dialog> element

Reported by peter@chromium.org, Aug 2 2012 Project Member

Issue description

*High-level description of the change (1-2 sentences):*
Implementing support for the HTML <dialog> element, which provides a declarative way of showing (optionally modal) dialogs or windows within the context of the current page.

*Listing of additions/modifications/changes to API surface (bullet
points):*
HTML: <dialog> element.
JavaScript: HTMLDialogElement interface and accompanying methods.

---------
Additional context (fill in as much as you can, or link to a prior API
launch bug with the context):
https://bugs.webkit.org/show_bug.cgi?id=84635

*Link to relevant public standards discussion:*
http://www.whatwg.org/specs/web-apps/current-work/multipage/commands.html#the-dialog-element

*Support in other browsers (current and expected):*
Unknown. It's part of HTML and provides a declarative solution for a fairly common use-case, so I expect it to gain attention from authors.
 

Comment 1 by meh@chromium.org, Nov 6 2012

Labels: Mstone-25
Moving to M25 for now so this is reviewed in the web platform weekly meeting.

Max

Comment 2 by meh@chromium.org, Nov 21 2012

Labels: -Mstone-25 Mstone-X

Comment 3 by falken@chromium.org, Dec 11 2012

Status: Started

Comment 4 by bugdroid1@chromium.org, Dec 12 2012

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=172676

------------------------------------------------------------------------
r172676 | falken@chromium.org | 2012-12-12T22:41:18.899375Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=172676&r2=172675&pathrev=172676

Include <dialog> in --enable-experimental-webkit-features flag

BUG= 140205 

Review URL: https://codereview.chromium.org/11545003
------------------------------------------------------------------------

Comment 5 by bugdroid1@chromium.org, Mar 9 2013

Project Member
Labels: -OWP-DesignReview-No OWP-Design-No

Comment 6 by falken@chromium.org, Apr 17 2013

Blockedon: chromium:232268

Comment 7 by kenjibaheux@chromium.org, Apr 26 2013

Blockedon: chromium:234072
Labels: WebKit-ID-84635

Comment 8 by falken@chromium.org, May 13 2013

Blockedon: chromium:240253

Comment 9 by falken@chromium.org, May 14 2013

Blockedon: chromium:240576

Comment 10 by falken@chromium.org, May 14 2013

Blockedon: chromium:239406

Comment 11 by falken@chromium.org, May 17 2013

Blockedon: chromium:241699

Comment 13 by bugdroid1@chromium.org, Jun 6 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=151903

------------------------------------------------------------------------
r151903 | falken@chromium.org | 2013-06-06T08:44:37.903719Z

Changed paths:
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/top-layer-position-relative-expected.html?r1=151903&r2=151902&pathrev=151903
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/top-layer-position-relative.html?r1=151903&r2=151902&pathrev=151903
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/resolver/StyleResolver.cpp?r1=151903&r2=151902&pathrev=151903
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/top-layer-position-static-expected.txt?r1=151903&r2=151902&pathrev=151903
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/top-layer-position-relative-expected.txt?r1=151903&r2=151902&pathrev=151903
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/top-layer-position-static-expected.html?r1=151903&r2=151902&pathrev=151903
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/top-layer-position-static.html?r1=151903&r2=151902&pathrev=151903

Simplify 'position' adjustment of top layer elements

Previously, we adjusted 'position' and 'display' for top layer
elements. There is already code to adjust the 'display' of positioned
elements, using equivalentBlockDisplay. This commit moves top layer
element adjustment above that code, so we don't have to set display
separately.

Also, convert the relevant layout tests from ref-tests to check-layout
tests, as they are just testing position.

BUG= 140205 

Review URL: https://chromiumcodereview.appspot.com/16529003
------------------------------------------------------------------------

Comment 14 by falken@chromium.org, Jun 10 2013

Blockedon: chromium:248006

Comment 15 by falken@chromium.org, Jun 24 2013

Blockedon: chromium:253357

Comment 16 by falken@chromium.org, Jun 25 2013

Blockedon: chromium:253909

Comment 17 by falken@chromium.org, Jul 10 2013

Blockedon: chromium:258759

Comment 18 by falken@chromium.org, Jul 26 2013

Blockedon: chromium:264959

Comment 19 by falken@chromium.org, Jul 26 2013

Blockedon: chromium:264961

Comment 20 by falken@chromium.org, Aug 21 2013

Blockedon: chromium:276785

Comment 21 by bugdroid1@chromium.org, Aug 26 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=156704

------------------------------------------------------------------------
r156704 | falken@chromium.org | 2013-08-26T14:55:37.625559Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/resources/dialog.css?r1=156704&r2=156703&pathrev=156704
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-stacking-dynamic-expected.html?r1=156704&r2=156703&pathrev=156704
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/non-modal-dialog-containing-block-expected.html?r1=156704&r2=156703&pathrev=156704
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/regions/dialog-autoheight.html?r1=156704&r2=156703&pathrev=156704
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/non-anchored-dialog-positioning.html?r1=156704&r2=156703&pathrev=156704
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderTheme.cpp?r1=156704&r2=156703&pathrev=156704
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/resources?r1=156704&r2=156703&pathrev=156704
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/removed-element-is-removed-from-top-layer-expected.html?r1=156704&r2=156703&pathrev=156704
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-containing-block-expected.html?r1=156704&r2=156703&pathrev=156704
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-display-none-expected.html?r1=156704&r2=156703&pathrev=156704
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-stacking-correct-order-remove-readd-expected.html?r1=156704&r2=156703&pathrev=156704
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-stacking-expected.html?r1=156704&r2=156703&pathrev=156704

Set <dialog> width and height to 'fit-content'.

As per the spec: http://html5.org/r/8151

BUG= 140205 
TBR=tkent

Review URL: https://chromiumcodereview.appspot.com/23060031
------------------------------------------------------------------------

Comment 22 by falken@chromium.org, Sep 5 2013

Blockedon: chromium:285775

Comment 23 by falken@chromium.org, Sep 25 2013

Blockedon: chromium:298051

Comment 24 by falken@chromium.org, Sep 25 2013

Comment 25 by bugdroid1@chromium.org, Sep 27 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=158311

------------------------------------------------------------------------
r158311 | falken@chromium.org | 2013-09-25T08:55:12.649961Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-nesting.html?r1=158311&r2=158310&pathrev=158311
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderTheme.cpp?r1=158311&r2=158310&pathrev=158311
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html?r1=158311&r2=158310&pathrev=158311
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/inert-node-is-not-highlighted.html?r1=158311&r2=158310&pathrev=158311
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/removed-element-is-removed-from-top-layer.html?r1=158311&r2=158310&pathrev=158311
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-containing-block.html?r1=158311&r2=158310&pathrev=158311
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/modal-dialog-backdrop.html?r1=158311&r2=158310&pathrev=158311
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-display-none.html?r1=158311&r2=158310&pathrev=158311
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-stacking-correct-order-remove-readd.html?r1=158311&r2=158310&pathrev=158311
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-stacking.html?r1=158311&r2=158310&pathrev=158311
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/dialog/top-layer-stacking-dynamic.html?r1=158311&r2=158310&pathrev=158311

Make dialog::backdrop span the viewport by default.

As per the recent spec change: http://html5.org/r/8197

No new test, covered by modifying modal-dialog-backdrop.html
Existing tests that don't test backdrop specifically are
modified to have display: none backdrops.

BUG= 140205 

Review URL: https://chromiumcodereview.appspot.com/24493004
------------------------------------------------------------------------

Comment 26 by falken@chromium.org, Oct 7 2013

Comment 27 by falken@chromium.org, Oct 7 2013

Blockedon: chromium:304827

Comment 29 by falken@chromium.org, Jun 14 2014

Status: Fixed
Marking this bug as fixed now that the experimental flag was removed.

Further work on dialog can be tracked in other bugs.

Sign in to add a comment