New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Jun 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
link

Issue 14004: xmonad doesn't support gdk_screen_get_window_stack

Reported by est...@chromium.org, Jun 12 2009 Project Member

Issue description

Try to drag a tab in ToT linux chromium using xmonad. You will crash.

r18098 | jhawkins@chromium.org | 2009-06-10 15:31:45 -0700 (Wed, 10 Jun 
2009) | 5 lines

Use the convenience function gdk_screen_get_window_stack to enumerate top-
level gdk windows instead of querying Xlib directly, which doesn't work 
across many window managers.

BUG=none
TEST=Exhaustive tab dragging in multiple window managers (Compiz, Metacity, 
KWM).
 

Comment 1 by bugdro...@gmail.com, Jun 22 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=18949 

------------------------------------------------------------------------
r18949 | jhawkins@chromium.org | 2009-06-22 13:34:35 -0700 (Mon, 22 Jun 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dock_info_gtk.cc?r1=18949&r2=18948
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/gtk_util.cc?r1=18949&r2=18948
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/gtk_util.h?r1=18949&r2=18948
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/x11_util.cc?r1=18949&r2=18948
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/x11_util.h?r1=18949&r2=18948

Revert to enumerating all X windows if the Window Manager doesn't support _NET_CLIENT_LIST_STACKING.

BUG= 14004 
TEST=Drag tabs in and out of tabstrip in xmonad window manager.
Review URL: http://codereview.chromium.org/141061
------------------------------------------------------------------------

Comment 2 by jh0763...@gmail.com, Jun 22 2009

Status: Fixed
Fixed, please verify.

Comment 3 by est...@chromium.org, Jun 22 2009

Status: Verified
yep, fixed. thanks.

Comment 4 by tony@chromium.org, Jun 23 2009

doesn't crash in ion2 either

Comment 5 by bugdro...@gmail.com, Jun 25 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=19303 

------------------------------------------------------------------------
r19303 | jhawkins@chromium.org | 2009-06-25 16:10:39 -0700 (Thu, 25 Jun 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/gtk_util.cc?r1=19303&r2=19302
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/x11_util.cc?r1=19303&r2=19302
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/x11_util.h?r1=19303&r2=19302

Two tab dragging fixes for various window managers:
* Reverse the order of enumeration when enumerating all top-level windows.  XQueryTree returns the list of windows in bottom-to-top order, while DockInfo expects the windows in top-to-bottom order (ratpoison WM, Awesome WM).
* Extend the enumeration one level deeper for window managers that parent top-level windows into an unnamed real top-level window (ion WM).

BUG= 14004 
TEST=Extensive tab dragging in the following WMs: Metacity, Compiz, kwm, ion3, xmonad, ratpoison, awesome.
Review URL: http://codereview.chromium.org/149028
------------------------------------------------------------------------

Comment 6 by bugdroid1@chromium.org, Oct 12 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Sign in to add a comment