Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 138962 Mountain Lion: Use new download progress bar in the dock
Starred by 15 users Project Member Reported by a...@chromium.org, Jul 25 2012 Back to list
Status: Fixed
Owner: a...@chromium.org
Closed: Aug 2012
Cc: asanka@chromium.org, rdsmith@chromium.org
Components:
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 68206


Sign in to add a comment
http://arstechnica.com/apple/2012/07/os-x-10-8/3/#the-dock

Siracusa notes a progress bar in the dock when downloading. Chromium should follow suit; if running on Mountain Lion, it should use the new progress bar in the dock in preference to its own.

I have no idea how to do that yet.
 
dock-progress-bar.png
25.5 KB View Download
Comment 1 by a...@chromium.org, Jul 25 2012
More precisely, when clicking to initiate a download targeted at _any_ folder that's in the dock (not just the Downloads folder) from Safari, the icon flies from the webpage in an arc into the folder's icon in the dock, and then the progress bar happens. The download folder gives its usual bounce when done.

The other thing is that download progresses are shows in the Finder (see attached picture). That would be nice too.
Screen Shot 2012-07-25 at 5.53.18 PM.png
14.6 KB View Download
Comment 2 by rsesek@chromium.org, Jul 25 2012
I think we've had a long-standing bug about badging the file icon with download progress, which is what Safari used to do before the Finder got smart like this in 10.8.
Comment 3 by a...@chromium.org, Jul 25 2012
Splitting progress to another bug, issue 139027.
Comment 4 by a...@chromium.org, Jul 26 2012
Wow.

Started ripping apart -[DownloadProgressEntry(DownloadProgressEntryInternal) _startReportingProgress]. What do we have?

I need to go home now, but go class-dump Foundation.framework. Check out the entire progress framework, starting with NSProgress and going up.
Comment 5 by rsesek@chromium.org, Jul 26 2012
Labels: Feature-Downloads
Status: Assigned
Comment 6 by a...@chromium.org, Jul 26 2012
Preliminary results. What's weird is that it doesn't work twice, but if you quit and run it again it works.
progress.zip
29.7 KB Download
Comment 7 by a...@chromium.org, Jul 26 2012
Issue 139027 has been merged into this issue.
Comment 8 by a...@chromium.org, Jul 26 2012
New version, now with cancellation support and more.
progress.zip
30.6 KB Download
Cc: asanka@chromium.org rdsmith@chromium.org
Blocking: chromium:68206
Comment 11 by a...@chromium.org, Aug 12 2012
Status: Fixed
Fixed with a change that involved a reorganization of all download system integration. Done. Woot!
Comment 12 by a...@chromium.org, Aug 12 2012
(See bug 21043 for pre-ML.)
Project Member Comment 13 by bugdroid1@chromium.org, Aug 13 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=151195

------------------------------------------------------------------------
r151195 | avi@chromium.org | 2012-08-12T02:25:13.589308Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_status_updater_win.cc?r1=151195&r2=151194&pathrev=151195
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_completion_observer_win.cc?r1=151195&r2=151194&pathrev=151195
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_completion_observer_win.h?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_util_mac.h?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/supports_user_data.cc?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_item_mac.mm?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/supports_user_data.h?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_status_updater_unittest.cc?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_status_updater.cc?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_status_updater.h?r1=151195&r2=151194&pathrev=151195
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_status_updater_mac.mm?r1=151195&r2=151194&pathrev=151195
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_status_updater_gtk.cc?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_util.cc?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_util.h?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/download/download_util_mac.mm?r1=151195&r2=151194&pathrev=151195
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=151195&r2=151194&pathrev=151195

Unify and clean up system download notifications, add Mountain Lion support.

BUG= 138962 
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/10827207
------------------------------------------------------------------------
Comment 14 by Deleted ...@, Sep 24 2012
When downloading a file with chrome the progress bar display of Mac OS X ML (10.8.2) gets corrupted! It hangs in a random progress state (at the dock's download folder icon) and in the initial progress bar state in the finder's download folder. This bug is very annoying. Only clearing Mac OS' caches and a reboot helps to solve the problem -  but just until the next file download.

This bug only occurs while using chrome.

Chrome version: 23.0.1271.1 dev
Bildschirmfoto 2012-09-24 um 13.35.56.png
503 KB View Download
Bildschirmfoto 2012-09-24 um 13.36.06.png
570 KB View Download
Bildschirmfoto 2012-09-24 um 13.36.18.png
566 KB View Download
Comment 15 by mark@chromium.org, Sep 24 2012
Comment 14 is bug 150743.
Comment 16 by Deleted ...@, Sep 24 2012
Deleting chrome's cache and download history fixes the problem immediately! -.-

Let's see, if it will reappear...
Project Member Comment 17 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Feature-Downloads Cr-UI-Browser-Downloads Cr-UI
Sign in to add a comment