Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 137071 Upstream diff from third_party/openssl
Starred by 6 users Project Member Reported by yfried...@chromium.org, Jul 12 2012 Back to list
Status: Fixed
Owner:
Closed: Jan 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----

Blocking:
issue 161782



Sign in to add a comment
We have a local patch downstream and some misc changes
 
Comment 1 by joth@chromium.org, Jul 12 2012
Cc: digit@chromium.org
Status: Untriaged
Status: Available
Owner: digit@chromium.org
Status: Assigned
digit mentioned switching us to a later version of openssl. I think this'll eliminate the need for our diff.
Comment 5 by vinodkr@google.com, Sep 10 2012
Labels: -Mstone-23 Mstone-24
Labels: ReleaseBlock-Dev
Labels: Area-Internals
While writing upstreaming summary, I saw this http://src.chromium.org/viewvc/chrome?view=rev&revision=164645

I assume we just need to roll DEPS upstream and can revert the changes downstream?
Project Member Comment 9 by bugdroid1@chromium.org, Nov 7 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=166429

------------------------------------------------------------------------
r166429 | digit@chromium.org | 2012-11-07T15:16:59.098794Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=166429&r2=166428&pathrev=166429

Upgrade openssl to release 1.0.1c.

This is the DEPS roll corresponding to the following patch:
https://chromiumcodereview.appspot.com/10911247/

This has been tested by:

- Rebuilding chromium and flip_in_mem_edsm_server for Linux/x64,
  the latter links openssl statically.

- Rebuilding everything for Android/ARM, which uses OpenSSL to implement
  SSL/TLS and some aspects of certificate verification.

- Back-porting this change to internal Chrome on Android tree, and
  verifying that net_unittests still pass after it. Also launched
  the browser and check that it can still visit a few HTTPS web
  pages.

BUG= 137071 
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11363080
------------------------------------------------------------------------
Comment 10 by vinodkr@google.com, Nov 13 2012
Labels: -Mstone-24 Mstone-25
Comment 11 by digit@chromium.org, Nov 19 2012
Blocking: chromium:161782
Comment 12 by laforge@google.com, Nov 27 2012
Labels: Project-Refresh
Labels: -ReleaseBlock-Dev
Did we ever roll OpenSSL forward again?
Project Member Comment 15 by bugdroid1@chromium.org, Dec 7 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=171794

------------------------------------------------------------------------
r171794 | digit@chromium.org | 2012-12-07T17:10:51.154298Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/openssl/config/k8/openssl/opensslconf.h?r1=171794&r2=171793&pathrev=171794
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/openssl/config/piii/openssl/opensslconf.h?r1=171794&r2=171793&pathrev=171794
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/openssl/openssl.gyp?r1=171794&r2=171793&pathrev=171794

Small patch to fix the "linux_redux" Chromium build.

Trying to DEPS roll the previous patch, which updates the
library to 1.0.1c, doesn't work for the following reason:

- third_party/libjingle is now referencing DTLSv1_client_method
  and DTLSv1_server_method, which were missing from openssl.gyp
  (this affects both Android and linux_redux builds).

- The piii/k8 configuration files didn't disable CAST5 and
  Whirlpool like the Android one, and the corresponding source
  files are missing from openssl.gyp.

- The piii config now enables inline assembly, but the
  source repository is missing the assembly source for
  the ia32 OPENSSL_setup_cpuid() function.

- The implementation source file for SHA-0 is not listed
  in openssl.gyp to match the Android build, which does
  explicitely disable this weak hash.

This patch is used to fix these issues in the most straightforward
way. It is possible to address the issues by adding missing source
files, but I'd rather do this in the upstream Android external/openssl
tree first, to minimize the differences between them.

BUG= 137071 
TEST=Passed net_unittests on both linux_redux and Android builds.

Review URL: https://chromiumcodereview.appspot.com/11467016
------------------------------------------------------------------------
Project Member Comment 16 by bugdroid1@chromium.org, Dec 10 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=172029

------------------------------------------------------------------------
r172029 | digit@chromium.org | 2012-12-10T10:39:54.978798Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/openssl/config/k8/openssl/opensslconf.h?r1=172029&r2=172028&pathrev=172029

Fix x86 linux_redux build.

This should have been part of the previous patch. Not sure why this
was left out. Without this, the x64 build fails with a link error due
to undefined OPENSSL_setup_cpuid function.

BUG= 137071 
TBR=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/11494005
------------------------------------------------------------------------
Labels: -Mstone-25 -Project-Refresh Mstone-26
Status: Fixed
Project Member Comment 19 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-Internals -Mstone-26 Cr-Internals M-26
Sign in to add a comment