New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 136567 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO
Closed: Jul 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 133810

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Chrome shortcut loses Metro properties in Windows 8 on in-use installs.

Project Member Reported by gab@chromium.org, Jul 10 2012

Issue description

Version: Over-install M22 on 21.0.1180.15 beta-m
OS: Windows 8

What is the expected output?
Although Chrome's shortcut is updated (because of my various registry patches), the shortcut should keep its Metro properties.

What do you see instead?
The shortcut loses its Metro properties.

However its clearly just a notification issue with Windows because the shortcut has been updated (checked with AppId.exe) and hitting a default in "Default Programs" (which from previous experience refreshes the Windows icon cache) makes the Metro properties come back.
 

Comment 1 by gab@chromium.org, Jul 10 2012

To be clear, the M22 I'm using is 22.0.1200.0 (but the current dev-channel also causes this issue), in fact any Chrome with my suffix changes (that forces the shortcut to update) will cause this (i.e. the next Chrome beta).
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 10 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145987

------------------------------------------------------------------------
r145987 | gab@chromium.org | Tue Jul 10 16:29:15 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/base/file_util_win.cc?r1=145987&r2=145986&pathrev=145987

Do not specify SHCNF_FLUSHNOWAIT on SHChangeNotify after updating shortcuts.

Specifying it seems to push Windows to clear its cache before the changes to the shortcut have actually gone in.

This results in losing Metro properties when the shortcut is modified on Windows 8.

BUG= 136567 
TEST=Over-install my custom 22.0.1200.0 build over 21.0.1180.15 beta-m (when its default) and make sure the shortcut keeps its Metro properties (I've confirmed many times that it doesn't on the same custom build without my fix).


Review URL: https://chromiumcodereview.appspot.com/10692138
------------------------------------------------------------------------

Comment 3 by gab@chromium.org, Jul 11 2012

Labels: Mstone-21 Merge-Requested
I tested the fix today in the official (but non-sizygy'ed/non-canarized) build 22.0.1203.0.

Comment 4 by gab@chromium.org, Jul 11 2012

Blocking: chromium:133810

Comment 5 by karen@chromium.org, Jul 11 2012

Labels: -Mstone-21 MovedFrom-21 Mstone-22
Moving all non essential bugs to the next Milestone

Comment 6 by kareng@google.com, Jul 11 2012

moving back 21

Comment 7 by kareng@google.com, Jul 11 2012

Labels: -Mstone-22 Mstone-21

Comment 8 by kareng@google.com, Jul 11 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 11 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=146241

------------------------------------------------------------------------
r146241 | gab@google.com | Wed Jul 11 16:42:40 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/base/file_util_win.cc?r1=146241&r2=146240&pathrev=146241

Merge 145987 - Do not specify SHCNF_FLUSHNOWAIT on SHChangeNotify after updating shortcuts.

Specifying it seems to push Windows to clear its cache before the changes to the shortcut have actually gone in.

This results in losing Metro properties when the shortcut is modified on Windows 8.

BUG= 136567 
TEST=Over-install my custom 22.0.1200.0 build over 21.0.1180.15 beta-m (when its default) and make sure the shortcut keeps its Metro properties (I've confirmed many times that it doesn't on the same custom build without my fix).


Review URL: https://chromiumcodereview.appspot.com/10692138

TBR=gab@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10690153
------------------------------------------------------------------------

Comment 10 by gab@chromium.org, Jul 12 2012

Status: Fixed
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Internals-Install -Mstone-21 M-21 Cr-Internals Cr-Internals-Install
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 5 2013

Labels: -Cr-Internals-Install Cr-Internals-Installer

Sign in to add a comment