New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 135668 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO
Closed: Jul 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Do not suffix ChromeHTML\Application\ApplicationName in the Windows registry

Project Member Reported by gab@chromium.org, Jul 3 2012

Issue description

OS: Windows

This is a user-visible string and shouldn't be suffixed.

It appears in some places (e.g. Default Programs -> "Current Default" column when selecting individual defaults; on over-installs that make Chrome default again).
 

Comment 1 by gab@chromium.org, Jul 4 2012

Fixed in https://chromiumcodereview.appspot.com/10697075/.

See SS attached for bad vs fixed behavior.

This is Windows 8 only as ChromeHTML\Application did not exist prior to Win8.

@Gideon: do we want to merge this in M21 (I say yes)?
no_suffix_in_appname.png
62.4 KB View Download
Cc: kareng@google.com
Yes, definitely if we can. Karen?
Labels: Merge-Requested

Comment 4 by kareng@google.com, Jul 9 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 9 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145770

------------------------------------------------------------------------
r145770 | gab@google.com | Mon Jul 09 15:57:26 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/installer/util/shell_util.cc?r1=145770&r2=145769&pathrev=145770

Merge 145460 - Do not suffix ChromeHTML\Application\ApplicationName in the Windows registry -- it's a user visible string

BUG= 135668 
TEST=No suffix is displayed when selecting defaults on Windows for user-level installs.


Review URL: https://chromiumcodereview.appspot.com/10697075

TBR=gab@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10759009
------------------------------------------------------------------------

Comment 6 by gab@chromium.org, Jul 10 2012

Status: Fixed
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Internals-Install -Mstone-21 M-21 Cr-Internals Cr-Internals-Install
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 5 2013

Labels: -Cr-Internals-Install Cr-Internals-Installer

Sign in to add a comment