New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 135304 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Disappearing Tabs On Windows 8

Reported by truthfro...@gmail.com, Jun 30 2012

Issue description

Chrome Version       : 21.0.1180.15
URLs (if applicable) : ALL
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5: OK
  Firefox 4.x: OK
       IE 7/8/9: OK

What steps will reproduce the problem?
1. Open up a metro app, such as messaging or calendar.
2. Switch to desktop. Open Google Chrome with some tabs.
3. Drag the metro app to make it a sidebar app while having Chrome open on the desktop. The desktop should take up 3/4 of the screen (doesn't matter if metro app is on the left side or right side of screen).

What is the expected result?
Tabs to be viewable.

What happens instead?
Tabs disappear, only showing the window form, menu bar and (if showing already) the bookmarks bar.

Please provide any additional information below. Attach a screenshot if possible.

This is Windows 8 Release Preview. It is possible that this is an issue relating to Metro and not Chrome, however it may be a good idea to look into this prior to the confirmed release of Google Chrome for Windows 8.
 
chrome_win8_bug.png
414 KB View Download

Comment 1 by meh...@chromium.org, Jun 30 2012

Labels: Hotlist-Windows8
Cc: robertshield@chromium.org cpu@chromium.org
Labels: -Area-Undefined Area-UI
Carlos, Robert - ideas? (Snap view/tabs disappearing issue.)
So...?
Cc: ananta@chromium.org grt@chromium.org
Thanks for the ping.  Carlos/Robert/Greg/Ananta, ideas? Didn't one of you look at a disappearing tabs issue?

Comment 5 by ananta@chromium.org, Jul 16 2012

Owner: ananta@chromium.org
Status: Assigned

Comment 6 by kareng@google.com, Jul 16 2012

Labels: Mstone-21 Merge-Approved
https://src.chromium.org/viewvc/chrome?view=rev&revision=146921 approved 
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 16 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=146921

------------------------------------------------------------------------
r146921 | ananta@chromium.org | Mon Jul 16 16:09:38 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_frame_win.cc?r1=146921&r2=146920&pathrev=146921

On Windows 8 when a metro app is snapped, all desktop applications receive a resize notification as the work area
is reduced. In Chrome the tabstrip paint would fail as the WM_GETTITLEBARINFOEX message fails to return the correct
minimize offset.

A fix went in to address this by caching the delta of the minimize button which is then applied to the corresponding
client edge. This only addressed the case when the minimize button offset was returned as 0 from the WM_GETTITLEBARINFOEX 
message. At times this offset is negative. 

Fix is to check whether the minimize button offset is > 0 before applying the cached delta.

BUG= 135304 
R=sky
Review URL: https://chromiumcodereview.appspot.com/10783027
------------------------------------------------------------------------

Comment 8 by ananta@chromium.org, Jul 16 2012

Status: Fixed
Fixed and merged.

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 16 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=146922

------------------------------------------------------------------------
r146922 | ananta@chromium.org | Mon Jul 16 16:13:14 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/frame/browser_frame_win.cc?r1=146922&r2=146921&pathrev=146922

Merge 146921 - On Windows 8 when a metro app is snapped, all desktop applications receive a resize notification as the work area
is reduced. In Chrome the tabstrip paint would fail as the WM_GETTITLEBARINFOEX message fails to return the correct
minimize offset.

A fix went in to address this by caching the delta of the minimize button which is then applied to the corresponding
client edge. This only addressed the case when the minimize button offset was returned as 0 from the WM_GETTITLEBARINFOEX 
message. At times this offset is negative. 

Fix is to check whether the minimize button offset is > 0 before applying the cached delta.

BUG= 135304 
R=sky
Review URL: https://chromiumcodereview.appspot.com/10783027

TBR=ananta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10790022
------------------------------------------------------------------------
Thanks for the fix.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-21 M-21 Cr-UI
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment