New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 135122 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

"Open new window" Win8 functionality doesn't work

Project Member Reported by gab@chromium.org, Jun 29 2012

Issue description

Version: 22.0.1188.0 dev-m
OS: Windows 8

What steps will reproduce the problem?
1. Make chrome default on Win8
2. Right-click Metro icon
3. Select "Open new window" in bar at bottom

What is the expected output?
something?!?!

What do you see instead?
Nothing...
 
Cc: ananta@chromium.org
Ananta, any ideas?
Owner: ananta@chromium.org
Status: Assigned
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 3 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145383

------------------------------------------------------------------------
r145383 | ananta@chromium.org | Tue Jul 03 14:28:19 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/shell_util.h?r1=145383&r2=145382&pathrev=145383
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/shell_util.cc?r1=145383&r2=145382&pathrev=145383

Add the opennewwindow verb to the list of verbs created with a DelegateExecute handler under the Metro Chrome HKCR\<Chrome>/Chromium
key. This is needed for the opennewwindow operation on the chrome metro tile to work correctly.

This fix only ensures that metro chrome launches when we select the open new window operation on the metro tile. Other fixes are needed
to ensure that subsequent open new window operations cause new tabs to get created.

BUG= 135122 
R=gab
Review URL: https://chromiumcodereview.appspot.com/10698086
------------------------------------------------------------------------
New Revision: 26606

Log:
Pass verbs passed into the metro DelegateExecute handler to metro chrome. Currently metro chrome only
has special handling for the opennewwindow verb which should result in a new tab getting created for
every invocation of that command.

This change also fixes the desktop flash seen when we click on the metro chrome icon. The reason is
we end up returning AHE_DESKTOP in the IExecuteCommandApplicationHostEnvironment::GetValue implementation in
the DelegateExecute handler. Reason being the IsImmersiveProcess API returning FALSE for explorer.exe.
Fix is to also check the launching mode, and if it is anything other than ECHUIM_DESKTOP we assume an
immersive launch.

BUG= 135122 
R=cpu
Review URL: https://chromereviews.googleplex.com/4614024
Status: Fixed
New Revision: 26605

Log:
Add support for the opennewwindow verb in metro Chrome. This would be passed by the DelegateExecute handler in the
IApplicationActivationManager::ActivateApplication call.

This ensures that every opennewwindow operation in metro chrome would cause a new tab to get created.

BUG= 135122 
R=cpu
Review URL: https://chromereviews.googleplex.com/4623017

Comment 6 by gab@chromium.org, Oct 5 2012

It appears "opennewwindow" is no longer handled in Chrome (I can't find the string anywhere under src/* except in the installer...) is this a regression?

Comment 7 by gab@chromium.org, Oct 16 2012

Status: Assigned
This has regressed and no longer opens a new tab when Chrome is launched Metro mode with this verb.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 16 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162269

------------------------------------------------------------------------
r162269 | ananta@chromium.org | 2012-10-16T22:19:46.818321Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/win8/metro_driver/chrome_url_launch_handler.cc?r1=162269&r2=162268&pathrev=162269

Fix a crash seen at times when chrome in desktop mode attempts to activate Chrome in Windows 8 mode. The crash
occurs because we attempt to initiate a navigation when there are no frame windows registered with the metro driver.

Fix is to ignore the navigation request in this case.

I also updated the ChromeUrlLaunchHandler::GetUrlFromLaunchArgs function to return the chrome://newtab url if the verb
coming in is opennewwindow. This should address bug http://code.google.com/p/chromium/issues/detail?id=135122

BUG= 155281 , 135122 
R=cpu
Review URL: https://codereview.chromium.org/11193007
------------------------------------------------------------------------

Comment 9 by ananta@chromium.org, Oct 17 2012

Status: Fixed
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18 2012

Labels: merge-merged-1271
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=162799

------------------------------------------------------------------------
r162799 | ananta@chromium.org | 2012-10-18T21:38:02.000893Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/win8/metro_driver/chrome_url_launch_handler.cc?r1=162799&r2=162798&pathrev=162799

Merge 162269 - Fix a crash seen at times when chrome in desktop mode attempts to activate Chrome in Windows 8 mode. The crash
occurs because we attempt to initiate a navigation when there are no frame windows registered with the metro driver.

Fix is to ignore the navigation request in this case.

I also updated the ChromeUrlLaunchHandler::GetUrlFromLaunchArgs function to return the chrome://newtab url if the verb
coming in is opennewwindow. This should address bug http://code.google.com/p/chromium/issues/detail?id=135122

BUG= 155281 , 135122 
R=cpu
Review URL: https://codereview.chromium.org/11193007

TBR=ananta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11190062
------------------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 14 2012

The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=26605

------------------------------------------------------------------------
r26605 | iyengar@google.com | 2012-07-09T21:23:19.411528Z

------------------------------------------------------------------------
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 14 2012

The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=26606

------------------------------------------------------------------------
r26606 | iyengar@google.com | 2012-07-09T21:23:33.569152Z

------------------------------------------------------------------------
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 14 2012

The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=26607

------------------------------------------------------------------------
r26607 | iyengar@google.com | 2012-07-09T21:25:55.974222Z

------------------------------------------------------------------------
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI Cr-UI

Sign in to add a comment