New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 134615 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Pepper Flash: nana10 live stream not loading

Project Member Reported by progame@chromium.org, Jun 26 2012

Issue description

Version: 21.0.1180.11 (Official Build 143993) dev-m
OS: Windows 7

What steps will reproduce the problem?
0. Use pepper flash
1. Open http://10tv.nana10.co.il/
2. You might need to install widows media player plugin
which isn't that easy in Windows because according to
http://support.google.com/chrome/bin/answer.py?hl=en&answer=95697
the old plugin from windows was replaced by an extension but the suggested way to install it is no longer working (you can only install extensions from the store now... so you have to use the workaround of dragging the downloaded extension to chrome://chrome/extensions/ )
3. You might have to answer a question before the video can stream, see picture for the correct button.

video doesn't load...

loads fine if i disable pepper flash
 
tmpnana10.jpg
55.4 KB View Download
same thing goes for mako.co.il live stream
http://www.mako.co.il/makolive&videoChannel=5f24ce1645bc0310VgnVCM2000002a0c10acRCRD&Partner=Flashteaser

disabling pepper flash makes it work again
hmmm media player support on window sis a mess right now...
upon visiting
http://www.vdat.com/techsupport/windowstest.asp
the info bar lets you download the old plugin, http://interoplabs.blob.core.windows.net/wmpff/wmpfirefoxplugin.exe
but that's no longer enough to make the test work

the new extensions on the other hand isn't suggested as far as i can see
Cc: viettrungluu@chromium.org
Cc: -viettrungluu@chromium.org
Owner: viettrungluu@chromium.org
Status: Assigned
I'll take a look at this, assuming Windows Media Player isn't really required (TBD).
Status: Started
RTMPT is apparently busted (at least with some servers). The problem is that Pepper Flash is sending Chrome's regular user agent on requests to port 1935, whereas it should apparently send "Shockwave Flash".

(Running Chrome with --user-agent="Shockwave Flash", which will cause Chrome to send "Shockwave Flash" as the user agent everywhere (!), and loading http://10tv.nana10.co.il/ confirms this.)
Labels: Feature-Plugins-Pepper
I'm guessing this will be too late for M21? sounds like something that can confuse quite a lot of sites (so far i only know about 2 but this is just from my limited bookmarks bar)
Labels: Mstone-21 ReleaseBlock-Stable
Marking as a release blocker for stable since this breaks a large site.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 10 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145885

------------------------------------------------------------------------
r145885 | viettrungluu@chromium.org | Tue Jul 10 09:09:01 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/tests/test_url_request.cc?r1=145885&r2=145884&pathrev=145885
 M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/shared_impl/ppb_url_request_info_shared.cc?r1=145885&r2=145884&pathrev=145885
 M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/shared_impl/ppb_url_request_info_shared.h?r1=145885&r2=145884&pathrev=145885
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/ppapi/ppb_url_request_info_impl.cc?r1=145885&r2=145884&pathrev=145885
 M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/proxy/ppapi_messages.h?r1=145885&r2=145884&pathrev=145885
 M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/c/ppb_url_request_info.h?r1=145885&r2=145884&pathrev=145885
 M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/api/ppb_url_request_info.idl?r1=145885&r2=145884&pathrev=145885
 M http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/cpp/url_request_info.h?r1=145885&r2=145884&pathrev=145885

PPAPI: Add an API for setting a custom user agent for URL requests.

This doesn't hook it up yet.

Pepper Flash needs this for RTMPT.

BUG= 134615 
TEST=not really (except for trivial URL request test)

Review URL: https://chromiumcodereview.appspot.com/10762017
------------------------------------------------------------------------
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 10 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145960

------------------------------------------------------------------------
r145960 | viettrungluu@chromium.org | Tue Jul 10 14:28:05 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/webkit_support.cc?r1=145960&r2=145959&pathrev=145960
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/webkit_support.h?r1=145960&r2=145959&pathrev=145960
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/weburl_loader_mock_factory.cc?r1=145960&r2=145959&pathrev=145960
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/weburl_loader_mock_factory.h?r1=145960&r2=145959&pathrev=145960

Add WebURLLoaderMockFactory::GetLastHandledAsynchronousRequest.

This provides a way of getting the last request that was actually (mock) served,
so that WebKit unit tests can, e.g., inspect headers that were "actually" sent
out.

BUG= http://crbug.com/134615  and https://bugs.webkit.org/show_bug.cgi?id=90893
TEST=see WebKit bug (forthcoming WebKit unit test)

Review URL: https://chromiumcodereview.appspot.com/10735037
------------------------------------------------------------------------
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 10 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145963

------------------------------------------------------------------------
r145963 | viettrungluu@chromium.org | Tue Jul 10 15:03:43 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/ppapi/ppb_url_request_info_impl.cc?r1=145963&r2=145962&pathrev=145963

PPAPI: Set custom user agent in headers, if applicable.

Note: This requires a WebKit change to not overwrite the user agent.

BUG= 134615 
TEST=With a Flapper that sets the user agent under the appropriate
     circumstances (not yet available), check that http://10tv.nana10.co.il/
     streams properly. Or sniff and check that requests to port 1935 have
     "Shockwave Flash" as user agent.

Review URL: https://chromiumcodereview.appspot.com/10701119
------------------------------------------------------------------------

Comment 11 by kareng@google.com, Jul 11 2012

how's this looking on canary?

Comment 12 by prog...@gmail.com, Jul 11 2012

i think another patch still needs approval for it to work ( https://bugs.webkit.org/show_bug.cgi?id=90893 )
Labels: WebKit-ID-90893
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 12 2012

Labels: -WebKit-ID-90893 WebKit-ID-90893-NEW
https://bugs.webkit.org/show_bug.cgi?id=90893
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 17 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147060

------------------------------------------------------------------------
r147060 | viettrungluu@chromium.org | Tue Jul 17 12:16:44 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/support/webkit_support.cc?r1=147060&r2=147059&pathrev=147060
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/ppapi/ppb_url_request_info_impl.cc?r1=147060&r2=147059&pathrev=147060
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=147060&r2=147059&pathrev=147060
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/resource_dispatcher_unittest.cc?r1=147060&r2=147059&pathrev=147060
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/request_extra_data.cc?r1=147060&r2=147059&pathrev=147060
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/request_extra_data.h?r1=147060&r2=147059&pathrev=147060
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/weburlrequest_extradata_impl.cc?r1=147060&r2=147059&pathrev=147060
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=147060&r2=147059&pathrev=147060
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/weburlrequest_extradata_impl.h?r1=147060&r2=147059&pathrev=147060

PPAPI (Flash): Properly honor Pepper url requests with custom user agents.

BUG= 134615 
TEST=With suitably recent Flapper: http://10tv.nana10.co.il/ streams properly
     (see bug for appropriate things to click).

Review URL: https://chromiumcodereview.appspot.com/10780019
------------------------------------------------------------------------
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 17 2012

Labels: -WebKit-ID-90893-NEW WebKit-ID-90893-RESOLVED
https://bugs.webkit.org/show_bug.cgi?id=90893
Cc: jeffreyc@chromium.org
@progame: Could you please check that it works on tomorrow's Canary (r147060 or greater)? Thanks.

Comment 19 by laforge@google.com, Jul 17 2012

Labels: OS-Windows

Comment 20 by prog...@gmail.com, Jul 17 2012

sure

Comment 21 Deleted

tested using:
Google Chrome	22.0.1210.0 (147188) canary
OS	Windows 7
WebKit	537.2 (@122872)
JavaScript	V8 3.12.11
Flash	11.3.31.300

The stream in nana10 and in mako now play :) thanks!

(i'm trying to figure out if there's a slight syncing issue but it's really hard to tell, might be an issue in nana10 or my imagination. will report if i conclude it's a real issue)
Labels: Merge-Requested
Specifically, I want to merge r145885, r145963, and r147060. (No WebKit change was actually needed, and the Flash-side change is already in.)

Comment 24 by kareng@google.com, Jul 19 2012

Status: Fixed
marking fixed so i remember to take this.
r145885 merged to 1180 in r147913.
r145963 merged to 1180 in r147918.
r147060 merged to 1180 in r147922.

(Merge approved by kareng while bug tracker was read-only.)

Comment 26 by kareng@google.com, Jul 23 2012

Labels: -Merge-Requested Merge-Merged merge-merged-1180
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 24 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147913

------------------------------------------------------------------------
r147913 | viettrungluu@chromium.org | 2012-07-23T20:26:34.087747Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/ppapi/api/ppb_url_request_info.idl?r1=147913&r2=147912&pathrev=147913
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/ppapi/proxy/ppapi_messages.h?r1=147913&r2=147912&pathrev=147913
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/ppapi/shared_impl/ppb_url_request_info_shared.cc?r1=147913&r2=147912&pathrev=147913
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/ppapi/shared_impl/ppb_url_request_info_shared.h?r1=147913&r2=147912&pathrev=147913
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/ppapi/cpp/url_request_info.h?r1=147913&r2=147912&pathrev=147913
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/ppapi/c/ppb_url_request_info.h?r1=147913&r2=147912&pathrev=147913
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/ppapi/tests/test_url_request.cc?r1=147913&r2=147912&pathrev=147913
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/plugins/ppapi/ppb_url_request_info_impl.cc?r1=147913&r2=147912&pathrev=147913

Merge 145885 to 1180 (M21) - PPAPI: Add an API for setting a custom user agent for URL requests.

This doesn't hook it up yet.

Pepper Flash needs this for RTMPT.

BUG= 134615 
TEST=not really (except for trivial URL request test)

Review URL: https://chromiumcodereview.appspot.com/10762017

TBR=viettrungluu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10800082
------------------------------------------------------------------------
Project Member

Comment 28 by bugdroid1@chromium.org, Jul 24 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147918

------------------------------------------------------------------------
r147918 | viettrungluu@chromium.org | 2012-07-23T20:27:57.758900Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/plugins/ppapi/ppb_url_request_info_impl.cc?r1=147918&r2=147917&pathrev=147918

Merge 145963 to 1180 (M21) - PPAPI: Set custom user agent in headers, if applicable.

Note: This requires a WebKit change to not overwrite the user agent.

BUG= 134615 
TEST=With a Flapper that sets the user agent under the appropriate
     circumstances (not yet available), check that http://10tv.nana10.co.il/
     streams properly. Or sniff and check that requests to port 1935 have
     "Shockwave Flash" as user agent.

Review URL: https://chromiumcodereview.appspot.com/10701119

TBR=viettrungluu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10802077
------------------------------------------------------------------------
Project Member

Comment 29 by bugdroid1@chromium.org, Jul 24 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147922

------------------------------------------------------------------------
r147922 | viettrungluu@chromium.org | 2012-07-23T20:31:28.626362Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/common/request_extra_data.h?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/glue/weburlrequest_extradata_impl.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/renderer/render_view_impl.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/glue/weburlrequest_extradata_impl.h?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/common/resource_dispatcher_unittest.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/support/webkit_support.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/common/request_extra_data.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/plugins/ppapi/ppb_url_request_info_impl.cc?r1=147922&r2=147921&pathrev=147922

Merge 147060 to 1180 (M21) - PPAPI (Flash): Properly honor Pepper url requests with custom user agents.

BUG= 134615 
TEST=With suitably recent Flapper: http://10tv.nana10.co.il/ streams properly
     (see bug for appropriate things to click).

Review URL: https://chromiumcodereview.appspot.com/10780019

TBR=viettrungluu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10795071
------------------------------------------------------------------------
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 31 by bugdroid1@chromium.org, Nov 8 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147922

------------------------------------------------------------------------
r147922 | viettrungluu@chromium.org | 2012-07-23T20:31:28.626362Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/common/request_extra_data.h?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/glue/weburlrequest_extradata_impl.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/renderer/render_view_impl.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/glue/weburlrequest_extradata_impl.h?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/common/resource_dispatcher_unittest.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/support/webkit_support.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/common/request_extra_data.cc?r1=147922&r2=147921&pathrev=147922
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/webkit/plugins/ppapi/ppb_url_request_info_impl.cc?r1=147922&r2=147921&pathrev=147922

Merge 147060 to 1180 (M21) - PPAPI (Flash): Properly honor Pepper url requests with custom user agents.

BUG= 134615 
TEST=With suitably recent Flapper: http://10tv.nana10.co.il/ streams properly
     (see bug for appropriate things to click).

Review URL: https://chromiumcodereview.appspot.com/10780019

TBR=viettrungluu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10795071
------------------------------------------------------------------------
Labels: -Restrict-AddIssueComment-Commit
progame: Can on you confirm that this is fixed?
Status: Verified
Yes it's fixed as far as i can tell (using the current dev/canary channels builds and also see comment 22 for a much older build). I'm not sure why it was supposedly re-merged into the old 1180 branch (comment 31) after already being merged in comment 29.
Project Member

Comment 34 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Feature-Flash -Feature-Plugins-Pepper -Mstone-21 M-21 Cr-Content-Plugins-Flash Cr-Internals Cr-Content-Plugins-Pepper
Project Member

Comment 35 by bugdroid1@chromium.org, Apr 6 2013

Labels: Cr-Blink
Project Member

Comment 36 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content-Plugins-Flash Cr-Internals-Plugins-Flash
Project Member

Comment 37 by bugdroid1@chromium.org, Apr 6 2013

Labels: Cr-Internals-Plugins
Project Member

Comment 38 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content-Plugins-Pepper Cr-Internals-Plugins-Pepper

Comment 39 by laforge@google.com, Jul 24 2013

Cc: -jeffreyc@chromium.org

Sign in to add a comment