New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 134394 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit 26 days ago
Closed: Jul 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug
RTL

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Hebrew text in Pepper Flash is backwards

Project Member Reported by progame@chromium.org, Jun 25 2012

Issue description

Chrome Version       : 21.0.1180.4
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)

It started in the past month or so... was too overloaded to check when i first saw it.
Chromium builds are unaffected (because Pepper Flash is needed).

How to reproduce:
0. Use Pepper Flash
1. Open a flash video with Hebrew text on it, for example
http://www.youtube.com/watch?v=6Jx3Lc7qeh8&feature=player_detailpage#t=270s
2. Hover over the suggestions at the end to see the backwards Hebrew

Works fine if I disable the Internal Flash plugin in exchange for the original one.



UserAgentString: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.4 Safari/537.1


 

Comment 1 by jeremy@chromium.org, Jun 25 2012

Cc: sh...@chromium.org viettrungluu@chromium.org
Owner: brettw@chromium.org
Status: Available
Brett: Do you know who an look at this, this sounds like a pretty bad regression :(

Comment 2 by jeremy@chromium.org, Jun 25 2012

*can
npapi-correct.PNG
332 KB View Download
pepper-backwards.PNG
336 KB View Download
The above screenshots were taken on Windows. (NPAPI Flash on Windows is correct, I assume.)

Pepper Flash is broken on all platforms, in the same way.

NPAPI Flash on Mac is broken, but in a different way (attached)!

NPAPI Flash on Linux is broken in the same way as Pepper Flash.
mac-npapi-different-backwards.png
229 KB View Download
Labels: Action-BisectNeeded
@progame

can you provide bisect info for this regression issue?
i'm no sure how since pepper flash isn't in the chromium builds

Comment 7 by jeremy@chromium.org, Jun 25 2012

Trung, here's the deal:
* Pepper flash is correctly splitting the BiDi runs but is drawing the letters inside the hebrew runs reversed.
* NPAPI flash on Windows is correct, as you say.
* NPAPI flash on Mac is displaying the string with LTR directionality rather than as RTL, this is causing the difference in the string display.  It's not reversing letters.

I think the bug here is that Pepper flash is drawing RTL runs reversed.
regression window from chrome builds will help narrow down the issue. thanks!
Cc: songsuk@chromium.org
Song,

could you find regression window from the archived Chrome builds directory? thanks!
We don't need a regression window. This was always broken.

Comment 11 by prog...@gmail.com, Jun 25 2012

It's OK using the beta channel build though
Google Chrome	20.0.1132.43 (143823) beta-m
OS	Windows
Status: Assigned
(To clarify, brettw's statement was about it always being broken in Pepper Flash.)

Chrome 20 Beta uses NPAPI Flash.
Labels: -Action-BisectNeeded
Labels: -Type-Regression Type-Bug
Status: Started
Labels: ReleaseBlock-Stable
Summary: Hebrew text in Pepper Flash is backwards
I have a patch for this, currently writing tests.
Labels: Mstone-21
Cc: jeffreyc@chromium.org
Fix confirmed under Windows, thanks :) I'm glad the issue won't reach the stable channel

Google Chrome	22.0.1189.0 (144640) canary
OS	Windows
WebKit	537.1 (@121350)
JavaScript	V8 3.12.4
Flash	11.3.31.213
Labels: Merge-Requested
I don't see any crashes on canary for this so I'd like to merge to 21. Otherwise Flash won't work for RTL text.

The patch isn't super trivial but I don't think it's very risky. This code should only be run with Flash now so there's little risk to other features as well.
We're okay with this being in the M21 Beta2.

Comment 23 by kareng@google.com, Jun 29 2012

ok how about we let it sit till july 9 and we can decide then.
Pinging this b/c it's July 9 now.

Comment 25 by kareng@google.com, Jul 9 2012

Labels: -Merge-Requested Merge-Approved
Labels: -Merge-Approved Merge-Merged
Status: Fixed
Merged in r145768
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 9 2012

Project Member

Comment 28 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Feature-Flash -Feature-I18N -Mstone-21 M-21 Cr-Content-Plugins-Flash Cr-Internals Cr-UI-I18N
Project Member

Comment 30 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 31 by bugdroid1@chromium.org, Mar 20 2013

Labels: -Cr-UI-I18N Cr-UI-Internationalization
Project Member

Comment 32 by bugdroid1@chromium.org, Apr 6 2013

Labels: Cr-Blink
Project Member

Comment 33 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content-Plugins-Flash Cr-Internals-Plugins-Flash

Comment 34 by laforge@google.com, Jul 24 2013

Cc: -jeffreyc@chromium.org

Sign in to add a comment