New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 134372 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 134988

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

More 2x assets for chrome

Project Member Reported by thakis@chromium.org, Jun 24 2012

Issue description

The omnibox blocked contents icon are currently pixel-scaled (the checked-in 2x assets are pixel-scaled), omnibox_star.png is still missing, etc.

Follow-up to  issue 132910 
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 26 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144305

------------------------------------------------------------------------
r144305 | thakis@chromium.org | Tue Jun 26 15:38:23 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=144305&r2=144304&pathrev=144305
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/2x/bookmarks_section_32.png?r1=144305&r2=144304&pathrev=144305
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search.png?r1=144305&r2=144304&pathrev=144305
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/2x?r1=144305&r2=144304&pathrev=144305
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/gritsettings/resource_ids?r1=144305&r2=144304&pathrev=144305
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/bookmark_manager_recent.png?r1=144305&r2=144304&pathrev=144305
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_recent.png?r1=144305&r2=144304&pathrev=144305
 M http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?r1=144305&r2=144304&pathrev=144305
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/component_extension_resources.grd?r1=144305&r2=144304&pathrev=144305
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search_rtl.png?r1=144305&r2=144304&pathrev=144305

Add HiDPI assets for the WebUI bookmarks manager.

Change common.gypi to pass scale_factors=2x to grit on Mac
(as a side effect, the close button on about:settings now looks
good).

Change bookmark_manager/main.html to type="chrome_html"
so that it gets the 2x image auto-treatment that's documented at
sites.google.com/a/chromium.org/dev/developers/design-documents/high-dpi-resources

The icon in the upper left corner of about:bookmarks looks good
with this change, but the tree icons don't yet because cr/ui/tree.js
needs js code changes to make HiDPI icons work.

BUG= 134372 , 123162 
TEST=Open bookmark manager. Almost all images look good in HiDPI.

Review URL: https://chromiumcodereview.appspot.com/10662039
------------------------------------------------------------------------
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144334

------------------------------------------------------------------------
r144334 | thakis@chromium.org | Tue Jun 26 17:24:55 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/blocked_script.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_star.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_extension_app.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/ash/app_list/search_builder.cc?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_extension_app.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_https_invalid.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/default_large_favicon.png?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_https_invalid.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_extension_app_selected.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_100_percent/default_favicon.png?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_warning.pdf?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources_standard.grd?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_https_valid.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/default_200_percent/default_favicon.png?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_search.pdf?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_https_valid.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/blocked_cookies.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/blocked_cookies.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/star_lit.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/blocked_images.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_http_selected.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_tts.png?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_http_selected.png?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_tts.png?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_http.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_search.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/blocked_plugins.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/blocked_plugins.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/blocked_popups.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_match.cc?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_star.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/blocked_script.png?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_extension_app.pdf?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_invalid.pdf?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/omnibox/omnibox_result_view.cc?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_valid.pdf?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_extension_app_selected.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_https_warning.png?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_http.pdf?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_https_warning.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/star_lit.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/blocked_images.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_http_dark.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm?r1=144334&r2=144333&pathrev=144334
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_tts.pdf?r1=144334&r2=144333&pathrev=144334
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/omnibox_search.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/omnibox_http.png?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=144334&r2=144333&pathrev=144334
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/blocked_popups.png?r1=144334&r2=144333&pathrev=144334

HiDPI assets for omnibox icons.

Remove pdf files on Mac and use 2x pngs in the omnibox.

Side effect: The default favicon is now an empty page instead
of a globe.

BUG= 134372 , 111101 
TEST=icons in omnibox are hidpi and generally match the look
on non-mac platforms.
TBR=avi

Review URL: https://chromiumcodereview.appspot.com/10660021
------------------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144337

------------------------------------------------------------------------
r144337 | thakis@chromium.org | Tue Jun 26 17:31:18 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc?r1=144337&r2=144336&pathrev=144337

build fix

BUG= 134372 
TEST=none
TBR=rlp

Review URL: https://chromiumcodereview.appspot.com/10678006
------------------------------------------------------------------------
Labels: Mstone-21 Merge-Requested
I'd like to merge:
r144305 r144334 r144337 r144383 r144386 r144391

All of these are just assets. They make the omnibox and the settings domui look good on HiDPI. I checked that all the assets look solid on canary.

Comment 12 by kareng@google.com, Jun 29 2012

also 144592?
no, it looks like that confuses windows (need to investigate), and about:memory isn't very visible anyways.

Comment 14 by kareng@google.com, Jun 29 2012

ok so these? r144305 r144334 r144337 r144383 r144386 r144391 u absolutely sure there's nothing but pngs in there?
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 2 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145147

------------------------------------------------------------------------
r145147 | thakis@chromium.org | Mon Jul 02 08:14:01 PDT 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/chromium?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/chromium/webstore_icon_24.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium/webstore_icon_24.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/chromium/webstore_icon_16.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium/webstore_icon_16.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/chromium/product_logo.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium/product_logo.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium/product_logo_32.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/chromium/product_logo_white.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/chromium/product_logo_32.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium/product_logo_white.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium/product_logo_16.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/chromium/product_logo_26.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/chromium/product_logo_16.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium/webstore_icon.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/chromium/webstore_icon.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_100_percent/chromium/webstore_icon_32.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium/webstore_icon_32.png?r1=145147&r2=145146&pathrev=145147
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/default_200_percent/chromium?r1=145147&r2=145146&pathrev=145147

Add HiDPI variants of the chromium logo.

The images in default_100_percent are currently in
chrome/app/theme/chromium as well. I'll remove them from
there once the grd changes to use the new location are in.

These icons aren't used anywhere yet, so no functionality
change.

BUG= 134372 
TEST=none
TBR=flackr

Review URL: https://chromiumcodereview.appspot.com/10690063
------------------------------------------------------------------------
Blockedon: chromium:134988
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 3 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145332

------------------------------------------------------------------------
r145332 | thakis@chromium.org | Tue Jul 03 11:04:22 PDT 2012

Changed paths:
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/webstore_icon.png?r1=145332&r2=145331&pathrev=145332
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/image_loading_tracker.cc?r1=145332&r2=145331&pathrev=145332
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=145332&r2=145331&pathrev=145332
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/webstore_icon_32.png?r1=145332&r2=145331&pathrev=145332
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=145332&r2=145331&pathrev=145332
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/webstore_icon_24.png?r1=145332&r2=145331&pathrev=145332
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/webstore_icon_16.png?r1=145332&r2=145331&pathrev=145332
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources_standard.grd?r1=145332&r2=145331&pathrev=145332
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites.cc?r1=145332&r2=145331&pathrev=145332

Add HiDPI webstore icons. Use them on NTP and extensions domui.

BUG= 134372 
TEST=none
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10704053
------------------------------------------------------------------------

Comment 18 by kareng@google.com, Jul 3 2012

Labels: -Merge-Requested Merge-Approved
all up to comment 14 are approved for merge.
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 3 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145336

------------------------------------------------------------------------
r145336 | thakis@chromium.org | Tue Jul 03 11:29:25 PDT 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search_rtl.png?r1=145336&r2=145335&pathrev=145336
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/bookmark_manager_recent.png?r1=145336&r2=145335&pathrev=145336
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search.png?r1=145336&r2=145335&pathrev=145336
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/2x?r1=145336&r2=145335&pathrev=145336
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/tools/gritsettings/resource_ids?r1=145336&r2=145335&pathrev=145336
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_recent.png?r1=145336&r2=145335&pathrev=145336
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/component_extension_resources.grd?r1=145336&r2=145335&pathrev=145336
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/build/common.gypi?r1=145336&r2=145335&pathrev=145336
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/browser_resources.grd?r1=145336&r2=145335&pathrev=145336
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/2x/bookmarks_section_32.png?r1=145336&r2=145335&pathrev=145336

Merge 144305 - Add HiDPI assets for the WebUI bookmarks manager.

Change common.gypi to pass scale_factors=2x to grit on Mac
(as a side effect, the close button on about:settings now looks
good).

Change bookmark_manager/main.html to type="chrome_html"
so that it gets the 2x image auto-treatment that's documented at
sites.google.com/a/chromium.org/dev/developers/design-documents/high-dpi-resources

The icon in the upper left corner of about:bookmarks looks good
with this change, but the tree icons don't yet because cr/ui/tree.js
needs js code changes to make HiDPI icons work.

BUG= 134372 , 123162 
TEST=Open bookmark manager. Almost all images look good in HiDPI.

Review URL: https://chromiumcodereview.appspot.com/10662039

TBR=thakis@chromium.org
------------------------------------------------------------------------
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 3 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145343

------------------------------------------------------------------------
r145343 | thakis@chromium.org | Tue Jul 03 11:45:05 PDT 2012

Changed paths:
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_extension_app.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/blocked_popups.png?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_https_invalid.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/blocked_script.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_star.png?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_https_valid.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_https_warning.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_https_warning.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_https_warning.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_extension_app_selected.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_extension_app_selected.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_http_dark.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/toolbar/toolbar_model.cc?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/theme_resources_standard.grd?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_search.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/star_lit.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/blocked_images.png?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_tts.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/chrome_dll.gypi?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_http.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_http.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_search.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_extension_app.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/ash/app_list/search_builder.cc?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/blocked_popups.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_extension_app.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_extension_app.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/autocomplete/autocomplete_match.cc?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/theme_resources.grd?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/resources/default_100_percent/default_large_favicon.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_https_invalid.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_https_invalid.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_https_invalid.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/blocked_script.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_star.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_star.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/resources/default_100_percent/default_favicon.png?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_https_warning.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_https_valid.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/resources/default_200_percent/default_favicon.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_https_valid.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_https_valid.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/blocked_cookies.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/blocked_cookies.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_extension_app_selected.png?r1=145343&r2=145342&pathrev=145343
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/omnibox_http.pdf?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/star_lit.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/blocked_images.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_http_selected.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_http_selected.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_http_selected.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_tts.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_tts.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_tts.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/blocked_plugins.png?r1=145343&r2=145342&pathrev=145343
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/omnibox_search.png?r1=145343&r2=145342&pathrev=145343 (from /trunk/src/chrome/app/theme/default_200_percent/omnibox_search.png revision 144334)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/blocked_plugins.png?r1=145343&r2=145342&pathrev=145343
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/omnibox_http.png?r1=145343&r2=145342&pathrev=145343

Merge 144334 - HiDPI assets for omnibox icons.

Remove pdf files on Mac and use 2x pngs in the omnibox.

Side effect: The default favicon is now an empty page instead
of a globe.

BUG= 134372 , 111101 
TEST=icons in omnibox are hidpi and generally match the look
on non-mac platforms.
TBR=avi

Review URL: https://chromiumcodereview.appspot.com/10660021

TBR=thakis@chromium.org
------------------------------------------------------------------------
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 3 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145344

------------------------------------------------------------------------
r145344 | thakis@chromium.org | Tue Jul 03 11:45:42 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc?r1=145344&r2=145343&pathrev=145344

Merge 144337 - build fix

BUG= 134372 
TEST=none
TBR=rlp

Review URL: https://chromiumcodereview.appspot.com/10678006

TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10696099
------------------------------------------------------------------------
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 3 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145347

------------------------------------------------------------------------
r145347 | thakis@chromium.org | Tue Jul 03 11:47:23 PDT 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/shared/images/2x/checkbox_white.png?r1=145347&r2=145346&pathrev=145347 (from /trunk/src/chrome/browser/resources/shared/images/2x/checkbox_white.png revision 144386)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/shared/images/check.png?r1=145347&r2=145346&pathrev=145347
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/shared/images/2x/checkbox_black.png?r1=145347&r2=145346&pathrev=145347 (from /trunk/src/chrome/browser/resources/shared/images/2x/checkbox_black.png revision 144386)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/shared/images/checkbox_white.png?r1=145347&r2=145346&pathrev=145347
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/shared/images/2x/check.png?r1=145347&r2=145346&pathrev=145347 (from /trunk/src/chrome/browser/resources/shared/images/2x/check.png revision 144386)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/shared/images/checkbox_black.png?r1=145347&r2=145346&pathrev=145347

Merge 144386 - HiDPI checkbox asset for WebUI

BUG= 134372 
TEST=Open preferences, admire checkboxes
TBR=avi

Review URL: https://chromiumcodereview.appspot.com/10689002

TBR=thakis@chromium.org
------------------------------------------------------------------------
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 3 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145348

------------------------------------------------------------------------
r145348 | thakis@chromium.org | Tue Jul 03 11:48:28 PDT 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/shared/images/2x/disabled_select.png?r1=145348&r2=145347&pathrev=145348 (from /trunk/src/chrome/browser/resources/shared/images/2x/disabled_select.png revision 144391)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/shared/images/select.png?r1=145348&r2=145347&pathrev=145348
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/shared/images/disabled_select.png?r1=145348&r2=145347&pathrev=145348
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/shared/images/2x/select.png?r1=145348&r2=145347&pathrev=145348 (from /trunk/src/chrome/browser/resources/shared/images/2x/select.png revision 144391)

Merge 144391 - HiDPI dropdown arrow for webui

BUG= 134372 
TEST=Look at search engine dropdown arrow
TBR=avi

Review URL: https://chromiumcodereview.appspot.com/10690003

TBR=thakis@chromium.org
------------------------------------------------------------------------
Cc: sail@chromium.org
I'd like to also merge:

r144592 (requires r144552 r145304 r145312 -- all very minor grit changes -- so these too)

I'd like to also merge r145332 (needs chrome-internal 26455 , src-internal 26456 , chrome-internal 26459, src-internal 26460 -- all just internal assets -- and 145147, just public assets)

Once that's in, I'd like to also merge http://codereview.chromium.org/10695052/ and http://codereview.chromium.org/10692069/ , but they obviously need to land first.

I'm out on vacation though. Maybe sail@ can help with merging once he's back.
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 4 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145466

------------------------------------------------------------------------
r145466 | thakis@chromium.org | Wed Jul 04 09:04:16 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=145466&r2=145465&pathrev=145466
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/about_version.html?r1=145466&r2=145465&pathrev=145466
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/product_logo_white.png?r1=145466&r2=145465&pathrev=145466
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=145466&r2=145465&pathrev=145466
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/ntp4/new_tab.html?r1=145466&r2=145465&pathrev=145466
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/ntp4/new_tab.css?r1=145466&r2=145465&pathrev=145466
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/neterror.html?r1=145466&r2=145465&pathrev=145466
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/product_logo.png?r1=145466&r2=145465&pathrev=145466
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources_standard.grd?r1=145466&r2=145465&pathrev=145466

HiDPI chromium logo for NTP, about:version, about:neterror

BUG= 134372 , 135179 
TEST=look at logo

Review URL: https://chromiumcodereview.appspot.com/10695052
------------------------------------------------------------------------
Project Member

Comment 28 by bugdroid1@chromium.org, Jul 4 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145475

------------------------------------------------------------------------
r145475 | thakis@chromium.org | Wed Jul 04 11:12:15 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tab_icon_view.cc?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/confirm_bubble_gtk_browsertest.cc?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_applications/web_app_mac_unittest.mm?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources_standard.grd?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/keystone_infobar_delegate.mm?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/help/help.css?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_installer.gypi?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/spelling_bubble_model.cc?r1=145475&r2=145474&pathrev=145475
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/product_logo_32.png?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run/try_chrome_dialog_view.cc?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/help/help.html?r1=145475&r2=145474&pathrev=145475
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/chromeos/login/oobe.css?r1=145475&r2=145474&pathrev=145475
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/product_logo_26.png?r1=145475&r2=145474&pathrev=145475
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/chromium/product_logo_16.png?r1=145475&r2=145474&pathrev=145475

HiDPI assets for product_logo_16 / _32

Use the new logo on about:chrome

BUG= 134372 , 135179 
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10692069
------------------------------------------------------------------------
Project Member

Comment 29 by bugdroid1@chromium.org, Jul 4 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145477

------------------------------------------------------------------------
r145477 | thakis@chromium.org | Wed Jul 04 11:43:36 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_installer.gypi?r1=145477&r2=145476&pathrev=145477

build fix

BUG= 134372 
TEST=none
TBR=flackr

Review URL: https://chromiumcodereview.appspot.com/10693096
------------------------------------------------------------------------
Labels: Feature-HighDPI
Labels: Merge-Requested
Updated comment 25, now that everything has landed and looks good on canary:

I'd like to also merge:

r144592 (requires r144552 r145304 r145312 -- all very minor grit changes -- so these too)

I'd like to also merge r145332 (needs chrome-internal 26455 , src-internal 26456 , chrome-internal 26459, src-internal 26460 -- all just internal assets -- and 145147, just public assets)

Once that's in, I'd like to also merge r145450 r145466 r145475 r145477

All these changes add hidpi assets to various domui pages (most visibly the chrome logo on the ntp, net error pages, etc)

I'm out on vacation though. Maybe sail@ can help with merging once he's back.

Comment 32 by kareng@google.com, Jul 9 2012

geez! can we just stop for now?

Project Member

Comment 33 by bugdroid1@chromium.org, Jul 10 2012

Comment 34 by karen@chromium.org, Jul 11 2012

Labels: -Mstone-21 MovedFrom-21 Mstone-22
Moving all non essential bugs to the next Milestone

Comment 35 by kareng@google.com, Jul 11 2012

moving back 21

Comment 36 by kareng@google.com, Jul 11 2012

Labels: -Mstone-22 Mstone-21
r146419 too
Just a short question: 
Why isn't it possible to use the great globe icon on every platform and only use the blank page icon on retina displays? (The blank page icon is a bit... uglier than the globe icon, that's why)
Cc: kareng@google.com
karen: I'd like to merge the changes described in comment 31 now. I'm even around to fix compile fallout this time :-P

Comment 41 by kareng@google.com, Jul 19 2012

Labels: -Merge-Requested Merge-Approved
I merged the hidpi chrome logos and the grit stuff to the 1180 branch. I'll merge the grd changes that hook up the new images next.
Project Member

Comment 44 by bugdroid1@chromium.org, Jul 21 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147766

------------------------------------------------------------------------
r147766 | thakis@chromium.org | 2012-07-21T04:05:42.060641Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/chromium/webstore_icon.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/chromium/webstore_icon.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/chromium/product_logo_32.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/chromium/product_logo_32.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/chromium/product_logo_16.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/chromium/webstore_icon_32.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/chromium/webstore_icon_32.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/chromium/product_logo_26.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/chromium/webstore_icon_24.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/chromium/product_logo_16.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/chromium/webstore_icon_24.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/chromium/webstore_icon_16.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/chromium/webstore_icon_16.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/chromium?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/chromium?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/chromium/product_logo_white.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_100_percent/chromium/product_logo.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/chromium/product_logo_white.png?r1=147766&r2=147765&pathrev=147766
   A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/default_200_percent/chromium/product_logo.png?r1=147766&r2=147765&pathrev=147766

Merge 145147 - Add HiDPI variants of the chromium logo.

The images in default_100_percent are currently in
chrome/app/theme/chromium as well. I'll remove them from
there once the grd changes to use the new location are in.

These icons aren't used anywhere yet, so no functionality
change.

BUG= 134372 
TEST=none
TBR=flackr

Review URL: https://chromiumcodereview.appspot.com/10690063

TBR=thakis@chromium.org
------------------------------------------------------------------------
Project Member

Comment 45 by bugdroid1@chromium.org, Jul 21 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147767

------------------------------------------------------------------------
r147767 | thakis@chromium.org | 2012-07-21T04:09:29.391470Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/chromium/webstore_icon_32.png?r1=147767&r2=147766&pathrev=147767
   D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/chromium/webstore_icon_24.png?r1=147767&r2=147766&pathrev=147767
   D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/chromium/webstore_icon_16.png?r1=147767&r2=147766&pathrev=147767
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/extensions/image_loading_tracker.cc?r1=147767&r2=147766&pathrev=147767
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/history/top_sites.cc?r1=147767&r2=147766&pathrev=147767
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/theme_resources.grd?r1=147767&r2=147766&pathrev=147767
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/theme_resources_standard.grd?r1=147767&r2=147766&pathrev=147767
   D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/chromium/webstore_icon.png?r1=147767&r2=147766&pathrev=147767
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/browser_resources.grd?r1=147767&r2=147766&pathrev=147767

Merge 145332 - Add HiDPI webstore icons. Use them on NTP and extensions domui.

BUG= 134372 
TEST=none
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10704053

TBR=thakis@chromium.org
------------------------------------------------------------------------
Project Member

Comment 47 by bugdroid1@chromium.org, Jul 21 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147769

------------------------------------------------------------------------
r147769 | thakis@chromium.org | 2012-07-21T04:16:04.976796Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/about_version.html?r1=147769&r2=147768&pathrev=147769
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/renderer/resources/neterror.html?r1=147769&r2=147768&pathrev=147769
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/ntp4/new_tab.html?r1=147769&r2=147768&pathrev=147769
   D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/chromium/product_logo.png?r1=147769&r2=147768&pathrev=147769
   D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/chromium/product_logo_white.png?r1=147769&r2=147768&pathrev=147769
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/ntp4/new_tab.css?r1=147769&r2=147768&pathrev=147769
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/theme_resources.grd?r1=147769&r2=147768&pathrev=147769
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/theme_resources_standard.grd?r1=147769&r2=147768&pathrev=147769
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/browser_resources.grd?r1=147769&r2=147768&pathrev=147769

Merge 145466 - HiDPI chromium logo for NTP, about:version, about:neterror

BUG= 134372 , 135179 
TEST=look at logo

Review URL: https://chromiumcodereview.appspot.com/10695052

TBR=thakis@chromium.org
------------------------------------------------------------------------
Project Member

Comment 48 by bugdroid1@chromium.org, Jul 21 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147771

------------------------------------------------------------------------
r147771 | thakis@chromium.org | 2012-07-21T04:19:34.089649Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/chrome_installer.gypi?r1=147771&r2=147770&pathrev=147771

Merge 145477 - build fix

BUG= 134372 
TEST=none
TBR=flackr

Review URL: https://chromiumcodereview.appspot.com/10693096

TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10809048
------------------------------------------------------------------------
Project Member

Comment 49 by bugdroid1@chromium.org, Jul 21 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147770

------------------------------------------------------------------------
r147770 | thakis@chromium.org | 2012-07-21T04:18:48.208724Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/chrome_dll.gypi?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/help/help.html?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/keystone_infobar_delegate.mm?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/theme_resources.grd?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/gtk/confirm_bubble_gtk_browsertest.cc?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/tab_icon_view.cc?r1=147770&r2=147769&pathrev=147770
   D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/chromium/product_logo_32.png?r1=147770&r2=147769&pathrev=147770
   D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/chromium/product_logo_16.png?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/ash/launcher/chrome_launcher_controller.cc?r1=147770&r2=147769&pathrev=147770
   D http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/chromium/product_logo_26.png?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/chromeos/login/oobe.css?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/chrome_installer.gypi?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/tab_contents/spelling_bubble_model.cc?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/help/help.css?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/first_run/try_chrome_dialog_view.cc?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/theme/theme_resources_standard.grd?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/web_applications/web_app_mac_unittest.mm?r1=147770&r2=147769&pathrev=147770
   M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/browser_resources.grd?r1=147770&r2=147769&pathrev=147770

Merge 145475 - HiDPI assets for product_logo_16 / _32

Use the new logo on about:chrome

BUG= 134372 , 135179 
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10692069

TBR=thakis@chromium.org
------------------------------------------------------------------------
Status: Fixed
All merged to 1180.
Project Member

Comment 54 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 55 by bugdroid1@chromium.org, Nov 14 2012

The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=26455

------------------------------------------------------------------------
r26455 | thakis@google.com | 2012-07-02T18:48:34.090485Z

------------------------------------------------------------------------
Project Member

Comment 56 by bugdroid1@chromium.org, Nov 14 2012

The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=26456

------------------------------------------------------------------------
r26456 | thakis@google.com | 2012-07-02T18:50:41.671589Z

------------------------------------------------------------------------
Project Member

Comment 57 by bugdroid1@chromium.org, Nov 14 2012

The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=26459

------------------------------------------------------------------------
r26459 | thakis@google.com | 2012-07-02T19:32:04.372180Z

------------------------------------------------------------------------
Project Member

Comment 58 by bugdroid1@chromium.org, Nov 14 2012

The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=26460

------------------------------------------------------------------------
r26460 | thakis@google.com | 2012-07-02T19:34:04.175415Z

------------------------------------------------------------------------
Project Member

Comment 59 by bugdroid1@chromium.org, Nov 14 2012

The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=26985

------------------------------------------------------------------------
r26985 | thakis@google.com | 2012-07-20T23:36:54.658319Z

------------------------------------------------------------------------
Project Member

Comment 60 by bugdroid1@chromium.org, Nov 14 2012

The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=26986

------------------------------------------------------------------------
r26986 | thakis@google.com | 2012-07-21T00:21:30.512422Z

------------------------------------------------------------------------
Project Member

Comment 61 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-HighDPI -Mstone-21 Cr-UI-HighDPI Cr-UI M-21
Project Member

Comment 62 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment