New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 13428 link

Starred by 23 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression
M-3

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Omnibox regression, typed URL is truncated.

Reported by ma...@2am.ch, Jun 5 2009

Issue description

Google Chrome	3.0.183.1 (Official Build 17570)
WebKit	531.0
V8	1.2.6.1
User Agent	Mozilla/5.0 (X11; U; Linux i686; en-US) AppleWebKit/531.0 
(KHTML, like Gecko) Chrome/3.0.183.1 Safari/531.0




What steps will reproduce the problem?

Just enter a URL and Press enter
if you press enter a few milliseconds after finish typing,
a part of the URL isn't written into the "url variable"

like www.google.de<cr>
it results www.google

this is just when you press enter fast after typing the URL
if you waiting a half second it works just fine.

What is the expected result?

URL is not fully written into the $URL variable (i think)


What happens instead?

it sucks, but is better than ff :D

---


marco@blackbox:~$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=9.04
DISTRIB_CODENAME=jaunty
DISTRIB_DESCRIPTION="Ubuntu 9.04"


model name	: Intel(R) Core(TM)2 Duo CPU     E6550  @ 2.33GHz

Linux blackbox 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 
2009 i686 GNU/Linux




 
Status: Assigned
are you running klipper or glipper or a similar clipboard tool? This sounds kind of 
like a bad interaction we've experienced with these programs.

Comment 2 by agl@chromium.org, Jun 5 2009

This happens to me and dean as well. Dean suggested that it's a recent regression.

Comment 3 by evan@chromium.org, Jun 5 2009

Dean suggests it might be related to the message loop change.

Comment 4 by ma...@2am.ch, Jun 7 2009

is a mostly Default Ubuntu 9.04 installation.


Comment 5 by deanm@chromium.org, Jun 8 2009

I spent a while working on this today.  I am 95% sure that it's a regression caused 
by this recent change:

commit 928b9a5c70789749b4823dd52ba3283090a373b4
Author: pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-
d872f2087c98>
Date:   Wed Jun 3 23:07:35 2009 +0000

    Fix crash due to AutocompletePopup trying to draw the old results when they were 
no longer available.I introduced this regression when moving |result_| to the 
AutocompleteController; the specific problem was the 
"result_.CopyFrom(latest_result_);" line I added when handling the synchronous 
messages being available
    Review URL: http://codereview.chromium.org/119116
    
    git-svn-id: svn://chrome-svn/chrome/trunk/src@17562 0039d316-1c4b-4281-b951-
d872f2087c98

Assigning over to Peter.  When I revert this change locally, I cannot reproduce the 
truncation.  When I patch it back in, I can reproduce it very regularly.

Comment 6 by deanm@chromium.org, Jun 8 2009

Labels: Pri-0

Comment 7 by deanm@chromium.org, Jun 8 2009

Labels: -OS-Linux OS-All
Summary: Omnibox regression, typed URL is truncated.
I just confirmed this on Windows, build 17851.  I typed "std::vector" with the o-r-
enter keystrokes very quickly at the end, and I landed on a search for std::vect.  This 
is the same thing that is happening on Linux.
 Issue 13576  has been merged into this issue.

Comment 9 by jon@chromium.org, Jun 8 2009

Labels: Mstone-3
Labels: -Area-Misc -Pri-0 Area-BrowserUI Pri-1 Regression

Comment 11 by kenorb@gmail.com, Jun 8 2009

I've got the same problem,
when I'm typing fast (not pasting) asdf, it's searching for asd (I'm sure that I've 
pressed the last letter).
Other case, I'm typing 123 fast and after pressed Enter, nothing happen. It stops on 
proposing me 123[.com] ignoring my Enter.

Status: Fixed
Fixed in r17891.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=17908 

------------------------------------------------------------------------
r17908 | mal@chromium.org | 2009-06-08 16:29:01 -0700 (Mon, 08 Jun 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/184/src/chrome/browser/autocomplete/autocomplete.cc?r1=17908&r2=17907
   M http://src.chromium.org/viewvc/chrome/branches/184/src/chrome/browser/autocomplete/autocomplete.h?r1=17908&r2=17907
   M http://src.chromium.org/viewvc/chrome/branches/184/src/chrome/browser/autocomplete/autocomplete_popup_model.cc?r1=17908&r2=17907
   M http://src.chromium.org/viewvc/chrome/branches/184/src/chrome/browser/autocomplete/autocomplete_popup_model.h?r1=17908&r2=17907

Merge r17891.

Fix regression where hitting enter in the Omnibox would ignore recent editing.

Sadly, the only way I could find to fix this was a latest_result() accessor, because when the user hits enter, we really do need to use the very latest results.  This just highlights how more of this stuff should move to the AutocompleteController.

BUG= 13428 
TEST=Type "food.c" and wait for the popup to stabilize.  Then _very_ quickly type "om" and hit enter.  You should navigate to food.com instead of searching for "food.c".
TBR=pkasting
Review URL: http://codereview.chromium.org/119334
------------------------------------------------------------------------

 Issue 13635  has been merged into this issue.
 Issue 13491  has been merged into this issue.
 Issue 13555  has been merged into this issue.

Comment 19 Deleted

 Issue 13651  has been merged into this issue.
 Issue 13755  has been merged into this issue.
 Issue 13823  has been merged into this issue.
 Issue 13700  has been merged into this issue.
 Issue 13717  has been merged into this issue.
 Issue 14456  has been merged into this issue.
Status: Verified
Works fine on ToT.
 Issue 13567  has been merged into this issue.

Comment 28 by dhw@chromium.org, Jun 22 2009

 Issue 13772  has been merged into this issue.

Comment 29 by dhw@chromium.org, Jun 22 2009

 Issue 13628  has been merged into this issue.

Comment 30 by dhw@chromium.org, Jun 22 2009

 Issue 13627  has been merged into this issue.
Labels: -Regression bulkmove Type-Regression
Google Chrome	3.0.183.1 (Official Build 17570)
WebKit	531.0
V8	1.2.6.1
User Agent	Mozilla/5.0 (X11; U; Linux i686; en-US) AppleWebKit/531.0 
(KHTML, like Gecko) Chrome/3.0.183.1 Safari/531.0




What steps will reproduce the problem?

Just enter a URL and Press enter
if you press enter a few milliseconds after finish typing,
a part of the URL isn't written into the &quot;url variable&quot;

like www.google.de&lt;cr&gt;
it results www.google

this is just when you press enter fast after typing the URL
if you waiting a half second it works just fine.

What is the expected result?

URL is not fully written into the $URL variable (i think)


What happens instead?

it sucks, but is better than ff :D

---


marco@blackbox:~$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=9.04
DISTRIB_CODENAME=jaunty
DISTRIB_DESCRIPTION=&quot;Ubuntu 9.04&quot;


model name	: Intel(R) Core(TM)2 Duo CPU     E6550  @ 2.33GHz

Linux blackbox 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 
2009 i686 GNU/Linux
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 33 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-3 -Type-Regression Type-Bug-Regression M-3
Project Member

Comment 34 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment