Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 133828 Enable HW video decode by default on mac
Starred by 116 users Project Member Reported by fischman@chromium.org, Jun 20, 2012 Back to list

Comments by non-members will not trigger notification emails to users who starred this issue.
Tracking bug for --enable-accelerated-video-decode by default on mac.

 
Comment 1 Deleted
Comment 2 Deleted
Comment 3 Deleted
Comment 4 Deleted
Comment 5 Deleted
Comment 6 by alberto@chromium.org, Jun 20, 2012
Cc: jluther@chromium.org alberto@chromium.org
Comment 7 by jeffreyc@google.com, Jun 21, 2012
Cc: wiltzius@chromium.org
Labels: Launch-DesignDocReview-No Launch-AccessibilityReview-No Launch-QAReview-No Launch-UIReview-No Launch-StringsReviewed-No Launch-SecurityReview-No Launch-PrivacyReview-No Launch-LegalReview-No Launch-MarketingReview-No Launch-ConopsReview-No Launch-SREReview-No
PMs are responsible for shepherding Type-Launch bugs through the labels (as appropriate). They are familiar with the details of the process.
Comment 8 by jeffreyc@google.com, Jun 21, 2012
OK, I am told that jluther@ is the PM owner for this.

The best practice is to  set the label to "NA" if the label doesn't apply. E.g., "Launch-SecurityReview-NA".

thanks,
Jeff
Comment 9 by jluther@chromium.org, Jun 22, 2012
Labels: -Launch-DesignDocReview-No -Launch-AccessibilityReview-No -Launch-QAReview-No -Launch-UIReview-No -Launch-StringsReviewed-No -Launch-SecurityReview-No -Launch-PrivacyReview-No -Launch-LegalReview-No -Launch-MarketingReview-No -Launch-ConopsReview-No -Launch-SREReview-No Launch-DesignDocReview-NA Launch-AccessibilityReview-NA Launch-QAReview-NA Launch-UIReview-NA Launch-StringsReviewed-NA Launch-SecurityReview-NA Launch-PrivacyReview-NA Launch-LegalReview-NA Launch-MarketingReview-NA Launch-ConopsReview-NA Launch-SREReview-NA
Owner: jluther@chromium.org
Comment 10 by jluther@chromium.org, Jun 22, 2012
Cc: -jluther@chromium.org
Status: Assigned
Comment 11 by jluther@chromium.org, Jun 22, 2012
Owner: fischman@chromium.org
Comment 12 by jluther@chromium.org, Jun 22, 2012
Cc: jluther@chromium.org
Comment 13 by jluther@chromium.org, Jul 20, 2012
Cc: -jluther@chromium.org fischman@chromium.org
Owner: jluther@chromium.org
fischman@ is implementing the feature, as PM I assigned myself ownership.
Comment 14 by jeffreyc@google.com, Jul 25, 2012
heya, is this enabled-by-default on the Dev channel?
Not yet; currently blocked on http://codereview.chromium.org/10407070/
Project Member Comment 16 by bugdroid1@chromium.org, Jul 26, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=148452

------------------------------------------------------------------------
r148452 | fischman@chromium.org | 2012-07-26T00:49:40.558649Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.cc?r1=148452&r2=148451&pathrev=148452
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.h?r1=148452&r2=148451&pathrev=148452
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=148452&r2=148451&pathrev=148452
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=148452&r2=148451&pathrev=148452
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=148452&r2=148451&pathrev=148452
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=148452&r2=148451&pathrev=148452
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/login_utils.cc?r1=148452&r2=148451&pathrev=148452

Flip HW video decode from being behind an "enable" flag to being behind a "disable" flag
with per-platform default settings (currently off for all but cros).

This is in preparation for turning on HW decode by default one platform at a time.

BUG=133827, 133828 


Review URL: https://chromiumcodereview.appspot.com/10805070
------------------------------------------------------------------------
Comment 17 by pavanv@chromium.org, Jul 26, 2012
Cc: vivianz@chromium.org
Comment 18 by jeffreyc@google.com, Jul 26, 2012
Labels: -Mstone-22 Mstone-23
K, sounds like M23 is the right target then. (M22 branches in less than 2 weeks)
Cc: sail@chromium.org
It appears most h264 streams are unsupported by the OS/X API even on Mountain Lion.  sail@ is going to ask Apple about planned format support, but for now this launch seems unlikely (no point pushing complexity to users if it'll almost never be used).
Just making sure that this is disabled on the M22 branch, since you are targeting M23.
Yep, this was never enabled by default on trunk or any branch.
Comment 22 by jluther@chromium.org, Aug 22, 2012
Labels: -Mstone-23 Mstone-24
Labels: Restrict-View-Google
Bulk update:

Sumit and I have continued investigating how type=launch bugs might be visible to non-Googlers. As a part of this investigation, we found a series of bugs (like this one and 35 others) that did not have the Restrict-View-Google label on them. 

It appears these bugs started off as non-type=launch bugs, were converted, but the Restrict-View-Google label didn't stick or was not added. It's unclear to us how this happened.

I'm adding the Restrict-View-Google label now (without checking 'Send email') as a precaution.
Comment 24 by jluther@chromium.org, Oct 11, 2012
Labels: -Mstone-24 Mstone-25
Labels: -Mstone-25 Mstone-26
Aside from the bugs listed as blockers, there are the following two major issues:

1) Hardware decoder won't fail until data starts streaming in
One fix would be to change the decoder initialize function to take a SPS and PPS header (see http://codereview.chromium.org/10408003 for ideas)

2) Most videos on the web seem to fail HW decode using the MacVDA despite apparently working in QT/apple's players
This can be observed by running the same clip in QT versus the VDA sample application or something like VLC and comparing CPU usage.
Project Member Comment 27 by bugdroid1@chromium.org, Nov 17, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=168441

------------------------------------------------------------------------
r168441 | fischman@chromium.org | 2012-11-17T15:48:57.232578Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/functional/PYAUTO_TESTS?r1=168441&r2=168440&pathrev=168441
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/mac_video_decode_accelerator.mm?r1=168441&r2=168440&pathrev=168441

Forcibly disable MacVDA, even for users who ignore the GPU blacklist.

BUG= 125424 , 133828 , 157394 , 160090 

Review URL: https://chromiumcodereview.appspot.com/11415036
------------------------------------------------------------------------
Comment 28 by meh@chromium.org, Dec 7, 2012
Cc: owp-launch-tracking@chromium.org
Cc: cduvivier@chromium.org
Comment 30 by jluther@chromium.org, Jan 16, 2013
Welcome, Christian! Is this realistic for M26 or should we move to 27?
Don't know yet, will let you know as soon as I do.

What are the deadlines for M26 and M27?

--cd
Comment 32 by jluther@chromium.org, Jan 16, 2013
For M26, branch is 11 February but features must be enabled-by-default on trunk by January 25. For M27 will probably be ~March 8.
Labels: -Feature-Media-Video Feature-Media hardware
Labels: -hardware Feature-Media-Hardware
Comment 35 by jluther@chromium.org, Jan 24, 2013
Labels: -Mstone-26 Mstone-27
Labels: -Mstone-27 Mstone-28
Punting for now. cduvivier@ investigated and determined the current public API isn't well suited to supporting the variety of web H264 content.

Waiting to hear back from contacts whether there's a more appropriate API to use.
Project Member Comment 37 by bugdroid1@chromium.org, Mar 9, 2013
Labels: -Launch-DesignDocReview-NA -Launch-AccessibilityReview-NA -Launch-QAReview-NA -Launch-UIReview-NA -Launch-StringsReviewed-NA -Launch-SecurityReview-NA -Launch-PrivacyReview-NA -Launch-LegalReview-NA -Launch-MarketingReview-NA -Launch-ConopsReview-NA -Launch-SREReview-NA Launch-QA-NA Launch-Accessibility-NA Launch-Security-NA Launch-SRE-NA Launch-Conops-NA Launch-UI-NA Launch-DesignDoc-NA Launch-Privacy-NA Launch-Marketing-NA Launch-Legal-NA Launch-Strings-NA
Project Member Comment 38 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Feature-Media -Area-WebKit -Mstone-28 -Feature-Media-Hardware Cr-Content Cr-Internals-Media Cr-Internals-Media-Hardware M-28
Project Member Comment 39 by bugdroid1@chromium.org, Apr 6, 2013
Labels: -Cr-Content Cr-Blink
Comment 40 by jeffreyc@google.com, Apr 17, 2013
Hi all,

There are only a few days left to enable your features by default if you're targeting M28.

At the M28 go/no-go meeting during the week of April 29 (with Linus and the QA + TPM teams), we will be enforcing the criteria that features must be enabled-by-default in the April 22 Dev channel push (at the latest).

Please adjust the milestone label as appropriate. I'll be pinging the Chrome PMs next week to ask for the info needed at the go/no-go meeting.

thanks,
Jeff
Comment 41 by jeffreyc@google.com, Apr 23, 2013
I see that you're targeting M28 for this feature, which branches in less than 2 weeks.

Has this been enabled-by-default on trunk yet?
Comment 42 by vivianz@chromium.org, Apr 23, 2013
Cc: dbbrooks@chromium.org yihongg@chromium.org
Comment 43 by jluther@chromium.org, Apr 23, 2013
Labels: -M-28 M-29
jluther: should we remove the M-## label until someone is actually working on this?
Comment 45 by jluther@chromium.org, Apr 24, 2013
Labels: -M-29
Nobody is working on this or scheduled to work on this.  I propose to delete the MacVDA code since it confuses developers (I field a question about this every 2 weeks or so) and close this bug until we decide to re-prioritize this work.
SGTM

it's always possible to resurrect the code from the revision history
Project Member Comment 48 by bugdroid1@chromium.org, Apr 26, 2013
------------------------------------------------------------------------
r196621 | fischman@chromium.org | 2013-04-26T05:14:19.821906Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/avc_config_record_builder.h?r1=196621&r2=196620&pathrev=196621
   D http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/video_decode_acceleration_support_mac_unittest.mm?r1=196621&r2=196620&pathrev=196621
   D http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/video_decode_acceleration_support_mac.mm?r1=196621&r2=196620&pathrev=196621
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=196621&r2=196620&pathrev=196621
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/video_decode_accelerator_unittest.cc?r1=196621&r2=196620&pathrev=196621
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=196621&r2=196620&pathrev=196621
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/rendering_helper_mac.mm?r1=196621&r2=196620&pathrev=196621
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/mac_video_decode_accelerator.mm?r1=196621&r2=196620&pathrev=196621
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/ui_unittests.gypi?r1=196621&r2=196620&pathrev=196621
   D http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/video_decode_acceleration_support_mac.h?r1=196621&r2=196620&pathrev=196621
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/gpu_video_decode_accelerator.cc?r1=196621&r2=196620&pathrev=196621
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/ui.gyp?r1=196621&r2=196620&pathrev=196621
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/mac_video_decode_accelerator.h?r1=196621&r2=196620&pathrev=196621
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/avc_config_record_builder_unittest.cc?r1=196621&r2=196620&pathrev=196621
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/avc_config_record_builder.cc?r1=196621&r2=196620&pathrev=196621
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=196621&r2=196620&pathrev=196621

Delete MacVDA from the codebase since it is dead code and not being worked on.

http://crbug.com/133828#c36 summarizes why this wasn't turned on.
Also related: http://openradar.appspot.com/radar?id=1845403 

BUG= 133828 

Review URL: https://chromiumcodereview.appspot.com/14401013
------------------------------------------------------------------------
Status: WontFix
WontFix'ing pending finding the right person to work on this (currently unprioritized).
Comment 50 by evan@chromium.org, May 10, 2013
This bug is linked from chrome://gpu but is marked restrict-view-google -- intentional?
Comment 51 Deleted
Comment 52 Deleted
Removing R-V-G since it's referred to by about:gpu, there's nothing confidential here, and the Launchiness of the bug has been aborted for many months.
Labels: -Restrict-View-Google
Labels: -Type-Launch Type-Feature
Switching bug Type to see if that opens up the bug (even though I removed R-V-G the bug is still Restricted)
Cc: dongseon...@intel.com
Comment 57 by ericde@chromium.org, Jun 10, 2014
Owner: sande...@chromium.org
Status: Assigned
reactivating and assigning to sandersd@, who will be working on this.
Comment 58 by smori...@adobe.com, Jun 10, 2014
Cc: adobe-flash@chromium.org
Cc: -fischman@chromium.org
Project Member Comment 60 by bugdroid1@chromium.org, Jun 11, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c78d8192e1159aab87b03bed005e776f4dcee173

commit c78d8192e1159aab87b03bed005e776f4dcee173
Author: sandersd@chromium.org <sandersd@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 11 07:21:56 2014

Create VTVideoDecodeAccelerator.

This is a stub for what will eventually become a video decode accelerator for Mac.

BUG= 133828 

Review URL: https://codereview.chromium.org/322433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276290 0039d316-1c4b-4281-b951-d872f2087c98


Status: Started
Status update: My VideoToolbox-based implementation is now operational enough to decode (but not render) frames. The next step is to check in the VideoToolbox dynamic linking glue code, after which the rest of the work can be submitted in small pieces.

The good news is that so far it appears that VideoToolbox does not have the same video size restrictions that VDA had, so it is more likely that this can be enabled for all video (including MediaSource).

The bad news is that I've taken some implementation shortcuts that will restrict the implementation to OS X 10.9+. These are fixable, but I don't have test machines handy for older versions of OS X.
Project Member Comment 63 by bugdroid1@chromium.org, Jun 25, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2dac535dea5647736dec19201d34ea339fcd109

commit c2dac535dea5647736dec19201d34ea339fcd109
Author: sandersd@chromium.org <sandersd@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 25 04:56:04 2014

Add VTSupport for dynamically linking VideoToolbox.

BUG= 133828 

Review URL: https://codereview.chromium.org/340933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279593 0039d316-1c4b-4281-b951-d872f2087c98


Project Member Comment 65 by bugdroid1@chromium.org, Jul 11, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa18b3c8505b45caea43f1997af81154003d2446

commit fa18b3c8505b45caea43f1997af81154003d2446
Author: sandersd@chromium.org <sandersd@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jul 11 04:56:06 2014

Use PPS/SPS NALUs to initialize a VTDecompressionSession.

BUG= 133828 

Review URL: https://codereview.chromium.org/374153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282549 0039d316-1c4b-4281-b951-d872f2087c98


Project Member Comment 66 by bugdroid1@chromium.org, Jul 11, 2014
------------------------------------------------------------------
r282549 | sandersd@chromium.org | 2014-07-11T04:56:06.564426Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=282549&r2=282548&pathrev=282549
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/vt_video_decode_accelerator.cc?r1=282549&r2=282548&pathrev=282549
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/vt_video_decode_accelerator.h?r1=282549&r2=282548&pathrev=282549

Use PPS/SPS NALUs to initialize a VTDecompressionSession.

BUG= 133828 

Review URL: https://codereview.chromium.org/374153003
-----------------------------------------------------------------
Project Member Comment 67 by bugdroid1@chromium.org, Aug 5, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e68e3228ca7cd2988142ff4c90428bb0b35ab2f3

commit e68e3228ca7cd2988142ff4c90428bb0b35ab2f3
Author: sandersd@chromium.org <sandersd@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Aug 05 04:17:44 2014

Implement actually decoding frames in VTVideoDecodeAccelerator.

This adds translation from Annex B to AVCC format along with decoding
frames and binding them to textures.

It seems that kVTDecodeFrame_EnableTemporalProcessing is just a
suggestion to VideoToolbox, and one that it ignores. That means that,
for now, this code only outputs frames in the correct order for I-frame
only video.

BUG= 133828 

Review URL: https://codereview.chromium.org/397883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287451 0039d316-1c4b-4281-b951-d872f2087c98


Project Member Comment 68 by bugdroid1@chromium.org, Aug 5, 2014
------------------------------------------------------------------
r287451 | sandersd@chromium.org | 2014-08-05T04:17:44.652934Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/vt_video_decode_accelerator.cc?r1=287451&r2=287450&pathrev=287451
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/gpu_video_decode_accelerator.cc?r1=287451&r2=287450&pathrev=287451
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/vt_video_decode_accelerator.h?r1=287451&r2=287450&pathrev=287451
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/media/vt_stubs_header.fragment?r1=287451&r2=287450&pathrev=287451

Implement actually decoding frames in VTVideoDecodeAccelerator.

This adds translation from Annex B to AVCC format along with decoding
frames and binding them to textures.

It seems that kVTDecodeFrame_EnableTemporalProcessing is just a
suggestion to VideoToolbox, and one that it ignores. That means that,
for now, this code only outputs frames in the correct order for I-frame
only video.

BUG= 133828 

Review URL: https://codereview.chromium.org/397883002
-----------------------------------------------------------------
Comment 69 by ihf@chromium.org, Aug 19, 2014
Blocking: chromium:335836
Cc: pinkerton@chromium.org
Cc: ccameron@chromium.org
Blockedon: chromium:419616
Labels: M-41 ReleaseBlock-Stable
Dan and I talked, the plan is to enable this on canary right after M40 branch, so this is targeted for M41.
Blocking: chromium:379906
Has this been enabled on trunk?
No, it's still in development.
Project Member Comment 79 by bugdroid1@chromium.org, Nov 20, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f5942b3e57bb17b1585bc80792c262044bc23b9

commit 9f5942b3e57bb17b1585bc80792c262044bc23b9
Author: sandersd <sandersd@chromium.org>
Date: Thu Nov 20 22:56:46 2014

Collect frames into a work queue to simplify the state machine. This
corrects a bug with flushing and will make it easier to implement the
reorder queue.

BUG= 133828 

Review URL: https://codereview.chromium.org/706023004

Cr-Commit-Position: refs/heads/master@{#305098}

[modify] http://crrev.com/9f5942b3e57bb17b1585bc80792c262044bc23b9/content/common/gpu/media/vt_video_decode_accelerator.cc
[modify] http://crrev.com/9f5942b3e57bb17b1585bc80792c262044bc23b9/content/common/gpu/media/vt_video_decode_accelerator.h
[modify] http://crrev.com/9f5942b3e57bb17b1585bc80792c262044bc23b9/media/filters/gpu_video_decoder.cc

Comment 80 by sandersd@google.com, Nov 20, 2014
A status update for those following: there are three remaining CLs currently being reviewed (reorder queue, pic_order_cnt, and sandbox implementation); once they are committed this VDA can be enabled using the --ignore-gpu-blacklist flag. (And also disabled using the --disable-accelerated-video-decode flag.)

I'll be toggling general availability right away as well, but it may need to be toggled in bursts with bug fixing in-between. In particular the handling of streams with corrupt/incorrect metadata is not well tested.
What do we need to do to get QA ready to test and approve this prior to go/no-go?
Project Member Comment 82 by bugdroid1@chromium.org, Nov 26, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e01b2b9885d764591a3fd2b67f76ccd3c5e2248b

commit e01b2b9885d764591a3fd2b67f76ccd3c5e2248b
Author: sandersd <sandersd@chromium.org>
Date: Wed Nov 26 22:38:21 2014

Implement a reorder queue in VTVideoDecodeAccelerator.

This CL does not implement that actual computation of the order, becuase
the original plan of just copying the implementation from the VAAPI was
buggy. A second CL will follow with the computation once the bugs are
fully understood.

BUG= 133828 

Review URL: https://codereview.chromium.org/727893002

Cr-Commit-Position: refs/heads/master@{#305905}

[modify] http://crrev.com/e01b2b9885d764591a3fd2b67f76ccd3c5e2248b/content/common/gpu/media/vt_video_decode_accelerator.cc
[modify] http://crrev.com/e01b2b9885d764591a3fd2b67f76ccd3c5e2248b/content/common/gpu/media/vt_video_decode_accelerator.h

Project Member Comment 84 by bugdroid1@chromium.org, Nov 27, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/592cdf068b0e4dfabe9a6e44af55b3ee1e24fbc7

commit 592cdf068b0e4dfabe9a6e44af55b3ee1e24fbc7
Author: sandersd <sandersd@chromium.org>
Date: Thu Nov 27 01:57:01 2014

Sandbox initialization for VideoToolbox.

Creates a VideoToolbox decompression session during sandbox startup so that VideoToolbox can load all of its libraries before the sandbox goes into effect.

Note: Once this CL is committed, VTVideoDecodeAccelerator can be enabled using only --ignore-gpu-blacklist.

BUG= 133828 

Review URL: https://codereview.chromium.org/723993003

Cr-Commit-Position: refs/heads/master@{#305938}

[modify] http://crrev.com/592cdf068b0e4dfabe9a6e44af55b3ee1e24fbc7/content/common/gpu/media/vt_video_decode_accelerator.cc
[modify] http://crrev.com/592cdf068b0e4dfabe9a6e44af55b3ee1e24fbc7/content/common/gpu/media/vt_video_decode_accelerator.h
[modify] http://crrev.com/592cdf068b0e4dfabe9a6e44af55b3ee1e24fbc7/content/common/sandbox_mac.mm

Project Member Comment 85 by bugdroid1@chromium.org, Nov 27, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bc4f40ebaf426df2b58f4ab94549c9cc29364a6

commit 4bc4f40ebaf426df2b58f4ab94549c9cc29364a6
Author: sandersd <sandersd@chromium.org>
Date: Thu Nov 27 02:08:41 2014

Remove reliance on VideoToolbox frame ordering.

It seems that VideoToolbox occasionally reorders frames (in my testing, the fourth one keeps appearing third, and then there are a few more random swaps that stop by around frame 16). This CL makes that a non-fatal error.

BUG= 133828 

Review URL: https://codereview.chromium.org/753713002

Cr-Commit-Position: refs/heads/master@{#305944}

[modify] http://crrev.com/4bc4f40ebaf426df2b58f4ab94549c9cc29364a6/content/common/gpu/media/vt_video_decode_accelerator.cc
[modify] http://crrev.com/4bc4f40ebaf426df2b58f4ab94549c9cc29364a6/content/common/gpu/media/vt_video_decode_accelerator.h

Project Member Comment 86 by bugdroid1@chromium.org, Dec 2, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6d54b69098f7b4da1606cdcc6f39156fbdbf9ac

commit a6d54b69098f7b4da1606cdcc6f39156fbdbf9ac
Author: sandersd <sandersd@chromium.org>
Date: Tue Dec 02 19:37:35 2014

Flush correctly in VTVideoDecodeAccelerator.

Previously flushing was requested but not actually waited for, resulting
in flushing completing before frames were actually decoded.

BUG= 133828 

Review URL: https://codereview.chromium.org/763063004

Cr-Commit-Position: refs/heads/master@{#306435}

[modify] http://crrev.com/a6d54b69098f7b4da1606cdcc6f39156fbdbf9ac/content/common/gpu/media/vt.sig
[modify] http://crrev.com/a6d54b69098f7b4da1606cdcc6f39156fbdbf9ac/content/common/gpu/media/vt_video_decode_accelerator.cc

Project Member Comment 87 by bugdroid1@chromium.org, Dec 3, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3125ca55d73650bd37ce9d9daa3dfe5182a7cf3a

commit 3125ca55d73650bd37ce9d9daa3dfe5182a7cf3a
Author: sandersd <sandersd@chromium.org>
Date: Wed Dec 03 22:33:15 2014

Add UMA to track software fallback in VTVideoDecodeAccelerator.

VideoToolbox can fall back to software internally for two reasons:
  1) The resolution is below the minimum (or other format incompatibility). Eventually we want Chromium to handle
fallback in this case.
  2) The sandbox was not initialized properly. This we want to know about and fix.

This CL does not distinguish the two cases.

BUG= 133828 

Review URL: https://codereview.chromium.org/773673002

Cr-Commit-Position: refs/heads/master@{#306692}

[modify] http://crrev.com/3125ca55d73650bd37ce9d9daa3dfe5182a7cf3a/content/common/gpu/media/vt.sig
[modify] http://crrev.com/3125ca55d73650bd37ce9d9daa3dfe5182a7cf3a/content/common/gpu/media/vt_stubs_header.fragment
[modify] http://crrev.com/3125ca55d73650bd37ce9d9daa3dfe5182a7cf3a/content/common/gpu/media/vt_video_decode_accelerator.cc
[modify] http://crrev.com/3125ca55d73650bd37ce9d9daa3dfe5182a7cf3a/tools/metrics/histograms/histograms.xml

Project Member Comment 88 by bugdroid1@chromium.org, Dec 3, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e07691a81dfd1b018033102e4106803f8b5722c5

commit e07691a81dfd1b018033102e4106803f8b5722c5
Author: sandersd <sandersd@chromium.org>
Date: Wed Dec 03 23:51:05 2014

Actually return black for ReadPixelsSync() on Mac.

BUG= 133828 

Review URL: https://codereview.chromium.org/774353002

Cr-Commit-Position: refs/heads/master@{#306716}

[modify] http://crrev.com/e07691a81dfd1b018033102e4106803f8b5722c5/media/filters/gpu_video_decoder.cc

Project Member Comment 89 by bugdroid1@chromium.org, Dec 4, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba494b53d679b6d10f23eec4b945475267a72212

commit ba494b53d679b6d10f23eec4b945475267a72212
Author: sandersd <sandersd@chromium.org>
Date: Thu Dec 04 02:43:53 2014

Add support for redundant streams to VTVideoDecodeAccelerator.

In practice this means only using the first image slice to compute
|pic_order_cnt|.

BUG= 133828 

Review URL: https://codereview.chromium.org/776143004

Cr-Commit-Position: refs/heads/master@{#306750}

[modify] http://crrev.com/ba494b53d679b6d10f23eec4b945475267a72212/content/common/gpu/media/vt_video_decode_accelerator.cc

Project Member Comment 90 by bugdroid1@chromium.org, Dec 5, 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/700b4610ee8d5a73d2fe8465917589fab8818fbd

commit 700b4610ee8d5a73d2fe8465917589fab8818fbd
Author: sandersd <sandersd@chromium.org>
Date: Fri Dec 05 23:33:44 2014

Load VideoToolbox even when --no-sandbox is in use.

BUG= 133828 

Review URL: https://codereview.chromium.org/780713004

Cr-Commit-Position: refs/heads/master@{#307112}

[modify] http://crrev.com/700b4610ee8d5a73d2fe8465917589fab8818fbd/content/common/gpu/media/vt_video_decode_accelerator.cc
[modify] http://crrev.com/700b4610ee8d5a73d2fe8465917589fab8818fbd/content/common/gpu/media/vt_video_decode_accelerator.h

Blockedon: chromium:425708 chromium:441009
Cc: tonyg@chromium.org abarth@chromium.org jam@chromium.org darin@chromium.org hclam@chromium.org jeremy@chromium.org dalecur...@chromium.org fgalligan@chromium.org
Issue 362940 has been merged into this issue.
Blocking: chromium:379917
Blockedon: chromium:446631
Labels: -M-41 M-42
Moving to M-42.
Project Member Comment 96 by bugdroid1@chromium.org, Jan 15, 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0e69446b02848fce2e311662a43b8e782304ae3

commit c0e69446b02848fce2e311662a43b8e782304ae3
Author: sandersd <sandersd@chromium.org>
Date: Thu Jan 15 03:17:15 2015

Remove accelerated hardware decode blacklist entry for Mac OS X.

Now that VTVideoDecodeAccelerator exists, this entry is not necessary.

BUG= 133828 

Review URL: https://codereview.chromium.org/849143002

Cr-Commit-Position: refs/heads/master@{#311622}

[modify] http://crrev.com/c0e69446b02848fce2e311662a43b8e782304ae3/chrome/browser/about_flags.cc
[modify] http://crrev.com/c0e69446b02848fce2e311662a43b8e782304ae3/gpu/config/software_rendering_list_json.cc

Project Member Comment 97 by bugdroid1@chromium.org, Jan 15, 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17202a5a52388cf6e0807a243364f6c995eb82a1

commit 17202a5a52388cf6e0807a243364f6c995eb82a1
Author: ricow <ricow@google.com>
Date: Thu Jan 15 13:56:29 2015

Revert of Remove accelerated hardware decode blacklist entry for Mac OS X. (patchset #2 id:20001 of https://codereview.chromium.org/849143002/)

Reason for revert:
This seems related to the regression here:
https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20%28Intel%29/builds/45738

Original issue's description:
> Remove accelerated hardware decode blacklist entry for Mac OS X.
>
> Now that VTVideoDecodeAccelerator exists, this entry is not necessary.
>
> BUG= 133828 
>
> Committed: https://crrev.com/c0e69446b02848fce2e311662a43b8e782304ae3
> Cr-Commit-Position: refs/heads/master@{#311622}

TBR=scherkus@chromium.org,sievers@chromium.org,sandersd@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 133828 

Review URL: https://codereview.chromium.org/853563003

Cr-Commit-Position: refs/heads/master@{#311659}

[modify] http://crrev.com/17202a5a52388cf6e0807a243364f6c995eb82a1/chrome/browser/about_flags.cc
[modify] http://crrev.com/17202a5a52388cf6e0807a243364f6c995eb82a1/gpu/config/software_rendering_list_json.cc

Project Member Comment 98 by bugdroid1@chromium.org, Jan 15, 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81a119ffed1edbb462b51ed5b25a421bb9a03298

commit 81a119ffed1edbb462b51ed5b25a421bb9a03298
Author: sandersd <sandersd@chromium.org>
Date: Thu Jan 15 20:24:54 2015

Allow rectangle textures to be copied with Y flipped.

BUG= 133828 

Review URL: https://codereview.chromium.org/802343009

Cr-Commit-Position: refs/heads/master@{#311726}

[modify] http://crrev.com/81a119ffed1edbb462b51ed5b25a421bb9a03298/media/filters/skcanvas_video_renderer.cc

Project Member Comment 99 by bugdroid1@chromium.org, Jan 15, 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4e60796cf7b76ce3c313e3b507751fda3b340e3

commit f4e60796cf7b76ce3c313e3b507751fda3b340e3
Author: sandersd <sandersd@chromium.org>
Date: Thu Jan 15 20:30:52 2015

Revert of Revert of Remove accelerated hardware decode blacklist entry for Mac OS X. (patchset #1 id:1 of https://codereview.chromium.org/853563003/)

Reason for revert:
Test failure corrected by:

https://crrev.com/81a119ffed1edbb462b51ed5b25a421bb9a03298
Cr-Commit-Position: refs/heads/master@{#311726}

Original issue's description:
> Revert of Remove accelerated hardware decode blacklist entry for Mac OS X. (patchset #2 id:20001 of https://codereview.chromium.org/849143002/)
>
> Reason for revert:
> This seems related to the regression here:
> https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20%28Intel%29/builds/45738
>
> Original issue's description:
> > Remove accelerated hardware decode blacklist entry for Mac OS X.
> >
> > Now that VTVideoDecodeAccelerator exists, this entry is not necessary.
> >
> > BUG= 133828 
> >
> > Committed: https://crrev.com/c0e69446b02848fce2e311662a43b8e782304ae3
> > Cr-Commit-Position: refs/heads/master@{#311622}
>
> TBR=scherkus@chromium.org,sievers@chromium.org,sandersd@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG= 133828 
>
> Committed: https://crrev.com/17202a5a52388cf6e0807a243364f6c995eb82a1
> Cr-Commit-Position: refs/heads/master@{#311659}

TBR=scherkus@chromium.org,sievers@chromium.org,ricow@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 133828 

Review URL: https://codereview.chromium.org/857433002

Cr-Commit-Position: refs/heads/master@{#311727}

[modify] http://crrev.com/f4e60796cf7b76ce3c313e3b507751fda3b340e3/chrome/browser/about_flags.cc
[modify] http://crrev.com/f4e60796cf7b76ce3c313e3b507751fda3b340e3/gpu/config/software_rendering_list_json.cc

Labels: -Launch-QA-NA -Launch-Security-NA -Launch-Conops-NA -Launch-DesignDoc-NA -Launch-Legal-NA Launch-QA-No Launch-Security-No Launch-Conops-No Launch-DesignDoc-No Launch-Legal-No
Blocking: chromium:338578
Status: Fixed
Labels: Merge-TBD
Is there a merge required here?
Labels: -Merge-TBD
No, this was enabled well before the branch cut.
Sign in to add a comment