New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 133692 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2012
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Crash after calling DisplayBalloon

Reported by xians@chromium.org, Jun 20 2012

Issue description

Chrome Version       : latest
OS Version: OS X 10.6.8
URLs : apprtc.appspot.com

What steps will reproduce the problem?
1. Sync with the latest Chromium 
2. Build chrome
3. goto apprtc.appspot.com, click allow when the infobar pops up

Then the browser crashes.

It seems the problem happens after CL is https://chromiumcodereview.appspot.com/10407023

Reverting it fixes the problem.


 

Comment 1 by xians@chromium.org, Jun 20 2012

Varunjain, could you please take a look at this? It crashes the whole browser, so we might need to merge the fix.
In case you would like to see how we use the status_icon class, take a look at chrome/browser/media/media_stream_capture_indicator.cc.

Thanks
Status: Started
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 20 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143300

------------------------------------------------------------------------
r143300 | varunjain@chromium.org | Wed Jun 20 16:45:20 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/screen_mac.mm?r1=143300&r2=143299&pathrev=143300

Fix for screen_mac::GetDisplayNearestPoint. The input point may not
always be inside the display bounds.

BUG= 133692 
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10580042
------------------------------------------------------------------------
Should be fixed. Is this a release blocker? Please mark the appropriate ReleaseBlock label so I can merge this into the release branch.

Comment 5 by xians@chromium.org, Jun 21 2012

Labels: ReleaseBlock-Dev
Status: Verified
Yes, it is a release blocker, please merge it.
Cc: zelidrag@chromium.org
Labels: Merge-Requested
Status: Started

Comment 7 by kareng@google.com, Jun 21 2012

Labels: -ReleaseBlock-Dev -Merge-Requested ReleaseBlock-Beta Merge-Approved
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 21 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143413

------------------------------------------------------------------------
r143413 | varunjain@chromium.org | Thu Jun 21 11:06:34 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/gfx/screen_mac.mm?r1=143413&r2=143412&pathrev=143413

Merge 143300 - Fix for screen_mac::GetDisplayNearestPoint. The input point may not
always be inside the display bounds.

BUG= 133692 
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10580042

TBR=varunjain@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10648002
------------------------------------------------------------------------
Status: Fixed
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-21 M-21
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Area-Undefined
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment