New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 133567 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Buffered area disappearance while playing video

Reported by imasaki@chromium.org, Jun 19 2012

Issue description

Chrome Version       : 21.0.1180.0 canary
URLs (if applicable) : http://tskir-html5.kir.corp.google.com/testmatrix/index.html?file=avatar2.webm
OS version               : Window
Network (such as Cable/DSL/Dial up etc):Corp
Audio/Video format (if applicable): webm
Special chrome flags (if applicable):


What steps will reproduce the problem?
1. http://tskir-html5.kir.corp.google.com/testmatrix/index.html?file=avatar2.webm
2. wait for a while (1 min) - no seek


What is the expected result?
3. Buffered area stay the same

What is the actual result?
3. you notice Buffered area disappear while playing video 


 
bar.png
4.7 KB View Download
Cc: imasaki@chromium.org alek...@chromium.org tnakamura@chromium.org
I did bisect build, and looks like this change offended CL: 

WEBKIT CHANGELOG URL:
  http://trac.webkit.org/log/trunk/?rev=118780&stop_rev=118560&verbose=on&limit=10000
CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=139316%3A139336 

might be related to this http://trac.webkit.org/changeset/118577/trunk 

Labels: -Type-Bug Type-Regression
This is another version of the same behavior described in 131444.
The difference here is that the early part of the video is simple enough (bytes/time ratio is low enough) that the simplistic bytes->time conversion in Pipeline::TimeForByteOffset_Locked ends up believing the end of the buffered region is earlier than currentTime, resulting in the "disappearance" of the buffering bar.

Comment 4 Deleted

Labels: ReleaseBlock-Stable Mstone-21
Owner: fischman@chromium.org
Status: Started
I'll probably throw in a hack for this (proper fix is described in 133588)

Comment 6 by kareng@google.com, Jun 22 2012

Labels: -Pri-2 Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 23 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143765

------------------------------------------------------------------------
r143765 | fischman@chromium.org | Fri Jun 22 18:04:53 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/tools/seek_tester/seek_tester.cc?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/mock_data_source_host.h?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/dummy_demuxer.h?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/data_source.h?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline.cc?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/ranges.h?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/ffmpeg_demuxer_unittest.cc?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/chunk_demuxer_unittest.cc?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/ffmpeg_demuxer.h?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/media.gyp?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/ffmpeg_demuxer.cc?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/chunk_demuxer.cc?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_unittest.cc?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline.h?r1=143765&r2=143764&pathrev=143765
 A http://src.chromium.org/viewvc/chrome/trunk/src/media/base/ranges.cc?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/demuxer_stream.h?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/mock_demuxer_host.h?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/dummy_demuxer.cc?r1=143765&r2=143764&pathrev=143765
 M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/mock_filters.h?r1=143765&r2=143764&pathrev=143765

Ensure media's buffered ranges always have a range that includes currentTime.
Avoids buffering bar disappearing/reappearing when the bytes are distributed
unevenly throughout the media.

BUG= 133567 , 131444 

Review URL: https://chromiumcodereview.appspot.com/10581050
------------------------------------------------------------------------
Labels: Merge-Requested
Requesting merge of r143765 to 21 once this proves to be ok in canary.
Merge plan (discussed w/ kareng@) is: let the above bake in canary during the no-release weeks of IO & 7/4 and if it's quiet on canary merge to 21 on or about 7/10 for the second beta release (the first one has already sailed).  In case of trouble we have a HACK option in https://chromiumcodereview.appspot.com/10680004/ but hopefully we can avoid using it.
Looked and failed to find any crashes containing FFmpegDemuxer::NotifyBufferingChanged() or Pipeline::AddBufferedTimeRange() (two key methods introduced in the CL above).

Comment 11 by kareng@google.com, Jul 10 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 10 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145937

------------------------------------------------------------------------
r145937 | fischman@chromium.org | Tue Jul 10 12:55:34 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/ranges.h?r1=145937&r2=145936&pathrev=145937
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/mock_filters.h?r1=145937&r2=145936&pathrev=145937
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/tools/seek_tester/seek_tester.cc?r1=145937&r2=145936&pathrev=145937
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/mock_data_source_host.h?r1=145937&r2=145936&pathrev=145937
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/ranges.cc?r1=145937&r2=145936&pathrev=145937 (from /trunk/src/media/base/ranges.cc revision 143765)
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/media.gyp?r1=145937&r2=145936&pathrev=145937
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/mock_demuxer_host.h?r1=145937&r2=145936&pathrev=145937
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/data_source.h?r1=145937&r2=145936&pathrev=145937
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/pipeline.cc?r1=145937&r2=145936&pathrev=145937
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/pipeline_unittest.cc?r1=145937&r2=145936&pathrev=145937
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/filters/ffmpeg_demuxer_unittest.cc?r1=145937&r2=145936&pathrev=145937
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/pipeline.h?r1=145937&r2=145936&pathrev=145937
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/demuxer_stream.h?r1=145937&r2=145936&pathrev=145937

Merge 143765 - Ensure media's buffered ranges always have a range that includes currentTime.
Avoids buffering bar disappearing/reappearing when the bytes are distributed
unevenly throughout the media.

BUG= 133567 , 131444 

Review URL: https://chromiumcodereview.appspot.com/10581050

TBR=fischman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698134
------------------------------------------------------------------------
Status: Fixed
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 10 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145951

------------------------------------------------------------------------
r145951 | fischman@chromium.org | Tue Jul 10 13:27:58 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/ranges.h?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/mock_filters.h?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/tools/seek_tester/seek_tester.cc?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/mock_data_source_host.h?r1=145951&r2=145950&pathrev=145951
 D http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/ranges.cc?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/media.gyp?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/mock_demuxer_host.h?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/data_source.h?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/pipeline.cc?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/pipeline_unittest.cc?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/filters/ffmpeg_demuxer_unittest.cc?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/pipeline.h?r1=145951&r2=145950&pathrev=145951
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/demuxer_stream.h?r1=145951&r2=145950&pathrev=145951

Revert 145937 - Merge 143765 - Ensure media's buffered ranges always have a range that includes currentTime.
Avoids buffering bar disappearing/reappearing when the bytes are distributed
unevenly throughout the media.

BUG= 133567 , 131444 

Review URL: https://chromiumcodereview.appspot.com/10581050

TBR=fischman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698134

TBR=fischman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10689141
------------------------------------------------------------------------
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 10 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145966

------------------------------------------------------------------------
r145966 | fischman@chromium.org | Tue Jul 10 15:12:23 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/mock_filters.h?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/tools/seek_tester/seek_tester.cc?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/mock_data_source_host.h?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/data_source.h?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/pipeline.cc?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/filters/ffmpeg_demuxer_unittest.cc?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/filters/ffmpeg_demuxer.h?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/filters/dummy_demuxer.h?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/ranges.h?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/filters/chunk_demuxer.cc?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/media.gyp?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/mock_demuxer_host.h?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/filters/dummy_demuxer.cc?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/filters/ffmpeg_demuxer.cc?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/pipeline_unittest.cc?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/pipeline.h?r1=145966&r2=145965&pathrev=145966
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/demuxer_stream.h?r1=145966&r2=145965&pathrev=145966

Merge 143765 - Ensure media's buffered ranges always have a range that includes currentTime.
Avoids buffering bar disappearing/reappearing when the bytes are distributed
unevenly throughout the media.

THIS IS A MANUAL (not drover'd) MERGE.
Due to preceding *unmerged* changes (esp r143106) to
chunk_demuxer{,_unittest}.cc, the original CL doesn't apply cleanly to the 1180
branch.  Instead these two files are omitted from the merge, and only enough
bits are changed in chunk_demuxer.cc to allow compilation to proceed.  Also,
ranges.h needed IntersectionWith from the above unmerged CL added manually.

BUG= 133567 , 131444 
TBR=fischman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10704142
------------------------------------------------------------------------
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 10 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145974

------------------------------------------------------------------------
r145974 | fischman@chromium.org | Tue Jul 10 15:49:28 PDT 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/media/base/ranges.cc?r1=145974&r2=145973&pathrev=145974

Add missing file from r145966.

BUG= 133567 , 131444 
TBR=fischman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10689147
------------------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Feature-Media -Area-WebKit -Mstone-21 Cr-Content Type-Bug-Regression Cr-Internals-Media M-21
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink

Sign in to add a comment