New issue
Advanced search Search tips

Issue 133565 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

The bottom of the background tab is shining through the black border.

Project Member Reported by meh...@chromium.org, Jun 19 2012

Issue description

Chrome Version       : 21.0.1180.0 canary
URLs (if applicable) :
OS version               : Mac OS 10.6.8


The bottom of the background tab is shining through the black border.


A screenshot is attached.

Thanks and regards
Mehmet



 

Comment 1 by meh...@chromium.org, Jun 19 2012

Bildschirmfoto 2012-06-19 um 22.50.47.png
10.1 KB View Download

Comment 2 by thakis@chromium.org, Jun 19 2012

Owner: thakis@chromium.org

Comment 4 by thakis@chromium.org, Jun 20 2012

Labels: Mstone-21 Merge-Requested
r143179, should be in tomorrow's canary.

If it looks good to mehmet, we should merge this to m21.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 20 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143179

------------------------------------------------------------------------
r143179 | thakis@chromium.org | Wed Jun 20 08:43:37 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_view.mm?r1=143179&r2=143178&pathrev=143179

mac: Don't let background tab highlight bleed into tabstrip border.

BUG= 133565 
TEST=Let mehmet@ look at the next canary

Review URL: https://chromiumcodereview.appspot.com/10574036
------------------------------------------------------------------------

Comment 6 by kareng@google.com, Jun 20 2012

nico, we'll let this go to canary first.

Comment 7 by meh...@chromium.org, Jun 20 2012

Hi Nico. I checked Snapshot 143190. The white border doesn't shine through the tabstrip border anymore. But if you take a look at my attached screenshot, you see that the black outline of the tab is still shining through. What do you think? Can we live with it or is it easy to fix ?
Bildschirmfoto 2012-06-20 um 22.09.42.png
13.6 KB View Download

Comment 8 by thakis@chromium.org, Jun 20 2012

It's fairly easy to fix, but it (somewhat surprisingly) looks worse without the overdraw when not looking at the screen with a loupe (I tried it locally). Because of that, and since we've had that overdraw since forever (and because the tabstrip drawing will be completely rewritten to be bitmap based soonish), I think we'll live with that.

Comment 9 by meh...@chromium.org, Jun 20 2012

Okay, thanks! So then: LGTM :-)

Comment 10 by kareng@google.com, Jun 21 2012

Labels: -Merge-Requested Merge-Approved
Status: Fixed
merged to 1180 in r133565
err, in r143418
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 21 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143418

------------------------------------------------------------------------
r143418 | thakis@chromium.org | Thu Jun 21 11:37:30 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/tabs/tab_view.mm?r1=143418&r2=143417&pathrev=143418

Merge 143179 - mac: Don't let background tab highlight bleed into tabstrip border.

BUG= 133565 
TEST=Let mehmet@ look at the next canary

Review URL: https://chromiumcodereview.appspot.com/10574036

TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10632005
------------------------------------------------------------------------
Status: Verified
This looks fine on Mac osx 10.6.8 - 21.0.1180.9 (Official Build 143861) dev
Screen shot 2012-06-25 at 2.43.37 PM.png
24.8 KB View Download
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-TabStrip -Mstone-21 Cr-UI-Browser-TabStrip Cr-UI M-21
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment