New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 133376 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Find bar top border wobbles in HiDPI mode

Project Member Reported by thakis@chromium.org, Jun 18 2012

Issue description

What steps will reproduce the problem?
1. cmd-f
2. type

What is the expected result?

There should be no spurious border between tab strip and find bar.

What happens instead?


 
Screen Shot 2012-06-18 at 2.37.37 PM.png
26.8 KB View Download

Comment 1 by thakis@chromium.org, Jun 19 2012

Cc: sail@chromium.org rohitrao@chromium.org
Somehow the find bar y coordinate jumps from xxx.5 to just xxx, not clear where.

Comment 2 by a...@chromium.org, Jun 19 2012

I'm playing with -positionFindBarViewAtMaxY:maxWidth:, in particular with the line

 maxY += [containerView cr_lineWidth];

If you remove that line, it doesn't wiggle. If you change it to add one, it doesn't wiggle. Something about putting a view at a fractional location makes it wiggle. Or perhaps it's a Core Animation thing? Still digging.

Comment 3 by a...@chromium.org, Jun 19 2012

When you type, even though it wiggles, no frame methods are called on the find bar view. But, createAnimationForView is getting called.

My theory:

The version of the find bar that has that weird line is on an integer pixel. Each time you type, we animate the find bar to the position that it's currently at. Could Core Animation be rounding?

Comment 4 by a...@chromium.org, Jun 19 2012

I'm ready to blame this on CoreAnimation.

For each letter you type, the method -[FindBarCocoaController moveFindBarIfNecessary:] is called. If the find bar is already showing, then the find bar is continually reset to the same coordinates, optionally via animation.

If you force no animation, which does -setFrame:, there is no wiggle. So there's some kind of non-determinism in CoreAnimation when animating a view to a non-integral frameRect.

Comment 5 by a...@chromium.org, Jun 19 2012

Owner: a...@chromium.org
Status: Started

Comment 6 by a...@chromium.org, Jun 19 2012

Labels: Merge-Requested
This definitely needs a merge to M21, and possibly to M20.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 19 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143021

------------------------------------------------------------------------
r143021 | avi@chromium.org | Tue Jun 19 12:40:25 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm?r1=143021&r2=143020&pathrev=143021

Fix wobbling of find bar.

BUG= 133376 
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/10574021
------------------------------------------------------------------------

Comment 8 by kareng@google.com, Jun 19 2012

avi is this for m20 or m21? pls mark milestone. 

Comment 9 by a...@chromium.org, Jun 19 2012

Labels: Mstone-20
We're targeting chrome fixes for M20. Did we cut M21 yet? If so then we want to merge there too.

Comment 10 by a...@chromium.org, Jun 20 2012

Labels: -Mstone-20 Mstone-21
Probably not important enough for M20. Let's target M21.

Comment 11 by kareng@google.com, Jun 21 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 21 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143455

------------------------------------------------------------------------
r143455 | avi@chromium.org | Thu Jun 21 14:21:39 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm?r1=143455&r2=143454&pathrev=143455

Merge 143021 - Fix wobbling of find bar.

BUG= 133376 
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/10574021

TBR=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10641010
------------------------------------------------------------------------

Comment 13 by a...@chromium.org, Jun 21 2012

Status: Fixed
Status: Verified
Verified as Fixed with 21.0.1180.9 (Official Build 143861) dev.
This is working fine on Mac osx 10.6.8 - 21.0.1180.9 (Official Build 143861) dev
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-FindInPage -Mstone-21 Cr-UI-Browser-FindInPage Cr-UI M-21
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment