New issue
Advanced search Search tips

Issue 133299 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

HiDPI: incognito guy floats above the baseline

Project Member Reported by a...@chromium.org, Jun 18 2012

Issue description

he, and other avatar, should rest on the baseline.
 

Comment 1 by mark@chromium.org, Jun 18 2012

Cc: thakis@chromium.org
Labels: Mstone-20
Status: Available
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 19 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143070

------------------------------------------------------------------------
r143070 | avi@chromium.org | Tue Jun 19 15:41:59 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=143070&r2=143069&pathrev=143070

Fix location of avatar/incognito.

BUG= 133299 
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/10578022
------------------------------------------------------------------------

Comment 3 by a...@chromium.org, Jun 19 2012

Labels: Merge-Requested
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 20 2012

Labels: merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143170

------------------------------------------------------------------------
r143170 | avi@chromium.org | Wed Jun 20 07:42:20 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=143170&r2=143169&pathrev=143170

Merge 143070 - Fix location of avatar/incognito.

BUG= 133299 
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/10578022

TBR=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10577033
------------------------------------------------------------------------

Comment 6 by a...@chromium.org, Jun 20 2012

Labels: -Mstone-20 Mstone-21
Status: Fixed
Merged to M21; calling this done.

Comment 7 by a...@chromium.org, Jun 20 2012

Labels: -Merge-Approved -merge-merged-1180 Merge-Requested
Status: Started
Reverted the merge. This still needs a merge to M21; let's bake it a little first.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 20 2012

Labels: merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143176

------------------------------------------------------------------------
r143176 | avi@chromium.org | Wed Jun 20 08:34:43 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=143176&r2=143175&pathrev=143176

Revert 143170 - Merge 143070 - Fix location of avatar/incognito.

BUG= 133299 
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/10578022

TBR=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10577033

TBR=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10582034
------------------------------------------------------------------------

Comment 9 by a...@chromium.org, Jun 20 2012

Labels: -merge-merged-1180

Comment 10 by kareng@google.com, Jun 21 2012

Owner: a...@chromium.org

Comment 11 by kareng@google.com, Jun 21 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 21 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143456

------------------------------------------------------------------------
r143456 | avi@chromium.org | Thu Jun 21 14:22:12 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=143456&r2=143455&pathrev=143456

Merge 143070 - Fix location of avatar/incognito.

BUG= 133299 
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/10578022

TBR=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10641011
------------------------------------------------------------------------

Comment 13 by a...@chromium.org, Jun 21 2012

Status: Fixed
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-21 M-21 Cr-UI
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment