New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 132762 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Extension bubble sizes are wrong in hidpi mode

Project Member Reported by thakis@chromium.org, Jun 14 2012

Issue description

What steps will reproduce the problem?
1. Install Death Metal Rooster extension
2. Use chrome in HiDPI mode
3. Click extension icon

What is the expected result?

Rooster shows up.

What happens instead?

Bubble is way too big, rooster is only in the lower left 25% of the bubble.

(Avi, Robert: Does one of you have time to squeeze this in?)
 

Comment 1 by sail@chromium.org, Jun 14 2012

Owner: sail@chromium.org
Grabbing.

Comment 2 by thakis@chromium.org, Jun 15 2012

Status: Started
http://codereview.chromium.org/10540173/
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=142347

------------------------------------------------------------------------
r142347 | sail@chromium.org | Fri Jun 15 00:36:16 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=142347&r2=142346&pathrev=142347
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm?r1=142347&r2=142346&pathrev=142347

HiDPI: Fix extension bubble size

The size of extension bubbles was wrong in HiDPI mode.

The problem was that we were using convertRectToBase. As per Avi's PSA, we should be using convertRect:ToView:. See:
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/6b989dcbb79e9ba/029eeb633c5287cc

I did a search and it looks like we made the same mistake in the tab dragging code. Before my fix it was impossible to drag a tab from one window to the right of a tab in another window. This fixes that as well.

BUG= 132762 
TEST=Ran in HiDPI mode on 10.7. Without my fix the extension bubble was 4x the normal size. With my fix the extension bubble was correctly 2x the normal size.


Review URL: https://chromiumcodereview.appspot.com/10540173
------------------------------------------------------------------------

Comment 4 by sail@chromium.org, Jun 15 2012

Status: Fixed

Comment 5 by thakis@chromium.org, Jun 16 2012

Labels: -Mstone-21 Mstone-20 ReleaseBlock-Stable Merge-Requested
Status: Started
This is broken in m20 on hidpi laptops. Fix needs merging.

Comment 6 by dharani@google.com, Jun 18 2012

Labels: -Merge-Requested Merge-Approved

Comment 7 by thakis@chromium.org, Jun 18 2012

Status: Fixed
Merged to 1132 in 142719
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 18 2012

Labels: merge-merged-1132
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=142719

------------------------------------------------------------------------
r142719 | thakis@chromium.org | Mon Jun 18 08:57:39 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm?r1=142719&r2=142718&pathrev=142719
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=142719&r2=142718&pathrev=142719

Merge 142347 - HiDPI: Fix extension bubble size

The size of extension bubbles was wrong in HiDPI mode.

The problem was that we were using convertRectToBase. As per Avi's PSA, we should be using convertRect:ToView:. See:
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/6b989dcbb79e9ba/029eeb633c5287cc

I did a search and it looks like we made the same mistake in the tab dragging code. Before my fix it was impossible to drag a tab from one window to the right of a tab in another window. This fixes that as well.

BUG= 132762 
TEST=Ran in HiDPI mode on 10.7. Without my fix the extension bubble was 4x the normal size. With my fix the extension bubble was correctly 2x the normal size.


Review URL: https://chromiumcodereview.appspot.com/10540173

TBR=sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10553038
------------------------------------------------------------------------

Comment 9 by k...@google.com, Aug 8 2012

Labels: -Merge-Approved
Remove merge approval label, this release has passed.

Comment 10 by k...@google.com, Aug 8 2012

Remove merge approval label, this release has passed.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-Extensions -Mstone-20 Cr-Platform-Extensions Cr-UI M-20
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment