New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 132669 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not currently working on Chromium
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Fullscreen pages shoud block reload, or exit fullscreen

Project Member Reported by scheib@chromium.org, Jun 14 2012

Issue description

A fullscreen tab currently acts poorly when reloaded. Upon reload, document.webkitFullscreenElement === null. No change or error events are generated when calling webkitRequestFullscreen().

It doesn't make sense for a page that has a particular element fullscreen to reload. Upon reloading, the same element may not exist to make it fullscreen. If a reload does happen, it should cause fullscreen to exit. 
 

Comment 1 by scheib@chromium.org, Jun 15 2012

Cc: glen@chromium.org
Glen,

Have a designer opinion on this? If a page has initiated fullscreen for content, such as a video tag, and the user presses Reload what should we do?
- Block the reload (Seems to be what Safari does).
- Exit tab fullscreen (Seems to be what FireFox does).

Here's a toy page to try:
http://scheib.github.com/HTMLMisc/PointerLockAndFullscreen.html

Comment 3 by glen@chromium.org, Jun 16 2012

We should exit fullscreen:

The fullscreening is the content going fullscreen - if the content no-longer exists (due to navigation such as a reload or click), then fullscreen should be exited. The new content won't necessarily be aware that fullscreen will be in effect, so it won't necessarily be showing the right UI.

Comment 4 by koz@chromium.org, Jun 19 2012

FYI, in my patch to make pages that are in content initiated fullscreen exit fullscreen when a navigation occurs, I tried adding a test to see if this also fixes this bug. It seemed to work, but on subsequent test runs I noticed that the test is really flaky.

The test is in the patch history at http://codereview.chromium.org/10378061/ if anyone wants to investigate further.

Comment 6 by scheib@chromium.org, Jun 22 2012

Status: Fixed
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 9 2012

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Area-WebKit -Feature-FullScreen Cr-Content Cr-UI-Browser-FullScreen
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink

Sign in to add a comment