New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 132343 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

[uber page] Edit profile from NTP or profile switcher doesn't work

Project Member Reported by dbeam@chromium.org, Jun 12 2012

Issue description

Chrome Version       : trunk
OS Version           : Linux, but likely all because it's WebUI code.

What steps will reproduce the problem?
1. Sign in to Chrome.
2. Open an NTP.
3. Click on sync username.
4. Select "Edit user".

What is the expected result?
I expect to be taken to the edit profile dialog in the "uber" settings page.

What happens instead?
Instead the page is shown briefly then closed, it seems, leaving you on settings with no context/ability to change the user info.

Please provide any additional information below. Attach a screenshot if
possible.
Works in 19, haven't bisected.
 

Comment 1 by dbeam@chromium.org, Jun 12 2012

Labels: Feature-Options

Comment 2 by dbeam@chromium.org, Jun 12 2012

Cc: dbeam@chromium.org est...@chromium.org
Labels: Action-BisectNeeded

Comment 4 by dbeam@chromium.org, Jun 19 2012

Cc: sail@chromium.org
 Issue 133454  has been merged into this issue.

Comment 5 by dbeam@chromium.org, Jun 19 2012

Cc: -est...@chromium.org
Labels: -Action-BisectNeeded
Owner: est...@chromium.org
Bisected to https://src.chromium.org/viewvc/chrome?view=rev&revision=139419

Comment 6 by dbeam@chromium.org, Jun 19 2012

Cc: est...@chromium.org
Owner: dbeam@chromium.org
Status: Started
https://chromiumcodereview.appspot.com/10576011

Comment 7 by dbeam@chromium.org, Jun 19 2012

Summary: [uber page] Edit profile from NTP or profile switcher doesn't work
Also applies to profile switcher > Edit (the icon and list of profiles next to the tab strip).
Labels: ReleaseBlock-Stable

Comment 9 by dbeam@chromium.org, Jun 22 2012

Owner: est...@chromium.org
estade had a better patch for this
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 22 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143541

------------------------------------------------------------------------
r143541 | estade@chromium.org | Thu Jun 21 22:23:04 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/manage_profile_handler2.h?r1=143541&r2=143540&pathrev=143541
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/manage_profile_handler2.cc?r1=143541&r2=143540&pathrev=143541
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/options2/browser_options.js?r1=143541&r2=143540&pathrev=143541
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/options2/manage_profile_overlay.js?r1=143541&r2=143540&pathrev=143541

Fix edit profile link in NTP

currently the manage profile overlay is dimissed when new profile data comes in --- instead, just update the overlay.

There's a lot of simplification here which is possible because only one profile (the currently active one) may be managed.

BUG= 132343 
TEST=Sign in to Chrome, click username on NTP, edit the current profile.

Review URL: https://chromiumcodereview.appspot.com/10579026
------------------------------------------------------------------------
Labels: Merge-Requested

Comment 13 by kareng@google.com, Jun 26 2012

evan, can u confirm this on canary that it works and there are no tweaks needed or crashes.
can I confirm on ToT instead?

Comment 15 by kareng@google.com, Jun 27 2012

it needs to be on canary so u can be sure there are no related crashes either :)
manual testing indicates it works on canary.

Comment 17 by kareng@google.com, Jun 29 2012

can u pls give go/crash a once over to make sure this cl didn't introduce new crashes?
don't see anything in crash/

Comment 19 by kareng@google.com, Jun 29 2012

Labels: -Merge-Requested Merge-Approved
ty
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 3 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145237

------------------------------------------------------------------------
r145237 | estade@chromium.org | Mon Jul 02 18:32:13 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/options2/manage_profile_overlay.js?r1=145237&r2=145236&pathrev=145237
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/options2/browser_options.js?r1=145237&r2=145236&pathrev=145237
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/webui/options2/manage_profile_handler2.cc?r1=145237&r2=145236&pathrev=145237
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/webui/options2/manage_profile_handler2.h?r1=145237&r2=145236&pathrev=145237

Merge 143541 - Fix edit profile link in NTP

currently the manage profile overlay is dimissed when new profile data comes in --- instead, just update the overlay.

There's a lot of simplification here which is possible because only one profile (the currently active one) may be managed.

BUG= 132343 
TEST=Sign in to Chrome, click username on NTP, edit the current profile.

Review URL: https://chromiumcodereview.appspot.com/10579026

TBR=estade@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10689084
------------------------------------------------------------------------

Comment 21 by kareng@google.com, Jul 9 2012

Status: Fixed

Comment 22 Deleted

Verified on all OS. Between clicking edit on sync username and screenshot 2 I am noticing screenshot 1. Can't we not see that page occurring?
Screen Shot 2012-07-12 at 11.25.27 AM.png
1.6 MB View Download
Screen Shot 2012-07-12 at 11.24.56 AM.png
1.6 MB View Download

Comment 24 by dbeam@chromium.org, Jul 12 2012

#23 - file a new bug
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: -Feature-Options Feature-Settings
Project Member

Comment 27 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Area-UI -Type-Regression -Mstone-21 -Feature-Settings Type-Bug-Regression Cr-UI-Settings Cr-UI M-21
Project Member

Comment 28 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment