New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 132119 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Google Chrome has crashed. Relaunch Now window is shown twice

Project Member Reported by pucchakayala@chromium.org, Jun 11 2012

Issue description

Chrome Version       : 21.0.1171.0 (Official Build 141382)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:

What steps will reproduce the problem?
1. Launch Chrome and induce a browser crash using chrome://inducebrowsercrashforrealz
2. Click on "Ok" button in the Relaunch dialog.
3. Verify the behavior.

What is the expected result?
Chrome window should be opened with the info-bar giving option to 
Restore the session.

What happens instead?
Chrome window is opened and an info-bar is shown asking to Restore the session.
Whoa! Google Chrome has crashed. Relaunch Now dialog is shown again.

Please provide any additional information below. Attach a screenshot if
possible.

 
Capture.PNG
151 KB View Download
I will update the bisect info soon.
Cc: pavanv@chromium.org
Labels: -Pri-2 Pri-1
That is because Chrome crashed again up on relaunch. Do you see any crash-ids?
I just see one crash id getting generated in chrome://crashes

Comment 5 by kareng@google.com, Jun 13 2012

bisect info for this?

Comment 6 Deleted

This was working fine on 21.0.1155.2 (139341) & started breaking from 21.0.1163.0 (140240)

Unable to provide the bisect result for this bug as the Relaunch Chrome dialog is not shown on the chromium builds.
This was working fine on 21.0.1156.0, 21.0.1156.1 and broken from 21.0.1157.0 (139641) onwards.

Comment 9 by kareng@google.com, Jun 19 2012

thanks Geetha!

Comment 11 by grt@chromium.org, Jun 19 2012

Can we get the QA gang set up with symbols and windbg?  It seems like you've spent some time reproing w/ different builds, so there's been an opportunity to grab a stack trace and attach it to the bug.

Comment 12 by kareng@google.com, Jun 19 2012

Labels: ReleaseBlock-Stable
robert said he'll try to take a look tomorrow. he thinks it's not a double crash.

Comment 13 by kareng@google.com, Jun 22 2012

Owner: robertshield@chromium.org
Status: Assigned
robert?
Turns out the second dialog is shown by the GPU process. This happens because chrome.exe inspects an env. var at startup to determine whether to show the restart dialog. 

This env var is cleared at some point during startup but clearly not before the GPU process is started. This causes the GPU process to also inherit the env var and show the crash dialog. This is annoying but won't harm functionality.

A low-side-effect workaround is in the pipes, a cleaner solution will be needed later.
Cc: cpu@chromium.org apatrick@chromium.org
A fix that works, but is ugly is here: https://chromiumcodereview.appspot.com/10657024/. Waiting for review feedback.
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 26 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144224

------------------------------------------------------------------------
r144224 | robertshield@chromium.org | Tue Jun 26 11:59:27 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/breakpad_win.cc?r1=144224&r2=144223&pathrev=144224

Don't show the restart dialog in the GPU process.

BUG= 132119 
TEST=Go to chrome://inducebrowsercrashforrealz, observe that only a single "Whoa!" dialog appears.


Review URL: https://chromiumcodereview.appspot.com/10657024
------------------------------------------------------------------------
Status: Fixed
Labels: Merge-Requested

Comment 19 by kareng@google.com, Jun 28 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 28 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144711

------------------------------------------------------------------------
r144711 | robertshield@chromium.org | Thu Jun 28 07:13:58 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/breakpad_win.cc?r1=144711&r2=144710&pathrev=144711

Merge 144224 - Don't show the restart dialog in the GPU process.

BUG= 132119 
TEST=Go to chrome://inducebrowsercrashforrealz, observe that only a single "Whoa!" dialog appears.


Review URL: https://chromiumcodereview.appspot.com/10657024

TBR=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10689021
------------------------------------------------------------------------
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-Internals -Mstone-21 Type-Bug-Regression M-21 Cr-Internals
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment