New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 131401 link

Starred by 11 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocking:
issue 131057

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Chrome crashes on opening Ms office files - raise-5FCF43D

Reported by sivagami@chromium.org, Jun 6 2012

Issue description

Version: 20.0.1132.27
OS: Chrome OS: 2268.57.0 - beta channel
Document viewing: 2.2.31.3

What steps will reproduce the problem?
1. Open File manager
2. Try Open any ms office file 
3.

What is the expected output?
File should be opened

 What do you see instead?
Chrome crashes

Please use labels and text to provide additional information.

Update the crash report in next comment
 
Labels: Mstone-20
Labels: Crash-Reproducible
Summary: Chrome crashes on opening Ms office files - raise-5FCF43D
This is 100 % reproducible. There is no way to open Ms office files (doc,.docx,ppt, etc..)

Crash report link: http://crash.corp.google.com/reportdetail?reportid=22a3c1773d5df09c

0x7ff6a36f3e85 	[libc-2.11.1.so] 	- ../nptl/sysdeps/unix/sysv/linux/raise.c:64] 	raise
0x7ff6a36f52e6 	[libc-2.11.1.so] 	- abort.c:92] 	abort
0x7ff6a607b998 	[chrome] 	- base/debug/debugger_posix.cc:214] 	base::debug::BreakDebugger
0x7ff6a71c219c 	[chrome] 	- chrome/browser/extensions/extension_event_router.cc:428] 	ExtensionEventRouter::OnEventAck
0x7ff6a83ca79e 	[chrome] 	- ./ipc/ipc_message.h:158] 	ExtensionHost::OnMessageReceived
0x7ff6a737b5f5 	[chrome] 	- content/browser/web_contents/web_contents_impl.cc:561] 	WebContentsImpl::OnMessageReceived
0x7ff6a733e562 	[chrome] 	- content/browser/renderer_host/render_view_host_impl.cc:827] 	content::RenderViewHostImpl::OnMessageReceived
0x7ff6a7f0971d 	[chrome] 	- content/browser/renderer_host/render_process_host_impl.cc:941] 	RenderProcessHostImpl::OnMessageReceived
0x7ff6a7e9de05 	[chrome] 	- ipc/ipc_channel_proxy.cc:247] 	IPC::ChannelProxy::Context::OnDispatchMessage
0x7ff6a7cfc3c5 	[chrome] 	- ./base/callback.h:272] 	MessageLoop::RunTask
0x7ff6a7cfc2f7 	[chrome] 	- base/message_loop.cc:470] 	MessageLoop::DeferOrRunPendingTask
0x7ff6a7cf9dd2 	[chrome] 	- base/message_loop.cc:647] 	MessageLoop::DoWork
0x7ff6a7e853d3 	[chrome] 	- base/message_pump_glib.cc:210] 	base::MessagePumpGlib::RunWithDispatcher
0x7ff6a7cf979f 	[chrome] 	- base/message_loop.cc:390] 	MessageLoop::Run
0x7ff6a7e852a3 	[chrome] 	- chrome/browser/chrome_browser_main.cc:1894] 	ChromeBrowserMainParts::MainMessageLoopRun
0x7ff6a72ce570 	[chrome] 	- content/browser/browser_main_loop.cc:453] 	content::BrowserMainLoop::RunMainMessageLoopParts
0x7ff6a72ce64c 	[chrome] 	- content/browser/browser_main_runner.cc:98] 	BrowserMainRunnerImpl::Run
0x7ff6a7cdaaa8 	[chrome] 	- content/browser/browser_main.cc:21] 	BrowserMain
0x7ff6a6041766 	[chrome] 	- content/app/content_main_runner.cc:290] 	ContentMainRunnerImpl::Run
0x7ff6a7cd1a20 	[chrome] 	- content/app/content_main.cc:35] 	content::ContentMain
0x7ff6a7cd1917 	[chrome] 	- chrome/app/chrome_main.cc:32] 	ChromeMain
0x7ff6a36e05cc 	[libc-2.11.1.so] 	- libc-start.c:240] 	__libc_start_main
0x7ff6a591c3e8 	[chrome] 	+ 0x006e63e8] 	

Comment 3 by josa...@google.com, Jun 6 2012

Cc: bradchen@chromium.org
Brad, could this be related to https://code.google.com/p/chromium/issues/detail?id=131057?
Happening on all platforms. 
This should be tracked separately, since Chrome is crashing. The other is a failure to load the NaCl module, but other Chrome processes do not crash.

Can you open any NaCl-based content? For example something from here: https://chrome.google.com/webstore/detail/hadhbabalhndlakccdnkbalfndbjhjcn?utm_source=chrome-ntp-icon

This is reminding me of  http://crbug.com/125636 . It would be nice to confirm that that previous issue hadn't slipped from canary/dev into beta.
 
If it is happening on all platforms then it is not  http://crbug.com/125636 ; that bug was Linux-specific.
Testing on my Lumpy (20.0.1132.15 dev, Stable channel) I seem to be able to open a .docx file and a .pptx file. How do we get Chromium revisions between 1132.15 and 1132.27?


I meant the issue is happening on all Chrome OS platforms (Alex, ZGB, Mario, lumpy..)
Labels: -Pri-0 Pri-1 Iteration-57
Owner: tbarzic@chromium.org
Status: Assigned
this is top #2 most frequent crash on M20
Issue blocking CrOS Beta, please update when fix identified and do merge-request. 
I'll kick off new build candidate once merged 
Cc: mpcomplete@chromium.org aa@chromium.org
Labels: Feature-Extensions
From the crash report, the crash is happening in ExtensionEventRouter::OnEventAck, code I'm not familiar with. I've added a couple guys from the Extensions team in case they recognize something.
Cc: h...@chromium.org
Owner: mpcomplete@chromium.org
I think I know what's happening. Looks like a NULL-deref of ExtensionHost::extension_. I have to add some NULL checks.

I'll take this.

Comment 14 by mal@google.com, Jun 7 2012

Cc: kanliu@chromium.org kuscher@chromium.org
Issue 131406 has been merged into this issue.
Any update on this?
Fix will be checked in soon: http://codereview.chromium.org/10538041/

Then I presume it'll need to be merged?
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 7 2012

Summary: Chrome crashes on opening Ms office files - raise-5FCF43D
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=141090

------------------------------------------------------------------------
r141090 | mpcomplete@chromium.org | Thu Jun 07 14:59:10 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=141090&r2=141089&pathrev=141090
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_event_router.cc?r1=141090&r2=141089&pathrev=141090

Add some NULL-checks for ExtensionHost::extension to fix a crash bug.

BUG= 131401 
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10538041
------------------------------------------------------------------------
Owner: zelidrag@chromium.org
This should be fixed on trunk. Does it need to be merged to a branch?
Cc: satorux@chromium.org
Yes, we should merge this to M20.

@satorux - Since you were the M20 merge master, do you mind doing this (hopefully last) one? 
Labels: Merge-Requested
Owner: satorux@chromium.org
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 12 2012

Labels: merge-merged-1132
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=141762

------------------------------------------------------------------------
r141762 | mpcomplete@chromium.org | Tue Jun 12 15:45:22 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/extensions/extension_event_router.cc?r1=141762&r2=141761&pathrev=141762

Merge 141090 - Add some NULL-checks for ExtensionHost::extension to fix a crash bug.

BUG= 131401 
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10538041

TBR=mpcomplete@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10542130
------------------------------------------------------------------------
Any work pending before this can be marked fixed?
Status: Fixed
This is fixed and now merged to the M20 branch. No more to do.
This is still happening on today's release candidate Chrome OS 2268.70.0, Chrome 20.0.1132.34. The CL didn't make it to this build.
Cc: ddrew@chromium.org
Status: Assigned
CL is in, but we are seeing the bug.
Owner: mpcomplete@chromium.org
I'm dumb. From the crash report, this is obviously just a CHECK. I'm going to remove the CHECK and then try to figure out why we're hitting it.
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 13 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=141975

------------------------------------------------------------------------
r141975 | mpcomplete@chromium.org | Wed Jun 13 14:12:17 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_event_router.cc?r1=141975&r2=141974&pathrev=141975

Remove CHECK that's causing a crash in chromeos.

BUG= 131401 
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10541147
------------------------------------------------------------------------
 Issue 132563  has been merged into this issue.
Project Member

Comment 32 by bugdroid1@chromium.org, Jun 13 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=141982

------------------------------------------------------------------------
r141982 | mpcomplete@chromium.org | Wed Jun 13 15:03:44 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/extensions/extension_event_router.cc?r1=141982&r2=141981&pathrev=141982

Merge 141975 - Remove CHECK that's causing a crash in chromeos.

BUG= 131401 
TEST=no

Review URL: https://chromiumcodereview.appspot.com/10541147

TBR=mpcomplete@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10546156
------------------------------------------------------------------------

Comment 33 by ddrew@chromium.org, Jun 13 2012

Labels: Noteworthy
2268.42.0 was released 2 weeks ago with doc viewing 1.x.x by default. Last week, doc viewing version updated to 2.2.31.3, which is causing the problem.  
R20 prev beta build has doc viewing 1.x.x . => The extension is not updated to 2.2.31.3 until any Chrome OS update (or) clicking on "Update Extension"


Did @mpcomplete's fix in Comment 32 solve this issue?
Status: Fixed
Status: Verified
Verified on 20.0.1132.37 Platform 2268.85.0
Issue 133582 has been merged into this issue.

Comment 40 by ddrew@chromium.org, Jul 10 2012

Labels: -Noteworthy

Comment 41 by k...@google.com, Aug 8 2012

Labels: -Merge-Approved
Remove merge approval label, this release has passed.

Comment 42 by k...@google.com, Aug 8 2012

Remove merge approval label, this release has passed.
Project Member

Comment 43 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 44 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-UI -Feature-FileManager -Crash -Mstone-20 -Feature-Extensions Type-Bug-Regression Cr-Stability Cr-Platform-Apps-FileManager M-20 Cr-UI Cr-Platform-Extensions
Project Member

Comment 45 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment