Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 130678 Chromoting Host should upload crashes to Breakpad (Win)
Starred by 4 users Project Member Reported by alexeypa@chromium.org, May 31, 2012 Back to list
Status: Fixed
Owner: alexeypa@chromium.org
Closed: Jul 2012
Components:
OS: All
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
Chromoting Host should upload crashes to Breakpad.
 
Comment 1 by w...@chromium.org, Jun 6, 2012
Labels: Mstone-21
Status: Started
Project Member Comment 2 by bugdroid1@chromium.org, Jun 8, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=141239

------------------------------------------------------------------------
r141239 | alexeypa@chromium.org | Fri Jun 08 11:17:31 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/host_service_win.cc?r1=141239&r2=141238&pathrev=141239
 A http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad_mac.mm?r1=141239&r2=141238&pathrev=141239
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/host_ui.rc?r1=141239&r2=141238&pathrev=141239
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/elevated_controller_module_win.cc?r1=141239&r2=141238&pathrev=141239
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/remoting.gyp?r1=141239&r2=141238&pathrev=141239
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/DEPS?r1=141239&r2=141238&pathrev=141239
 A http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/breakpad_win.cc?r1=141239&r2=141238&pathrev=141239
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/remoting_me2me_host.cc?r1=141239&r2=141238&pathrev=141239
 A http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad_win_unittest.cc?r1=141239&r2=141238&pathrev=141239
 A http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/constants_win.cc?r1=141239&r2=141238&pathrev=141239
 A http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad.h?r1=141239&r2=141238&pathrev=141239
 A http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad_win.cc?r1=141239&r2=141238&pathrev=141239
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/plugin/daemon_installer_win.cc?r1=141239&r2=141238&pathrev=141239
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/constants.h?r1=141239&r2=141238&pathrev=141239
 A http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad_linux.cc?r1=141239&r2=141238&pathrev=141239
 A http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/breakpad.h?r1=141239&r2=141238&pathrev=141239

Make Chromoting Host report crashes to Breakpad (Windows only). The user must enable crash dumps collection by setting the "usagestats" value in the ClientState or ClientStateMedium key.

BUG= 130678 
TEST=remoting_unittests.BreakpadWinDeathTest


Review URL: https://chromiumcodereview.appspot.com/10495003
------------------------------------------------------------------------
Project Member Comment 3 by bugdroid1@chromium.org, Jun 12, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=141586

------------------------------------------------------------------------
r141586 | alexeypa@chromium.org | Mon Jun 11 18:28:33 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt?r1=141586&r2=141585&pathrev=141586
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/gtest_exclude/remoting_unittests.gtest-tsan_win32.txt?r1=141586&r2=141585&pathrev=141586

Disabling BreakpadWinDeathTest tests when running under Dr. Memory and TSAN. Dr, Memory gets confused about intentional exceptions generated by the tests. TSAN found http://crbug.com/132164 which is baing investigated. In either case the code in question is used by the tests only.

BUG= 130678 , 132164 

Review URL: https://chromiumcodereview.appspot.com/10535107
------------------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, Jun 14, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=142056

------------------------------------------------------------------------
r142056 | alexeypa@chromium.org | Wed Jun 13 18:28:21 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/webapp/_locales/en/messages.json?r1=142056&r2=142055&pathrev=142056

Adding "Help us to improve..." message to be presented next to the checkbox enabling crash dump collection.

BUG= 130678 


Review URL: https://chromiumcodereview.appspot.com/10537159
------------------------------------------------------------------------
Project Member Comment 5 by bugdroid1@chromium.org, Jun 15, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=142305

------------------------------------------------------------------------
r142305 | jamiewalch@google.com | Thu Jun 14 18:16:58 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/webapp/_locales/en/messages.json?r1=142305&r2=142304&pathrev=142305

Revert 142056 - Adding "Help us to improve..." message to be presented next to the checkbox enabling crash dump collection.

BUG= 130678 


Review URL: https://chromiumcodereview.appspot.com/10537159

TBR=alexeypa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10544169
------------------------------------------------------------------------
Project Member Comment 6 by bugdroid1@chromium.org, Jun 16, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=142581

------------------------------------------------------------------------
r142581 | alexeypa@chromium.org | Fri Jun 15 22:09:25 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/host_service_win.cc?r1=142581&r2=142580&pathrev=142581
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad_mac.mm?r1=142581&r2=142580&pathrev=142581
 A http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/usage_stats_consent_win.cc?r1=142581&r2=142580&pathrev=142581 (from /trunk/src/remoting/host/breakpad_win.cc revision 142544)
 A http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/usage_stats_consent.h?r1=142581&r2=142580&pathrev=142581 (from /trunk/src/remoting/host/breakpad.h revision 142544)
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/elevated_controller_module_win.cc?r1=142581&r2=142580&pathrev=142581
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/remoting.gyp?r1=142581&r2=142580&pathrev=142581
 D http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/breakpad_win.cc?r1=142581&r2=142580&pathrev=142581
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/remoting_me2me_host.cc?r1=142581&r2=142580&pathrev=142581
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad_win_unittest.cc?r1=142581&r2=142580&pathrev=142581
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/constants_win.cc?r1=142581&r2=142580&pathrev=142581
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad.h?r1=142581&r2=142580&pathrev=142581
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad_win.cc?r1=142581&r2=142580&pathrev=142581
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/plugin/daemon_installer_win.cc?r1=142581&r2=142580&pathrev=142581
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/constants.h?r1=142581&r2=142580&pathrev=142581
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad_linux.cc?r1=142581&r2=142580&pathrev=142581
 D http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/breakpad.h?r1=142581&r2=142580&pathrev=142581

C++ readability review fixes for r141239: Make Chromoting Host report crashes to Breakpad (Windows only).

BUG= 130678 
TEST=remoting_unittests.BreakpadWinDeathTest

Review URL: https://chromiumcodereview.appspot.com/10535082
------------------------------------------------------------------------
Project Member Comment 7 by bugdroid1@chromium.org, Jun 22, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143504

------------------------------------------------------------------------
r143504 | alexeypa@chromium.org | Thu Jun 21 18:04:36 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/webapp/host_setup_dialog.js?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/plugin/host_script_object.h?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/host_service_win.cc?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/elevated_controller.idl?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/usage_stats_consent_win.cc?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/plugin/daemon_controller.h?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/plugin/daemon_controller_win.cc?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/plugin/host_script_object.cc?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/usage_stats_consent.h?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/elevated_controller_module_win.cc?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/installer/chromoting.wxs?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/remoting_me2me_host.cc?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/plugin/daemon_controller_linux.cc?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/webapp/_locales/en/messages.json?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/webapp/host_plugin_proto.js?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/webapp/host_controller.js?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/elevated_controller_win.cc?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/plugin/daemon_controller_mac.cc?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/webapp/main.html?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/base/breakpad_win.cc?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/elevated_controller_win.h?r1=143504&r2=143503&pathrev=143504
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/webapp/main.css?r1=143504&r2=143503&pathrev=143504

The user's consent to crash dumps reporting can now be set via the UI (Windows only). The checkbox is presented on the Start/Change PIN dialog. The user's selection is then written to usagestats under ClientStateMedium key.

BUG= 130678 

Review URL: https://chromiumcodereview.appspot.com/10537182
------------------------------------------------------------------------
Comment 8 by alexeypa@chromium.org, Jun 27, 2012
The Windows part is done. Mac and Linux to go.
Project Member Comment 9 by bugdroid1@chromium.org, Jun 27, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144588

------------------------------------------------------------------------
r144588 | alexeypa@chromium.org | Wed Jun 27 15:30:16 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/usage_stats_consent_win.cc?r1=144588&r2=144587&pathrev=144588
 M http://src.chromium.org/viewvc/chrome/trunk/src/remoting/host/plugin/daemon_controller_win.cc?r1=144588&r2=144587&pathrev=144588

Addressing remaining Breakpad integration issues:
- Offer to enable crash dump reporting when the host is not installed yet.
- Do not log anything until logging is initialized to avoid Application Verifier errors.

BUG= 130678 


Review URL: https://chromiumcodereview.appspot.com/10695012
------------------------------------------------------------------------
Status: Fixed
Summary: Chromoting Host should upload crashes to Breakpad (Win) (was: NULL)
Closing. http://crbug.com/136579 and http://crbug.com/136580 were opened to track Mac and Linux.
Project Member Comment 11 by bugdroid1@chromium.org, Oct 13, 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Blocking: chromium:164406
Project Member Comment 13 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Area-Internals -Feature-Chromoting -Mstone-21 Cr-Services-Chromoting M-21 Cr-Internals
Project Member Comment 14 by bugdroid1@chromium.org, Mar 14, 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment