New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 130649 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 134196

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Lion fullscreen animation shows window contents behind animation

Project Member Reported by rohitrao@chromium.org, May 31 2012

Issue description

On Lion, click the fullscreen button to make a window go fullscreen.  Notice that a second copy of the window contents paints as the background behind the animation.  We should be seeing the window animate larger while the desktop slides away.

Bisecting gave the range http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=138144%3A138152.  This was most likely introduced by r138150.  
 

Comment 1 by k...@google.com, Jun 4 2012

Labels: Mstone-21
Status: Assigned
I do not see this issue on my 10.7 macpro when using the fullscreen button at the top right of a Chrome window (two arrows pointing away from each other).

I do see this when initiated from JavaScript https://developer.mozilla.org/samples/domref/fullscreen.html

However it did not appear on a mac laptop thakis was using, so it may be somehow hardware dependent?
Cc: rsesek@chromium.org rohitrao@chromium.org
rohitrao, rsesek, might you have any insight into what is causing this? Where is related code that deals what what image is used in the transition animation? How do we interact with OSX for this animation?
Labels: -Pri-2 Pri-1 ReleaseBlock-Stable
This isn't 100% reproducible for me, but I still see it very often.  For some reason the fullscreen browser_tests show this reliably.

When this happens, it looks really bad.  I think this should block Stable, at least.
Ah, I see, it's somehow caused by the fullscreen exit bubble.  The graphical glitch does not show up if you trigger normal Lion fullscreen, because we don't show an exit bubble in that case.  The glitch only shows up when you trigger HTML5 fullscreen and the bubble is visible.

Comment 6 by scheib@chromium.org, Jun 26 2012

I'm currently working on crashers - I started to investigate this
previously and haven't made progress yet.  If it is e.g. a bug in OSX with
having the bubble shown at the time of transition perhaps we can work
around it by waiting until the transition completes before showing the
bubble.

Comment 7 by scheib@chromium.org, Jun 27 2012

Status: Started

Comment 8 by rsesek@chromium.org, Jun 28 2012

Cc: -rsesek@chromium.org scheib@chromium.org
Owner: rsesek@chromium.org
I have a fix.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 28 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144723

------------------------------------------------------------------------
r144723 | rsesek@chromium.org | Thu Jun 28 09:04:14 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=144723&r2=144722&pathrev=144723

[Mac] Do not show the fullscreen exit bubble while transitioning. Wait until the transition ends.

BUG= 130649 
TEST=Enter HTML5 fullscreen and do not see the desktop background replaced by a webpage. See the exit bubble once the transition completes.


Review URL: https://chromiumcodereview.appspot.com/10694018
------------------------------------------------------------------------
Blocking: chromium:134196
Labels: -ReleaseBlock-Stable
I'll merge this change with other related patches in  issue 134196  after it's been on canary several days.
Status: Fixed
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 9 2012

Labels: merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145794

------------------------------------------------------------------------
r145794 | scheib@chromium.org | Mon Jul 09 16:43:47 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=145794&r2=145793&pathrev=145794

Merge 144723 - [Mac] Do not show the fullscreen exit bubble while transitioning. Wait until the transition ends.
Merge approved in roll-up issue  crbug.com/134196#c9 .

BUG= 130649 
TEST=Enter HTML5 fullscreen and do not see the desktop background replaced by a webpage. See the exit bubble once the transition completes.


Review URL: https://chromiumcodereview.appspot.com/10694018

TBR=rsesek@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10756021
------------------------------------------------------------------------
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Feature-FullScreen -Mstone-21 Cr-UI M-21 Cr-UI-Browser-FullScreen
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment