New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 130623 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Metro snap view UI changes needed for Chrome

Project Member Reported by robertshield@chromium.org, May 31 2012

Issue description

Chrome in 20% snap view looks an awful lot like full screen mode Chrome. That's because it is full screen mode Chrome. 

The tabstrip is sadly unusable on moderately low resolution screens and the omnibox, settings menus etc. are smooshed together.

We plan to, as a first pass, make it such that touching an element of the Chrome UI in snap view pops Chrome back into full screen mode. The Chrome UI itself will be a somewhat neutered address bar, with no tab strip and possibly a neutered omnibox.

This bug will track the work to make this happen.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=141723

------------------------------------------------------------------------
r141723 | robertshield@chromium.org | Tue Jun 12 13:16:13 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browser_window.cc?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.cc?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_window.h?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.h?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_command_ids.h?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browser_window.h?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_win.cc?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_browser_window.cc?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.h?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_win.cc?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_browser_window.h?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=141723&r2=141722&pathrev=141723
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_win.h?r1=141723&r2=141722&pathrev=141723

First pass at making Chrome support metro snap mode. It creates a fullscreen-alike mode that Chrome may enter when in metro snap mode.

This mode removes the chrome parts of Chrome as well as disabling the F11 key, while clamping Chrome to the size of the snap view portion of the screen.

BUG= 130623 
TEST=NONE


Review URL: https://chromiumcodereview.appspot.com/10446106
------------------------------------------------------------------------
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 12 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=141728

------------------------------------------------------------------------
r141728 | sail@chromium.org | Tue Jun 12 13:49:26 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browser_window.cc?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.cc?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_window.h?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.h?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_command_ids.h?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browser_window.h?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_win.cc?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_browser_window.cc?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.h?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_win.cc?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_browser_window.h?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=141728&r2=141727&pathrev=141728
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_win.h?r1=141728&r2=141727&pathrev=141728

Revert 141723 - First pass at making Chrome support metro snap mode. It creates a fullscreen-alike mode that Chrome may enter when in metro snap mode.

This mode removes the chrome parts of Chrome as well as disabling the F11 key, while clamping Chrome to the size of the snap view portion of the screen.

BUG= 130623 
TEST=NONE


Review URL: https://chromiumcodereview.appspot.com/10446106

TBR=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10534123
------------------------------------------------------------------------
Awesome - thanks a lot, guys.

Robert, have we found a way yet to make ourselves the big snap? I.e. does TryUnsnap or whatever work?
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=142074

------------------------------------------------------------------------
r142074 | robertshield@chromium.org | Wed Jun 13 19:44:38 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browser_window.cc?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.cc?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_window.h?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.h?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_command_ids.h?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/panels/panel_browser_window.h?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_win.cc?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.cc?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_browser_window.cc?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.h?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_win.cc?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/test_browser_window.h?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser.h?r1=142074&r2=142073&pathrev=142074
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_win.h?r1=142074&r2=142073&pathrev=142074

First pass at making Chrome support metro snap mode. It creates a fullscreen-alike mode that Chrome may enter when in metro snap mode.

This mode removes the chrome parts of Chrome as well as disabling the F11 key, while clamping Chrome to the size of the snap view portion of the screen.

Identical to http://crrev.com/141723 except for minor fixes in browser_view.cc to compile on Aura.

BUG= 130623 
TEST=NONE


Review URL: https://chromiumcodereview.appspot.com/10536144
------------------------------------------------------------------------
Labels: -Restrict-View-Google
Making visible.
 Issue 132845  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 19 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=142956

------------------------------------------------------------------------
r142956 | robertshield@chromium.org | Tue Jun 19 08:18:47 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/fullscreen_controller.cc?r1=142956&r2=142955&pathrev=142956
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_win.cc?r1=142956&r2=142955&pathrev=142956
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/frame/browser_view.cc?r1=142956&r2=142955&pathrev=142956
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/widget/native_widget_win.h?r1=142956&r2=142955&pathrev=142956

Neuter alternate methods of entering fullscreen mode when in metro snap (via extension and via JS fs api).

Correct appearance of fullscreen bubble when moving from fullscreen non-snap to snap to non-snap.

BUG= 130623 
TEST=Open metro chrome. Enter fullscreen mode. Enter metro snap mode. Exit metro snap mode. Observe fullscreen is exited, no bubble appears. Also, visit a page that uses JS or extension APIS to enter fullscreen mode while in metro snap. Observe that those API calls do not enter fullscreen.


Review URL: https://chromiumcodereview.appspot.com/10578012
------------------------------------------------------------------------
Labels: -Pri-2 Pri-1
Labels: Mstone-21 ReleaseBlock-Beta
Would really like r142956 to get to M21, metro snap is rather buggy without it.

Comment 10 by kareng@google.com, Jun 20 2012

Labels: Merge-Approved
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 20 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143184

------------------------------------------------------------------------
r143184 | robertshield@chromium.org | Wed Jun 20 09:18:31 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/views/widget/native_widget_win.h?r1=143184&r2=143183&pathrev=143184
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/ui/views/widget/native_widget_win.cc?r1=143184&r2=143183&pathrev=143184
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/views/frame/browser_view.cc?r1=143184&r2=143183&pathrev=143184
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/fullscreen_controller.cc?r1=143184&r2=143183&pathrev=143184

Merge 142956 - Neuter alternate methods of entering fullscreen mode when in metro snap (via extension and via JS fs api).

Correct appearance of fullscreen bubble when moving from fullscreen non-snap to snap to non-snap.

BUG= 130623 
TEST=Open metro chrome. Enter fullscreen mode. Enter metro snap mode. Exit metro snap mode. Observe fullscreen is exited, no bubble appears. Also, visit a page that uses JS or extension APIS to enter fullscreen mode while in metro snap. Observe that those API calls do not enter fullscreen.


Review URL: https://chromiumcodereview.appspot.com/10578012

TBR=robertshield@chromium.org
------------------------------------------------------------------------

Comment 12 by kareng@google.com, Jun 20 2012

Status: Fixed
closing.
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-21 M-21 Cr-UI
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment