New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 130069 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Compat , Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Page contents is shifted to the left on http://evegate.com

Reported by stas.mia...@gmail.com, May 29 2012

Issue description

Chrome Version : 20.0.1132.17 beta
URL : https://gate.eveonline.com/Profile/${char_name}/CharacterSheet

Behavior in Chrome 19:
  Renders correctly. Page contents IS NOT shifted to the left.

What steps will reproduce the problem?
  1. Create EVE Online account or use an existing one.
  2. Log in to EVE Gate (http://evegate.com).
  3. Select a character.
  4. Go to Profile > Character Sheet.
 
Screenshot-EVE Online | EVE Gate - Character Sheet - Google Chrome.png
213 KB View Download

Comment 1 by tkent@chromium.org, May 30 2012

Labels: -Type-Bug -Pri-2 Type-Regression Pri-1 Area-WebKit WebKit-Rendering Mstone-20 ReleaseBlock-Stable

Comment 2 by dharani@google.com, May 30 2012

Labels: Action-BisectNeeded

Comment 3 by pavanv@chromium.org, May 31 2012

Owner: ligim...@chromium.org
Cc: pavanv@chromium.org
Labels: Action-FeedbackNeeded
Could you send us a test account info in which Character has been created . I created an account & it is not letting me to log in and complains that I do not have created any characters. Hence provide us with a test account info .. for further debugging.
I don't want to give you password from my personal account(s) for obvious reasons. But since you've created a trial already, give me login/pass and I will create a char there. Just don't tell anyone, account sharing is prohibited. ;-)

Comment 6 by dharani@google.com, Jun 4 2012

Ligi, any updates?
Cc: -pavanv@chromium.org
Owner: pavanv@chromium.org
Pavan, can you look into this?
@stas, I have mailed you the test a/c details. Let me know once you created a char on evegate. Thanks in advance.

Comment 9 by pavanv@chromium.org, Jun 11 2012

Labels: -ReleaseBlock-Stable
removing the release blocker until the user responds. will add it back after confirming the bug. Feel free to add the blocker, if this is still needed.
I responded on that private mail. The char was created on Friday. I was able to login under that account on EVE Gate.
Cc: dharani@chromium.org
Labels: -Action-FeedbackNeeded
Status: Untriaged
Thanks for the update, I see the issue happening in Beta onwards. Current stable (M19) is fine though. I will bisect and update the bug soon.

@dharani, is this a stable blocker?
Labels: -Action-BisectNeeded
Owner: ----
I had to do a manual bisect between Stable (M19) and Beta (M20), this has been broken since 20.0.1105.0


Pavan did the bisect again and it actually started from 20.0.1100.0 build. Unfortunately, we couldn't do a tighter bisect.

Chrome:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=131936:132144&mode=html

Webkit:
http://trac.webkit.org/log?action=stop_on_copy&mode=stop_on_copy&rev=114017&stop_rev=113857&limit=600&verbose=on

Comment 14 by kareng@google.com, Jun 18 2012

Owner: mikelawther@chromium.org
Status: Assigned
my hunch is this is CSS?

Comment 15 by kareng@google.com, Jun 18 2012

Labels: ReleaseBlock-Stable

Comment 16 by ddrew@chromium.org, Jun 19 2012

Labels: OS-All
Cc: karen@chromium.org
This issue still happens in today's canary - 21.0.1180.0
Does this happen in Safari?  Has anyone tried bisecting nighties (http://nightly.webkit.org/) or using Tools/Scripts/bisect-builds (or git-bisect) to find a more specific revision?  if this turns out to be a WebKit trouble (which would very likely show up in Safari too), then we'll need a bugs.webkit.org issue to fix.

Comment 19 by le...@chromium.org, Jun 19 2012

Cc: jchaffraix@chromium.org eseidel@chromium.org
WB eseidel! I've verified that http://trac.webkit.org/changeset/113885/ causes this regression, but I don't feel comfortable recommending we simply roll that change out to fix this one. I'm trying to focus on remaining sub-pixel layout issues if someone else wants to take a look at this. Eric? Julien?

Comment 20 by le...@chromium.org, Jun 19 2012

Btw, dharani@ has credentials to the website for testing.
We need a reduction, to see what's actually changed.  Have we verified that the site looks correct in FireFox?  Do we know if our new behavior is actually incorrect?  (i.e. is this actually a "regression" or just a "behavior change"?)
OK.  I can confirm that https://gate.eveonline.com/Profile/etouchqa looks wrong in both Chrome dev channel, and WebKit nightly.  (Reconfirming what we already knew, that this is a WebKit issue.)

The page does not look "wrong" in Firefox.  I have not tested IE or Opera.
Here is a first-pass reduction.  This is still not small enough to really understand what's going on, but the process of reducing is pretty straightforward if someone would like to continue.  I just saved the page as "web page complete" from chrome, and started removing stuff until this point.

Note: this is not a good test case yet, as it's not easy to understand what it's supposed to do.  I reduced it to this by comparing our rendering with firefox's and kept removing stuff while they were still different.
eve.html
1.3 KB View Download
I agree that this is a change in behavior, but it's not yet clear to me that this is a regression, or that this should block any release.

I would not wait for a patch on this bug.  A reduction blocks further understanding of this issue.  Without understanding, we can't decide if this behavior change is intentional or not/good or not.
As mentioned previously, we'll eventually need to create a bugs.webkit.org bug, so that the appropriate webkit folks can be CC'd, etc.

I don't plan to look at this bug in chromium any further, but I'm happy to engage in a discussion on bugs.webkit.org if I'm CC'd (where the eventual fix will be made and landed).

Comment 26 by le...@chromium.org, Jun 19 2012

Labels: webkit-id-89515
Created a WK bug at dharani's request: https://bugs.webkit.org/show_bug.cgi?id=89515
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 19 2012

Labels: -webkit-id-89515 WebKit-ID-89515-NEW
https://bugs.webkit.org/show_bug.cgi?id=89515
Cc: jasneet@chromium.org
Jasneet to bisect this further.
Cc: -jchaffraix@chromium.org mikelawther@chromium.org
Owner: jchaffraix@chromium.org
Status: Started
Not sure if we need to bisect, we know it's a regression from http://trac.webkit.org/changeset/113885/ (see comment #19). However rolling this change is risky.
Sorry, I meant further reduce testcase provided by Eric in Comment 23. 
> Sorry, I meant further reduce testcase provided by Eric in Comment 23. 

OK, already done, see upstream bug. It looks like a combination of sizing, align=center and margin-left.
 Issue 130941  has been merged into this issue.
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 20 2012

Labels: -WebKit-ID-89515-NEW WebKit-ID-89515-RESOLVED
https://bugs.webkit.org/show_bug.cgi?id=89515
Status: Fixed
Manually checked and the page is not shifted to the left with new fix applied.
Labels: Merge-Merged
Merged in M20: http://trac.webkit.org/changeset/120871
Merged in M21: http://trac.webkit.org/changeset/120872
Project Member

Comment 36 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 37 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Area-Compat -Type-Regression -Area-WebKit -WebKit-Rendering -Mstone-20 Cr-Content Type-Bug-Regression Type-Compat M-20 Cr-Content-Rendering
Project Member

Comment 38 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 39 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink
Project Member

Comment 40 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content-Rendering Cr-Blink-Rendering
Labels: -Cr-Blink-Rendering Cr-Blink-Layout
Migrate from Cr-Blink-Rendering to Cr-Blink-Layout

Sign in to add a comment