New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 129456 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Not currently working on Chromium
Closed: Jun 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 134196

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

[Regression] [Presentation Mode] The html5-fullscreen-popup appears in the native presentation mode.

Project Member Reported by meh...@chromium.org, May 23 2012

Issue description

Chrome Version       : Chromium 21.0.1149.0 (138477)
OS version               :  Mac OS 10.6.8.
Behavior in Chrome for Windows: not tested

What steps will reproduce the problem?
1. press SHIFT-CMD-F to switch to he native presentation mode

What is the expected result?
To see not the html5-fullscreen-popup

What happens instead?
The html5-fullscreen-popup appears.

Started in Chrome 21.

Thanks and regards
Mehmet
 
html_fullscreen_popup.png
40.1 KB View Download

Comment 1 by rsesek@chromium.org, May 23 2012

Owner: scheib@chromium.org

Comment 2 by mark@chromium.org, May 24 2012

Status: Assigned
Because of your recent change.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=140028

------------------------------------------------------------------------
r140028 | scheib@chromium.org | Fri Jun 01 08:02:02 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=140028&r2=140027&pathrev=140028

Show no exit instruction on Mac when in Browser Fullscreen.

BUG= 129456 
TEST=On Mac enter Browser and Tab fullscreen, e.g. with cmd-shift-f and fullscreen button in http://media.tojicode.com/q3bsp/

Review URL: https://chromiumcodereview.appspot.com/10444050
------------------------------------------------------------------------
Status: Fixed
Status: Verified
Verified as fixed with Chrome 21.0.1161.0 canary on Mac OS 10.6.8.
Cc: vclarke@chromium.org anan...@chromium.org scheib@chromium.org
 Issue 130173  has been merged into this issue.

Comment 7 by meh...@chromium.org, Jun 16 2012

Cc: mark@chromium.org rsesek@chromium.org
Hi scheib@,

yesterday I had a chance to use Lion and I noticed, that the html5-fullscreen-popup also appears when I switch to Lions' native fullscreen mode with CTRL-SHIFT-F.

I think we should also remove the popup in this case or is this intentional ?

(+ Lion folks)
Bildschirmfoto 2012-06-16 um 10.23.08.png
105 KB View Download

Comment 8 by meh...@chromium.org, Jun 16 2012

Sorry, typo: I meant CTRL-CMD-F
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 21 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=143397

------------------------------------------------------------------------
r143397 | scheib@chromium.org | Thu Jun 21 09:59:43 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=143397&r2=143396&pathrev=143397
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.h?r1=143397&r2=143396&pathrev=143397
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=143397&r2=143396&pathrev=143397
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm?r1=143397&r2=143396&pathrev=143397

Simplify fullscreen exit bubble on mac; updating always creates one freshly.

This also moved the logic for when NOT to display the bubble to a single
location, fixing 129456.

BUG= 129456 
TEST=Manually, see bug.

Review URL: https://chromiumcodereview.appspot.com/10573003
------------------------------------------------------------------------
Labels: ReleaseBlock-Beta Merge-Requested
Merge Request:
r143397 | scheib@chromium.org | Thu Jun 21 09:59:43 PDT 2012
http://src.chromium.org/viewvc/chrome?view=rev&revision=143397

Status: Fixed
Blocking: chromium:134196
Labels: -Mstone-21 -ReleaseBlock-Beta -Merge-Requested
Merge will be batched up with:
https://code.google.com/p/chromium/issues/detail?id=134196
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 9 2012

Labels: merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145787

------------------------------------------------------------------------
r145787 | scheib@chromium.org | Mon Jul 09 16:35:40 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=145787&r2=145786&pathrev=145787
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm?r1=145787&r2=145786&pathrev=145787
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.h?r1=145787&r2=145786&pathrev=145787
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=145787&r2=145786&pathrev=145787

Merge 143397 - Simplify fullscreen exit bubble on mac; updating always creates one freshly.
Merge approved in roll-up issue  crbug.com/134196#c9 .

This also moved the logic for when NOT to display the bubble to a single
location, fixing 129456.

BUG= 129456 
TEST=Manually, see bug.

Review URL: https://chromiumcodereview.appspot.com/10573003

TBR=scheib@chromium.org
------------------------------------------------------------------------
Status: Verified
Verified in 21.0.1180.38 (Official Build 146252)
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Area-UI -Type-Regression -Feature-FullScreen Type-Bug-Regression Cr-UI Cr-UI-Browser-FullScreen

Sign in to add a comment