New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 129446 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Renderer crash in WebCore::DragData::modifiedKeyState

Project Member Reported by thestig@chromium.org, May 23 2012

Issue description

Version: 21.0.1145.0
OS: Linux
type: renderer

I don't see this on other platforms as of right now. I wonder if this is related to  bug 121569 ?

http://crash/reportdetail?reportid=f3054d4d33da0b9a

Thread 0 *CRASHED* ( SIGSEGV @ 0x00000038 )

0x7fc370eff1d4	 [chrome]	 - third_party/WebKit/Source/WebCore/platform/chromium/DragDataChromium.cpp:79]	WebCore::DragData::modifierKeyState
0x7fc36fd884a0	 [chrome]	 - third_party/WebKit/Source/WebCore/page/DragController.cpp:80]	WebCore::createMouseEvent
0x7fc36fd89401	 [chrome]	 - third_party/WebKit/Source/WebCore/page/DragController.cpp:191]	WebCore::DragController::dragExited
0x7fc36f709dbe	 [chrome]	 - third_party/WebKit/Source/WebKit/chromium/src/WebViewImpl.cpp:2684]	WebKit::WebViewImpl::dragTargetDragLeave
0x7fc370a8dd63	 [chrome]	 - ./ipc/ipc_message.h:158]	IPC::Message::Dispatch<RenderViewImpl, RenderViewImpl>
0x7fc370aa93c2	 [chrome]	 - content/renderer/render_view_impl.cc:811]	RenderViewImpl::OnMessageReceived
0x7fc36f557a92	 [chrome]	 - content/common/message_router.cc:46]	MessageRouter::RouteMessage
0x7fc36f4f84c5	 [chrome]	 - content/common/child_thread.cc:207]	ChildThread::OnMessageReceived
0x7fc36ef73755	 [chrome]	 - ipc/ipc_channel_proxy.cc:249]	IPC::ChannelProxy::Context::OnDispatchMessage
0x7fc36ef1bc48	 [chrome]	 - ./base/callback.h:272]	MessageLoop::RunTask
 
Cc: varunjain@chromium.org
ping?

Comment 2 by kareng@google.com, Jun 14 2012

Owner: dcheng@chromium.org
Status: Assigned
dcheng has the other bug so assigning to cross-check. and, yes, linux only.

Comment 3 by kareng@google.com, Jul 9 2012

Cc: kinuko@chromium.org
Labels: -Pri-2 Pri-1 Mstone-21
top crash. pls look. kinuko, might you know?

Comment 4 by kareng@google.com, Jul 9 2012

Cc: thestig@chromium.org
 Issue 136407  has been merged into this issue.

Comment 5 by kinuko@chromium.org, Jul 10 2012

This one surely looks similar to  bug 121569 .  Has this one started to crash only since M21?
I don't see this in 20.0.1132.x, but it happens frequently in 21.0.1145.0.

Comment 7 by kareng@google.com, Jul 10 2012

yes this started with 21.0.1145.0.

crashes
1	WebCore::DragData::modifierKeyState	22.0.1201.0 - just released.
56	WebCore::DragData::modifierKeyState	21.0.1180.4
98	WebCore::DragData::modifierKeyState	21.0.1180.15
27	WebCore::DragData::modifierKeyState	21.0.1180.11
18	WebCore::DragData::modifierKeyState	21.0.1180.0
71	WebCore::DragData::modifierKeyState	21.0.1171.0
68	WebCore::DragData::modifierKeyState	21.0.1163.0
30	WebCore::DragData::modifierKeyState	21.0.1155.2
78	WebCore::DragData::modifierKeyState	21.0.1145.0

Comment 8 by tony@chromium.org, Jul 10 2012

Owner: tony@chromium.org
Status: Started
I'm able to repro.  Open 2 Chrome windows and have them overlap.  Drag a file from the desktop quickly over both windows.  For some reason, we get an extra dragLeave message with no platform data.

Investigating and seeing if I can fix (ideally, by not sending the leave message twice).

Comment 9 by dcheng@chromium.org, Jul 10 2012

A potentially easier way is to change the PostTask in WebDragDestGtk::OnDragLeave to post a delayed task (I picked 10 seconds). I get a crash that seems to be consistent with what we're seeing in the crash reports.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 11 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=146016

------------------------------------------------------------------------
r146016 | tony@chromium.org | Tue Jul 10 17:58:41 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_drag_dest_gtk.cc?r1=146016&r2=146015&pathrev=146016

Fix a renderer crash when dragging quickly over tab contents.

We were expecting to receive GTK+ events in the following order:
  drag-motion
  drag-data-received
  drag-leave
but in some cases, we don't get the drag-data-received event (e.g.,
if the user is moving the mouse quickly). If that happens, don't send
a DragLeave event to the renderer since it doesn't think we're in a
drag.

BUG= 129446 
TEST=Open 2 chrome windows, quickly drag a file from the desktop over both
  windows. This should not crash.


Review URL: https://chromiumcodereview.appspot.com/10704144
------------------------------------------------------------------------

Comment 11 by tony@chromium.org, Jul 11 2012

Status: Fixed
Daniel said he would look into the OSX crash with the same stack.  I opened  issue 136834  for that.

Let's watch the next dev channel to see if the crash goes away.

Comment 12 by kareng@google.com, Jul 17 2012

Labels: Merge-Approved
pls merge to M21. 
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 17 2012

Labels: -Merge-Approved merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=147034

------------------------------------------------------------------------
r147034 | tony@chromium.org | Tue Jul 17 10:54:11 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/content/browser/web_contents/web_drag_dest_gtk.cc?r1=147034&r2=147033&pathrev=147034

Merge 146016 - Fix a renderer crash when dragging quickly over tab contents.

We were expecting to receive GTK+ events in the following order:
  drag-motion
  drag-data-received
  drag-leave
but in some cases, we don't get the drag-data-received event (e.g.,
if the user is moving the mouse quickly). If that happens, don't send
a DragLeave event to the renderer since it doesn't think we're in a
drag.

BUG= 129446 
TEST=Open 2 chrome windows, quickly drag a file from the desktop over both
  windows. This should not crash.


Review URL: https://chromiumcodereview.appspot.com/10704144

TBR=tony@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10782036
------------------------------------------------------------------------
Status: Verified
Was unable to reproduce the crash as per comment #8. Verified using 21.0.1180.49 (Official Build 147161) dev
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-WebKit -Mstone-21 Cr-Content M-21
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 6 2013

Labels: -Cr-Content Cr-Blink

Sign in to add a comment