New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 126333 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Render processes with swapped out views not exiting

Project Member Reported by creis@chromium.org, May 4 2012

Issue description

Version: 18.0.1025.168
OS: All

What steps will reproduce the problem?
1. Open a page on site A that does a window.open to create a second, related window.
2. Navigate both windows to site B.

What is the expected output? What do you see instead?

The process for site A should exit.  Instead, the process for site A stays alive, even though it is not displayed in the Chrome Task Manager.

This appears to be a bug in RenderProcessHostImpl::OnShutdownRequest.  It's looking to see whether there are other render_widget_hosts_ in the process before allowing the shutdown, but it isn't taking into account whether those might be swapped out RWHs.
 

Comment 1 by creis@chromium.org, May 4 2012

Status: Started
Looks like this was introduced in the fix for  issue 87176 :
http://codereview.chromium.org/9751001/

In that CL, I was hoping to prevent the process from exiting if we had started using it for a new page.  We only need to do that for views that aren't swapped out, so we can improve the fix to not count swapped out views.

Comment 2 by creis@chromium.org, May 5 2012

CL in progress, though I still need to add a test.
https://chromiumcodereview.appspot.com/10365027/
Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=136168

------------------------------------------------------------------------
r136168 | creis@chromium.org | Wed May 09 16:40:16 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=136168&r2=136167&pathrev=136168
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_manager_browsertest.cc?r1=136168&r2=136167&pathrev=136168

Allow renderers to shut down if they only contain swapped out views.

BUG= 126333 
TEST=See bug.


Review URL: https://chromiumcodereview.appspot.com/10365027
------------------------------------------------------------------------

Comment 4 by creis@chromium.org, May 10 2012

Status: Fixed

Comment 5 by creis@chromium.org, May 14 2012

Cc: dharani@chromium.org
Labels: Mstone-20 Merge-Requested
Dharani, would it be possible to merge this to M20?  It fixes a bug where renderer processes are kept alive after they're no longer used (until the tab is closed).  It's a simple CL with test, and I don't see any fallout on the crash server.
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 7 by bugdroid1@chromium.org, May 14 2012

Labels: merge-merged-1132
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=136912

------------------------------------------------------------------------
r136912 | creis@chromium.org | Mon May 14 11:07:47 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/content/browser/renderer_host/render_view_host_manager_browsertest.cc?r1=136912&r2=136911&pathrev=136912
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/content/browser/renderer_host/render_process_host_impl.cc?r1=136912&r2=136911&pathrev=136912

Merge 136168 - Allow renderers to shut down if they only contain swapped out views.

BUG= 126333 
TEST=See bug.


Review URL: https://chromiumcodereview.appspot.com/10365027

TBR=creis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10332146
------------------------------------------------------------------------

Comment 8 by k...@google.com, Aug 8 2012

Labels: -Merge-Approved
Remove merge approval label, this release has passed.

Comment 9 by k...@google.com, Aug 8 2012

Remove merge approval label, this release has passed.

Comment 10 by k...@google.com, Aug 8 2012

Remove merge approval label, this release has passed.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Feature-Navigation -Internals-Core -Mstone-20 M-20 Cr-Internals Cr-UI-Browser-Navigation Cr-Internals-Core
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment