New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 123162 link

Starred by 8 users

Issue metadata

Status: WontFix
Owner:
Email to this user bounced
Closed: Feb 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 131263
issue 131658
issue 132686
issue 132773
issue 132897

Blocking:
issue 124566
issue 129203

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Need 2x versions of all aura/webui assets

Project Member Reported by rbyers@chromium.org, Apr 12 2012

Issue description

Meta-bug to track ensuring we have 2x versions of ALL assets used in ChromeOS.

We'll also want 1.4x and 1.8x assets for Windows, but that should be tracked separately (although we'll generally want to do the work at the same time).

Note that once we have this we should add tooling to the build system to ensure developers get a warning if they try to add an asset with only a low-res version.
 
Labels: -Feature-Ash
Sub-label Feature-Ash-* is mutually exclusive with label Feature-Ash => Removing Feature-Ash
Labels: -Feature-Fletcher Hotlist-Link
Cc: pkotw...@chromium.org
Summary: Need 2x versions of all aura/webui assets
Hi, while this is marked as m21, we need this sooner (hopefully major assets right after m20 branch) to finish our DIP work for m21. Do we have ETA for this?
Mergedinto: 124566
Status: Duplicate
Mergedinto:
Status: Assigned
Let's keep it separate because this one is about assets, while the other one is about code change.
Blocking: 124566
Project Member

Comment 7 by bugdroid1@chromium.org, May 11 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=136576

------------------------------------------------------------------------
r136576 | oshima@chromium.org | Fri May 11 08:57:29 PDT 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_vertical_hover_top.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_vertical_hover_center.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_horizontal_hover_left.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_vertical_normal_top.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_horizontal_normal_center.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_horizontal_normal_center.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_horizontal_hover_right_fix.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_vertical_hover_bottom_fix.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_horizontal_hover_center.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_normal_edge.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_hover_edge.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_vertical_hover_bottom.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_vertical_normal_center.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_horizontal_pressed_right.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_vertical_pressed_center.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_vertical_normal_center.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_horizontal_normal_right.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_horizontal_pressed_left.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_vertical_hover_center.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_horizontal_hover_left.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_vertical_normal_top.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_vertical_pressed_top.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_horizontal_pressed_center.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_vertical_normal_bottom.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_vertical_normal_bottom.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_vertical_pressed_bottom.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_horizontal_hover_center.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_horizontal_hover_right.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_horizontal_hover_right.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_vertical_hover_bottom.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_horizontal_normal_left.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_horizontal_normal_left.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_base_horizontal_normal_right.png?r1=136576&r2=136575&pathrev=136576
 A http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/resources/touch_200/aura_scrollbar_thumb_vertical_hover_top.png?r1=136576&r2=136575&pathrev=136576

native theme images for touch UI at 2x scale

TBR=ben@chromium.org
BUG= 123162 
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10383126
------------------------------------------------------------------------

Comment 8 by rbyers@chromium.org, May 30 2012

Blocking: -124566 chromium:124566
Status: Started
Cc: roma@chromium.org
Roma is working on this.  Do we have any ETA on when we think we'll be done with all assets?  I'm assuming M21 isn't an option.  Roma, can you link to a spreadsheet or anything with the list of all the assets to be created, and which ones are done already?

Currently there are very limited set of png files for 2x. Here is the table I made last week.

https://docs.google.com/a/google.com/spreadsheet/ccc?key=0Ah_xtqaB0-v0dGt2ZXdqWmx5ZWRjMF9tUU1WZ2djWFE#gid=0

I'm expecting that most of resources will have both 1x and 2x images. Is this still true? Or there will be
many 1x resources that we need to scale on 2x environment?


Comment 11 by roma@google.com, Jun 1 2012

Currently there is no designer working on 2x WebUI assets. We have been focusing primarily on toolbar/tabstrip/omnibox stuff at the moment. This is a gap though, so I will figure out with Glen today who is going to start working on this, and update you asap.
FWIW, the table contains images for browser native UI only, and doesn't include WebUI resources.
The resources in these grd files has 1x no touch images only.

http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?revision=140023&view=markup
http://src.chromium.org/viewvc/chrome/trunk/src/ui/resources/ui_resources.grd?revision=139976&view=markup

There are more missing 2x files as some of resources in touch_2x.grd file points to 1x resources, but you get an idea how
many still missing.
Labels: Iteration-57
Started -> Iteration-57
I've added the missing WebUI assets to oshima's spreadsheet.
Labels: Iteration-58
All high priority M21 issues -> Iteration-58
I assume we're not getting all assets for M21, moving to M22.  roma@ - to what extent is your team on-track to get all these assets for M22 branch?

wiltzius/thakis: please file bugs for any specific noticeable omissions on Mac (eg. webui stuff) - hopefully we can get the most obvious ones in M21 still.

Note that flackr@ added the webui assets to the spreadsheet.

flackr@ you were also going to add the list of assets in WebKit, right?  Eg. html5 video player, ideally also all the assets used by the dev tools.

Labels: -MStone-21 Mstone-22
Blockedon: 132686
Blockedon: 131658
Blockedon: 131263
Blockedon: 132773
Blockedon: 132897
Blocking: chromium:129203
Highly visible missing webui assets:

* chrome icon on lower left on ntp
* web store icon on lower right on ntp
* chrome icon on chrome://chrome, and the "up to date" icon on the same site
* all the favicons for webui (blocked on  issue 130896 )
* checkbox image on chrome://settings
Labels: Iteration-59
Mstone 21 or 22, issue started => Iteration-59
Project Member

Comment 28 by bugdroid1@chromium.org, Jun 26 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=144305

------------------------------------------------------------------------
r144305 | thakis@chromium.org | Tue Jun 26 15:38:23 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=144305&r2=144304&pathrev=144305
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/2x/bookmarks_section_32.png?r1=144305&r2=144304&pathrev=144305
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search.png?r1=144305&r2=144304&pathrev=144305
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/2x?r1=144305&r2=144304&pathrev=144305
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/gritsettings/resource_ids?r1=144305&r2=144304&pathrev=144305
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/bookmark_manager_recent.png?r1=144305&r2=144304&pathrev=144305
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_recent.png?r1=144305&r2=144304&pathrev=144305
 M http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?r1=144305&r2=144304&pathrev=144305
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/component_extension_resources.grd?r1=144305&r2=144304&pathrev=144305
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search_rtl.png?r1=144305&r2=144304&pathrev=144305

Add HiDPI assets for the WebUI bookmarks manager.

Change common.gypi to pass scale_factors=2x to grit on Mac
(as a side effect, the close button on about:settings now looks
good).

Change bookmark_manager/main.html to type="chrome_html"
so that it gets the 2x image auto-treatment that's documented at
sites.google.com/a/chromium.org/dev/developers/design-documents/high-dpi-resources

The icon in the upper left corner of about:bookmarks looks good
with this change, but the tree icons don't yet because cr/ui/tree.js
needs js code changes to make HiDPI icons work.

BUG= 134372 , 123162 
TEST=Open bookmark manager. Almost all images look good in HiDPI.

Review URL: https://chromiumcodereview.appspot.com/10662039
------------------------------------------------------------------------
Owner: andrestubbe@chromium.org
Andre, I believe this is on your list currently.
Labels: -Feature-Ash-DIP Feature-HighDPI
Project Member

Comment 31 by bugdroid1@chromium.org, Jul 3 2012

Labels: merge-merged-1180
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=145336

------------------------------------------------------------------------
r145336 | thakis@chromium.org | Tue Jul 03 11:29:25 PDT 2012

Changed paths:
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search_rtl.png?r1=145336&r2=145335&pathrev=145336
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/bookmark_manager_recent.png?r1=145336&r2=145335&pathrev=145336
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_search.png?r1=145336&r2=145335&pathrev=145336
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/2x?r1=145336&r2=145335&pathrev=145336
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/tools/gritsettings/resource_ids?r1=145336&r2=145335&pathrev=145336
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/2x/bookmark_manager_recent.png?r1=145336&r2=145335&pathrev=145336
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/component_extension_resources.grd?r1=145336&r2=145335&pathrev=145336
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/build/common.gypi?r1=145336&r2=145335&pathrev=145336
 M http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/browser_resources.grd?r1=145336&r2=145335&pathrev=145336
 A http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/bookmark_manager/images/2x/bookmarks_section_32.png?r1=145336&r2=145335&pathrev=145336

Merge 144305 - Add HiDPI assets for the WebUI bookmarks manager.

Change common.gypi to pass scale_factors=2x to grit on Mac
(as a side effect, the close button on about:settings now looks
good).

Change bookmark_manager/main.html to type="chrome_html"
so that it gets the 2x image auto-treatment that's documented at
sites.google.com/a/chromium.org/dev/developers/design-documents/high-dpi-resources

The icon in the upper left corner of about:bookmarks looks good
with this change, but the tree icons don't yet because cr/ui/tree.js
needs js code changes to make HiDPI icons work.

BUG= 134372 , 123162 
TEST=Open bookmark manager. Almost all images look good in HiDPI.

Review URL: https://chromiumcodereview.appspot.com/10662039

TBR=thakis@chromium.org
------------------------------------------------------------------------
Labels: Iteration-60
I am seeing checkins for WebUI assets. Andre, are you providing them? What is the status of all WebUI assets?

Comment 33 by thakis@google.com, Jul 12 2012

I'm working with sgabriel to add hidpi webui stuff for Mac in  issue 134372 . Most of that applies to this bug here too.
Cc: girard@chromium.org rbyers@chromium.org
Status: Invalid
This meta bug no longer adds value, we've got specific bugs for specific areas of assets
Project Member

Comment 37 by bugdroid1@chromium.org, Jul 28 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=148881

------------------------------------------------------------------------
r148881 | thakis@chromium.org | 2012-07-28T04:03:57.105968Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=148881&r2=148880&pathrev=148881

HiDPI: Enable OTR NTP 2x assets.

BUG= 123162 
TBR=flackr

Review URL: https://chromiumcodereview.appspot.com/10820066
------------------------------------------------------------------------
Project Member

Comment 39 by bugdroid1@chromium.org, Oct 13 2012

Blocking: -chromium:124566 chromium:124566
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 40 by bugdroid1@chromium.org, Feb 27 2013

Labels: status_migrated
Status: WontFix
Project Member

Comment 41 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-UI -Mstone-22 -Feature-HighDPI Cr-UI Cr-UI-HighDPI M-22
Project Member

Comment 42 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment