New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 122946 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Apr 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Regression: Drag & Drop of downloads from a new window doesn't work

Reported by pcgo...@gmail.com, Apr 11 2012

Issue description

Chrome Version       : 20.0.1096.1
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) :

What steps will reproduce the problem?
1. Press CTRL+J to open a downloads tab
2. Drag tab to create a new window
3. Try to drag a downloaded file to the first window

What is the expected result?
Dragging the download works.

What happens instead?
No drag cursor.

Please provide any additional information below. Attach a screenshot if
possible.

It worked in the versions before 19.0.1084.1, crashed in 19.0.1084.1 (fixed by #120430 in 19.0.1084.9) and doesn't work now.

UserAgentString: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.6 (KHTML, like Gecko) Chrome/20.0.1096.1 Safari/536.6

 

Comment 1 by meh...@chromium.org, Apr 11 2012

Cc: varunjain@chromium.org
Labels: -Area-Undefined Area-UI Feature-Downloads Feature-TabStrip

Comment 2 by meh...@chromium.org, Apr 11 2012

Labels: -Feature-TabStrip
Aditya,

could you find regression window for this bug.
Cc: athigle@chromium.org
Cc: -athigle@chromium.org nduca@chromium.org e...@chromium.org anan...@chromium.org vivianz@chromium.org
Labels: -Type-Bug Type-Regression ReleaseBlock-Stable
Status: Untriaged
bisect script point to this changelist:
http://src.chromium.org/viewvc/chrome?view=rev&revision=129082

but does not look very related to me, it could be the webkit roll-in @r129004?



please note, the last bad chromium build from r129082, when try to drag file from download page, browser actually crashes. in chrome 20.0.1096.1, at least drag the file did not cause browser crash, it just lost the drag file from the download page functionality. 

can you share the stack trace if possible? I might have caused this from r129057
BTW, there was one crash related to my change filed here: http://code.google.com/p/chromium/issues/detail?id=120430

that I fixed in r129417 
what revision is 20.0.1096.1 running?
sure. it is at :http://crash.corp.google.com/reportdetail?reportid=3cf4f5b702ded185


0x5e9b1858	 [chrome.dll	 - widget.cc:695]	views::Widget::RunShellDrag(views::View *,ui::OSExchangeData const &,gfx::Point const &,int)
0x5dfc6652	 [chrome.dll	 - download_util.cc:405]	download_util::DragDownload(content::DownloadItem const *,gfx::Image *,HWND__ *)
0x5e10387f	 [chrome.dll	 - downloads_dom_handler.cc:275]	DownloadsDOMHandler::HandleDrag(base::ListValue const *)
0x5e611409	 [chrome.dll	 - bind_internal.h:1225]	base::internal::Invoker<1,base::internal::BindState<base::internal::RunnableAdapter<void ( options2::LanguageOptionsHandlerCommon::*)(base::ListValue const *)>,void (options2::LanguageOptionsHandlerCommon *,base::ListValue const *),void (base::internal::UnretainedWrapper<options2::LanguageOptionsHandlerCommon>)>,void (options2::LanguageOptionsHandlerCommon *,base::ListValue const *)>::Run(base::internal::BindStateBase *,base::ListValue const * const &)
0x5e482f60	 [chrome.dll	 - web_ui_impl.cc:96]	WebUIImpl::OnWebUISend(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &)
0x5e482741	 [chrome.dll	 - tuple.h:560]	DispatchToMethod<WebUIImpl,void ( WebUIImpl::*)(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &),GURL,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue>(WebUIImpl *,void ( WebUIImpl::*)(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &),Tuple3<GURL,std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue> const &)
0x5e482805	 [chrome.dll	 - view_messages.h:1643]	ViewHostMsg_WebUISend::Dispatch<WebUIImpl,WebUIImpl,void ( WebUIImpl::*)(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &)>(IPC::Message const *,WebUIImpl *,WebUIImpl *,void ( WebUIImpl::*)(GURL const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const &))
0x5e483425	 [chrome.dll	 - web_ui_impl.cc:73]	WebUIImpl::OnMessageReceived(IPC::Message const &)
0x5e4a0a16	 [chrome.dll	 - tab_contents.cc:518]	TabContents::OnMessageReceived(IPC::Message const &)
0x5e47bf6e	 [chrome.dll	 - render_view_host_impl.cc:837]	content::RenderViewHostImpl::OnMessageReceived(IPC::Message const &)
0x5e476c7a	 [chrome.dll	 - render_process_host_impl.cc:935]	RenderProcessHostImpl::OnMessageReceived(IPC::Message const &)
0x5def6d7c	 [chrome.dll	 - ipc_channel_proxy.cc:268]	IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const &)
0x5e16c8f2	 [chrome.dll	 - bind_internal.h:1254]	base::internal::Invoker<2,base::internal::BindState<base::internal::RunnableAdapter<void ( ColorChooserDialog::*)(ColorChooserDialog::ExecuteOpenParams const &)>,void (ColorChooserDialog *,ColorChooserDialog::ExecuteOpenParams const &),void (ColorChooserDialog *,ColorChooserDialog::ExecuteOpenParams)>,void (ColorChooserDialog *,ColorChooserDialog::ExecuteOpenParams const &)>::Run(base::internal::BindStateBase *)
0x5d5a19b7	 [chrome.dll	 - message_loop.cc:458]	MessageLoop::RunTask(base::PendingTask const &)
0x5d5a241a	 [chrome.dll	 - message_loop.cc:660]	MessageLoop::DoWork()
0x5d5cfe58	 [chrome.dll	 - message_pump_win.cc:203]	base::MessagePumpForUI::DoRunLoop()
0x5d5cfc36	 [chrome.dll	 - message_pump_win.cc:51]	base::MessagePumpWin::RunWithDispatcher(base::MessagePump::Delegate *,base::MessagePumpWin::Dispatcher *)
0x5d5a1505	 [chrome.dll	 - message_loop.cc:390]	MessageLoop::RunHandler()
0x5d5a26e8	 [chrome.dll	 - message_loop.cc:776]	MessageLoopForUI::RunWithDispatcher(base::MessagePumpWin::Dispatcher *)
0x5dff051a	 [chrome.dll	 - chrome_browser_main.cc:1863]	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x5e498a9f	 [chrome.dll	 - browser_main_loop.cc:452]	content::BrowserMainLoop::RunMainMessageLoopParts()
0x5e4b34f1	 [chrome.dll	 - browser_main_runner.cc:94]	`anonymous namespace'::BrowserMainRunnerImpl::Run()
0x5e474326	 [chrome.dll	 - browser_main.cc:21]	BrowserMain(content::MainFunctionParams const &)
0x5df68dbe	 [chrome.dll	 - content_main_runner.cc:282]	`anonymous namespace'::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x5df68e2b	 [chrome.dll	 - content_main_runner.cc:511]	`anonymous namespace'::ContentMainRunnerImpl::Run()
0x5df6679a	 [chrome.dll	 - content_main.cc:35]	content::ContentMain(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *,content::ContentMainDelegate *)
0x5dece90c	 [chrome.dll	 - chrome_main.cc:28]	ChromeMain
0x0041786f	 [chrome.exe	 - client_util.cc:424]	MainDllLoader::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *)
0x00417aea	 [chrome.exe	 - chrome_exe_main_win.cc:37]	RunChrome(HINSTANCE__ *)
0x00417b39	 [chrome.exe	 - chrome_exe_main_win.cc:48]	wWinMain
0x00435318	 [chrome.exe	 - crt0.c:263]	__tmainCRTStartup
0x772af13b	 [kernel32.dll	 + 0x0008f13b]	BaseThreadInitThunk
0x7784d818	 [ntdll.dll	 + 0x0007d818]	__RtlUserThreadStart
0x7784da2a	 [ntdll.dll	 + 0x0007da2a]	_RtlUserThreadStart

Comment 11 by dharani@google.com, Apr 11 2012

20.0.1096.1 is running chrome revision 131330

Comment 12 Deleted

yep, looks like the fix for  bug 120430  take away the functionality all together.
Owner: varunjain@chromium.org
Status: Assigned

Comment 16 by dharani@google.com, Apr 11 2012

Labels: Mstone-19
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 13 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=132127

------------------------------------------------------------------------
r132127 | varunjain@chromium.org | Thu Apr 12 19:15:55 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_util.cc?r1=132127&r2=132126&pathrev=132127

Fix downloads page drag/drop in WIN.

BUG= 122946 
TEST=dragging files on doanloads page works.


Review URL: http://codereview.chromium.org/10065027
------------------------------------------------------------------------
Labels: Merge-Requested
Labels: -Merge-Requested Merge-Approved
Status: Fixed
Project Member

Comment 21 by bugdroid1@chromium.org, Apr 16 2012

Labels: -Merge-Approved merge-merged-1084
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=132418

------------------------------------------------------------------------
r132418 | varunjain@chromium.org | Mon Apr 16 10:05:42 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1084/src/chrome/browser/download/download_util.cc?r1=132418&r2=132417&pathrev=132418

Merge 132127 - Fix downloads page drag/drop in WIN.

BUG= 122946 
TEST=dragging files on doanloads page works.


Review URL: http://codereview.chromium.org/10065027

TBR=varunjain@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9972017
------------------------------------------------------------------------
Status: Verified
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-UI -Feature-Downloads -Mstone-19 Type-Bug-Regression Cr-UI M-19 Cr-UI-Browser-Downloads
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment