New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 122850 link

Starred by 8 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

REGRESSION: Bookmark Manager - Bookmarks gets opened when tried to move in to a folder

Project Member Reported by pucchakayala@chromium.org, Apr 10 2012

Issue description

Chrome Version       : 20.0.1096.1
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:

What steps will reproduce the problem?
1. Launch Chrome and create few bookmarks under a bookmark folder - Folder 1
2. Create another sub folder - Folder 2 in Folder 1 and create some bookmarks.
3. Go to Bookmark Manager.
4. Try to drab few bookmarks from Folder 2 to Folder 1. Verify the behavior.

What is the expected result?
Bookmarks should be moved from Folder 2 to Folder 1

What happens instead?
Once the bookmark is dragged in to Folder 1, it gets opened in the new tab. But the bookmark is not moved actually.

Please provide any additional information below. Attach a screenshot if
possible.

 
Summary: Bookmark Manager - Bookmarks gets opened when tried to move in to a folder
This was working fine on last beta build 19.0.1084.15 & 19.0.1084.17
I will update the regression window soon.
Please find the bisect info below:

You are probably looking for build 130586.
WEBKIT CHANGELOG URL:
http://trac.webkit.org/log/trunk/?rev=113153&stop_rev=112724&verbose=on
CHANGELOG URL:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk
/src&range=130574:130586
Built at revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=130586

But the revision given above is not related to Bookmarks change.
Narrowed it further where we were not able to drag/drop bookmarks. Please find the bisect info related to web kit change

You are probably looking for build 129392.
WEBKIT CHANGELOG URL:
http://trac.webkit.org/log/trunk/?rev=112365&stop_rev=112327&verbose=on
CHANGELOG URL:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk
/src&range=129388:129392
Built at revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=129392
Labels: Mstone-20 ReleaseBlock-Beta

Comment 5 by dcheng@chromium.org, Apr 10 2012

It sounds like the bookmark manager isn't preventing the default event on drop. This was fixed recently in WebKit, so it should be pretty simple to fix the bookmark manager.

Comment 6 by est...@chromium.org, Apr 12 2012

Owner: est...@chromium.org
Status: Assigned

Comment 7 by dcheng@chromium.org, Apr 13 2012

Cc: arv@chromium.org zelidrag@chromium.org bshe@chromium.org pavanv@chromium.org jam@chromium.org
 Issue 123051  has been merged into this issue.

Comment 8 by dhw@chromium.org, Apr 13 2012

Labels: -Pri-2 Pri-1
Summary: REGRESSION: Bookmark Manager - Bookmarks gets opened when tried to move in to a folder
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 13 2012

Summary: REGRESSION: Bookmark Manager - Bookmarks gets opened when tried to move in to a folder
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=132203

------------------------------------------------------------------------
r132203 | estade@chromium.org | Fri Apr 13 10:14:45 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/bookmark_manager/js/main.js?r1=132203&r2=132202&pathrev=132203

fix dnd in bookmark manager

preventDefault in handleDrop, as suggested by arv

BUG= 122850 
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10065034
------------------------------------------------------------------------
Status: Fixed

Comment 11 by dhw@chromium.org, Apr 15 2012

 Issue 123547  has been merged into this issue.
 Issue 123450  has been merged into this issue.
This is verified and working fine on 20.0.1105.0 (Official Build 132547) - Win7, Mac osx 10.6.8 & Linux/Ubuntu 10.04
Status: Verified
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-Internals -Feature-Bookmarks -Mstone-20 Type-Bug-Regression Cr-UI-Browser-Bookmarks M-20 Cr-Internals
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment