New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 122130 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2012
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Leak in ExtensionAPI unit test

Reported by bradchen@chromium.org, Apr 5 2012

Issue description

log: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/7611

Introduced at r130866


Leak_DefinitelyLost
760 (552 direct, 208 indirect) bytes in 1 blocks are definitely lost in loss record 8,336 of 8,807
  operator new(unsigned long) (m_replacemalloc/vg_replace_malloc.c:1074)
  extensions::RulesRegistryService::RegisterDefaultRulesRegistries() (chrome/browser/extensions/api/declarative/rules_registry_service.cc:43)
  ExtensionSystemImpl::Shared::Init(bool) (chrome/browser/extensions/extension_system.cc:174)
  ExtensionSystemImpl::Init(bool) (chrome/browser/extensions/extension_system.cc:245)
  ProfileManager::DoFinalInitForServices(Profile*, bool) (chrome/browser/profiles/profile_manager.cc:643)
  ProfileManager::DoFinalInit(Profile*, bool) (chrome/browser/profiles/profile_manager.cc:624)
  ProfileManager::AddProfile(Profile*) (chrome/browser/profiles/profile_manager.cc:451)
  ProfileManager::GetProfile(FilePath const&) (chrome/browser/profiles/profile_manager.cc:390)
  ProfileManager::GetLastUsedProfile(FilePath const&) (chrome/browser/profiles/profile_manager.cc:309)
  (anonymous namespace)::CreateProfile(content::MainFunctionParams const&, FilePath const&, CommandLine const&) (chrome/browser/chrome_browser_main.cc:415)
  ChromeBrowserMainParts::PreMainMessageLoopRunImpl() (chrome/browser/chrome_browser_main.cc:1548)
  ChromeBrowserMainParts::PreMainMessageLoopRun() (chrome/browser/chrome_browser_main.cc:1390)
  content::BrowserMainLoop::CreateThreads() (content/browser/browser_main_loop.cc:432)
  (anonymous namespace)::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) (content/browser/browser_main_runner.cc:81)
  BrowserMain(content::MainFunctionParams const&) (content/browser/browser_main.cc:17)
  (anonymous namespace)::RunNamedProcessTypeMain(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) (content/app/content_main_runner.cc:282)
  (anonymous namespace)::ContentMainRunnerImpl::Run() (content/app/content_main_runner.cc:511)
  content::ContentMain(int, char const**, content::ContentMainDelegate*) (content/app/content_main.cc:35)
  ChromeMain (chrome/app/chrome_main.cc:32)
The report came from the `AutomatedUITestBase.ShowDownloads` test.
Suppression (error hash=#DC99645A583AE252#):
  For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   fun:_Znw*
   fun:_ZN10extensions20RulesRegistryService30RegisterDefaultRulesRegistriesEv
   fun:_ZN19ExtensionSystemImpl6Shared4InitEb
   fun:_ZN19ExtensionSystemImpl4InitEb
   fun:_ZN14ProfileManager22DoFinalInitForServicesEP7Profileb
   fun:_ZN14ProfileManager11DoFinalInitEP7Profileb
   fun:_ZN14ProfileManager10AddProfileEP7Profile
   fun:_ZN14ProfileManager10GetProfileERK8FilePath
   fun:_ZN14ProfileManager18GetLastUsedProfileERK8FilePath
   fun:_ZN12_GLOBAL__N_113CreateProfileERKN7content18MainFunctionParamsERK8FilePathRK11CommandLine
   fun:_ZN22ChromeBrowserMainParts25PreMainMessageLoopRunImplEv
   fun:_ZN22ChromeBrowserMainParts21PreMainMessageLoopRunEv
   fun:_ZN7content15BrowserMainLoop13CreateThreadsEv
   fun:_ZN12_GLOBAL__N_121BrowserMainRunnerImpl10InitializeERKN7content18MainFunctionParamsE
   fun:_Z11BrowserMainRKN7content18MainFunctionParamsE
   fun:_ZN12_GLOBAL__N_123RunNamedProcessTypeMainERKSsRKN7content18MainFunctionParamsEPNS2_19ContentMainDelegateE
   fun:_ZN12_GLOBAL__N_121ContentMainRunnerImpl3RunEv
   fun:_ZN7content11ContentMainEiPPKcPNS_19ContentMainDelegateE
   fun:ChromeMain
}


 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=130908

------------------------------------------------------------------------
r130908 | bradchen@google.com | Thu Apr 05 05:51:50 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/memcheck/suppressions.txt?r1=130908&r2=130907&pathrev=130908
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/heapcheck/suppressions.txt?r1=130908&r2=130907&pathrev=130908

Valgrind and Heapcheck suppressions for 122130 extension api leak

TBR=aa
BUG= 122130 
TEST=

Review URL: https://chromiumcodereview.appspot.com/10005009
------------------------------------------------------------------------
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=130915

------------------------------------------------------------------------
r130915 | bradchen@google.com | Thu Apr 05 07:12:29 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/memcheck/suppressions.txt?r1=130915&r2=130914&pathrev=130915

Fix/broaden suppression for 122130

TBR=aa
BUG= 122130 
TEST=

Review URL: https://chromiumcodereview.appspot.com/10007007
------------------------------------------------------------------------
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=130931

------------------------------------------------------------------------
r130931 | bradchen@google.com | Thu Apr 05 08:44:09 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/memcheck/suppressions.txt?r1=130931&r2=130930&pathrev=130931

Fix the suppression for 122130, 2nd attempt.

TBR=thestig
BUG= 122130 
TEST=

Review URL: https://chromiumcodereview.appspot.com/9949017
------------------------------------------------------------------------

Comment 4 by aa@chromium.org, Apr 5 2012

Owner: battre@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=132111

------------------------------------------------------------------------
r132111 | battre@chromium.org | Thu Apr 12 17:45:16 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_system.cc?r1=132111&r2=132110&pathrev=132111

Fix NULL pointer access

BUG= 122130 
TEST=no
TBR=mpcomplete@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10064003
------------------------------------------------------------------------

Comment 7 by battre@chromium.org, Apr 13 2012

Status: Fixed
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Stability-Memory -Stability-Valgrind Performance-Memory Performance-Valgrind
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 1 2013

Labels: -Performance-Memory Stability-Memory
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 1 2013

Labels: -Performance-Valgrind Stability-Valgrind

Sign in to add a comment