New issue
Advanced search Search tips

Issue 121584 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2012
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Chrome: Crash Report - history::TopSites::IsBlacklisted(GURL const &)

Project Member Reported by dharani@google.com, Apr 3 2012

Issue description

This doesn't seem to be regression. sky@ can you please glance at this? thanks!

Product: Chrome
Stack Signature: std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::alloc...
New Signature Label: std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,ba...
New Signature Hash: 4544cddd_5079edc8_f1c418df_91c2947d_a2996ce2

Report link: http://go/crash/reportdetail?reportid=73001ea45db9a074

Meta information:
Product Name: Chrome
Product Version: 20.0.1089.0
Report ID: 73001ea45db9a074
Report Time: 2012/04/03 00:16:03, Tue
Uptime: 3260 sec
Cumulative Uptime: 0 sec
OS Name: Windows NT
OS Version: 5.1.2600 Service Pack 3
CPU Architecture: x86
CPU Info: GenuineIntel family 6 model 23 stepping 10
ptype:browser


Thread 0 *CRASHED* ( EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000004 )

0x01cf50dd	 [chrome.dll	 - xtree:1264]	std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::Value *,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,base::Value *> >,0> >::_Lbound(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &)
0x01cf6c92	 [chrome.dll	 - xtree:987]	std::_Tree<std::_Tmap_traits<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::Value *,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,base::Value *> >,0> >::find(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &)
0x01d1219f	 [chrome.dll	 - values.cc:370	base::DictionaryValue::HasKey(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &)
0x020c107e	 [chrome.dll	 - top_sites.cc:421	history::TopSites::IsBlacklisted(GURL const &)
0x020c0d50	 [chrome.dll	 - top_sites.cc:738	history::TopSites::ApplyBlacklistAndPinnedURLs(std::vector<history::MostVisitedURL,std::allocator<history::MostVisitedURL> > const &,std::vector<history::MostVisitedURL,std::allocator<history::MostVisitedURL> > *)
0x020c0c28	 [chrome.dll	 - top_sites.cc:956	history::TopSites::ResetThreadSafeCache()
0x020bb550	 [chrome.dll	 - top_sites.cc:910	history::TopSites::SetTopSites(std::vector<history::MostVisitedURL,std::allocator<history::MostVisitedURL> > const &)
0x02a0a0cb	 [chrome.dll	 - top_sites.cc:1037	history::TopSites::OnTopSitesAvailableFromHistory(int,std::vector<history::MostVisitedURL,std::allocator<history::MostVisitedURL> >)
0x02a090c9	 [chrome.dll	 - bind_internal.h:246	base::internal::RunnableAdapter<void ( SuggestionsHandler::*)(int,std::vector<history::MostVisitedURL,std::allocator<history::MostVisitedURL> >)>::Run(SuggestionsHandler *,int const &,std::vector<history::MostVisitedURL,std::allocator<history::MostVisitedURL> > const &)
0x02a5c12a	 [chrome.dll	 - bind_internal.h:1317	base::internal::Invoker<1,base::internal::BindState<base::internal::RunnableAdapter<void ( history::TopSites::*)(int,std::vector<history::MostVisitedURL,std::allocator<history::MostVisitedURL> >)>,void (history::TopSites *,int,std::vector<history::MostVisitedURL,std::allocator<history::MostVisitedURL> >),void (base::internal::UnretainedWrapper<history::TopSites>)>,void (history::TopSites *,int,std::vector<history::MostVisitedURL,std::allocator<history::MostVisitedURL> >)>::Run(base::internal::BindStateBase *,int const &,std::vector<history::MostVisitedURL,std::allocator<history::MostVisitedURL> > const &)
0x0210e4a1	 [chrome.dll	 - bind_internal.h:896	base::internal::InvokeHelper<0,void,base::Callback<void (int,history::FaviconData)>,void (int const &,history::FaviconData const &)>::MakeItSo(base::Callback<void (int,history::FaviconData)>,int const &,history::FaviconData const &)
0x0210e281	 [chrome.dll	 - bind_internal.h:1254	base::internal::Invoker<2,base::internal::BindState<base::Callback<void (int,std::vector<webkit::forms::PasswordForm *,std::allocator<webkit::forms::PasswordForm *> > const &)>,void (int,std::vector<webkit::forms::PasswordForm *,std::allocator<webkit::forms::PasswordForm *> > const &),void (int,std::vector<webkit::forms::PasswordForm *,std::allocator<webkit::forms::PasswordForm *> >)>,void (int,std::vector<webkit::forms::PasswordForm *,std::allocator<webkit::forms::PasswordForm *> > const &)>::Run(base::internal::BindStateBase *)
0x020ba753	 [chrome.dll	 - cancelable_request.cc:132	CancelableRequestBase::ExecuteCallback(base::Callback<void (void)> const &)
0x01ce6cf8	 [chrome.dll	 - bind_internal.h:1254	base::internal::Invoker<2,base::internal::BindState<base::internal::RunnableAdapter<void ( GeolocationProvider::*)(GURL const &)>,void (GeolocationProvider *,GURL const &),void (base::internal::UnretainedWrapper<GeolocationProvider>,GURL)>,void (GeolocationProvider *,GURL const &)>::Run(base::internal::BindStateBase *)
0x01ce5d06	 [chrome.dll	 - message_loop.cc:457	MessageLoop::RunTask(base::PendingTask const &)
0x01ce4d4d	 [chrome.dll	 - message_loop.cc:646	MessageLoop::DoWork()
0x01e4634a	 [chrome.dll	 - message_pump_win.cc:203	base::MessagePumpForUI::DoRunLoop()
0x020af79c	 [chrome.dll	 - message_pump_win.cc:51	base::MessagePumpWin::RunWithDispatcher(base::MessagePump::Delegate *,base::MessagePumpWin::Dispatcher *)
0x01ce48b0	 [chrome.dll	 - message_loop.cc:389	MessageLoop::RunHandler()
0x020af753	 [chrome.dll	 - message_loop.cc:762	MessageLoopForUI::RunWithDispatcher(base::MessagePumpWin::Dispatcher *)
0x020af681	 [chrome.dll	 - chrome_browser_main.cc:1851	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x020af5df	 [chrome.dll	 - browser_main_loop.cc:452	content::BrowserMainLoop::RunMainMessageLoopParts()
0x020af4b8	 [chrome.dll	 - browser_main_runner.cc:94	`anonymous namespace'::BrowserMainRunnerImpl::Run()
0x01d59e01	 [chrome.dll	 - browser_main.cc:21	BrowserMain(content::MainFunctionParams const &)
0x01ce0e7b	 [chrome.dll	 - content_main_runner.cc:282	`anonymous namespace'::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *)
0x01ce0e00	 [chrome.dll	 - content_main_runner.cc:511	`anonymous namespace'::ContentMainRunnerImpl::Run()
0x01cd3634	 [chrome.dll	 - content_main.cc:35	content::ContentMain(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *,content::ContentMainDelegate *)
0x01cd35bf	 [chrome.dll	 - chrome_main.cc:28	ChromeMain
0x0042796f	 [chrome.exe	 - client_util.cc:424	MainDllLoader::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *)
0x00427bea	 [chrome.exe	 - chrome_exe_main_win.cc:37	RunChrome(HINSTANCE__ *)
0x00427c39	 [chrome.exe	 - chrome_exe_main_win.cc:48	wWinMain
0x004461e8	 [chrome.exe	 - crt0.c:263	__tmainCRTStartup
0x7c817066	 [kernel32.dll	 + 0x00017066]	BaseProcessStart
 

Comment 1 by sky@chromium.org, Apr 3 2012

Status: started
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=130833

------------------------------------------------------------------------
r130833 | sky@chromium.org | Wed Apr 04 20:44:23 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites.cc?r1=130833&r2=130832&pathrev=130833

Adds some debugging code to verify the dictionaries are non-null at
construction time. Based on some crashes it seems as though these can
be NULL later on.

BUG= 121584 
TEST=none
R=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9958134
------------------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 9 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=131354

------------------------------------------------------------------------
r131354 | sky@chromium.org | Mon Apr 09 07:18:38 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites.h?r1=131354&r2=131353&pathrev=131354
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites.cc?r1=131354&r2=131353&pathrev=131354

Changes TopSites to access blacklist from prefs when necessary. I'm
doing this in hopes of getting rid of a crash.

BUG= 121584 
TEST=none
R=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10019004
------------------------------------------------------------------------
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=131857

------------------------------------------------------------------------
r131857 | sky@chromium.org | Wed Apr 11 15:34:17 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/pyautolib/pyauto.py?r1=131857&r2=131856&pathrev=131857
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.h?r1=131857&r2=131856&pathrev=131857
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider.cc?r1=131857&r2=131856&pathrev=131857
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/most_visited_handler.cc?r1=131857&r2=131856&pathrev=131857
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_observers.cc?r1=131857&r2=131856&pathrev=131857
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites_unittest.cc?r1=131857&r2=131856&pathrev=131857
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=131857&r2=131856&pathrev=131857
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites.h?r1=131857&r2=131856&pathrev=131857
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/functional/ntp.py?r1=131857&r2=131856&pathrev=131857
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=131857&r2=131856&pathrev=131857
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/top_sites.cc?r1=131857&r2=131856&pathrev=131857

Removes pinning code from TopSites as we no longer need it.

BUG= 121584 , 122981 
TEST=none
R=brettw@chromium.org,nirnimesh@chromium.org,estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10050016
------------------------------------------------------------------------

Comment 6 by sky@chromium.org, Apr 13 2012

Status: Fixed
I don't see this in 20.0.1099.1. 131354 and 131857 seemed to have fixed it. YAY!
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Mstone-20 M-20 Cr-Internals
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment