New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 120358 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

REGRESSION: flash requires permissions

Reported by geki...@gmail.com, Mar 27 2012

Issue description

Chrome Version       : 19.0.1082.0, r129132 (not in canary)
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) : http://www.adobe.com/software/flash/about/
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:

What steps will reproduce the problem?
1. go to http://www.adobe.com/software/flash/about/
2. flash requires permissions although i is up to date and although i have enabled click to play and not clicked it

What is the expected result?
should work like in canary

What happens instead?
requires permissions

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.5 (KHTML, like Gecko) Chrome/19.0.1082.0 Safari/536.5


 

Comment 1 by geki...@gmail.com, Mar 27 2012

did more testing:
r128940 ok
r128957 bad

think it is r128949 "Move |requires_authorization| flag and |update_url| for plug-ins out of webkit::npapi::PluginGroup. It's now in PluginInstaller. BUG=none TEST=nope Review URL: http://codereview.chromium.org/9536013"
To clarify: the issue is with the new infobar popping up when "Click to Play" is selected for flash plugins which normally allows for elective click to activate.

Comment 3 by marja@chromium.org, Mar 27 2012

Cc: bauerb@chromium.org
bauerb, yours?

Comment 4 by bauerb@chromium.org, Mar 27 2012

Cc: -bauerb@chromium.org
Owner: bauerb@chromium.org
Status: Assigned

Comment 5 by geki...@gmail.com, Mar 27 2012

re comment #2: i tested it at morning and not sure, but i think i got the message also if i have set the settings to "enable/allow plugins"
Labels: -Type-Bug Type-Regression Mstone-19 ReleaseBlock-Beta
Labels: -OS-Windows OS-All
Labels: -Pri-2 -Area-Undefined Pri-1 Area-Internals pyauto_tests
This is causing a number of PyAuto tests to fail on all platforms:

flash.FlashTest.testFlashLoadsAfterKill
infobars.InfobarTest.testPluginCrashForMultiTabs
infobars.InfobarTest.testPluginCrashInfobar
flash.FlashTest.testCanLoadFlash
flash.FlashTest.testFlashIncognitoMode
flash.FlashTest.testFlashWithMultipleTabs
flash.FlashTest.testSingleFlashPluginProcess
plugins.PluginsTest.testBlockAllPlugins
plugins.PluginsTest.testBlockPluginException
youtube.YoutubeTest.testPlayerStatus
youtube.YoutubeTest.testPlayerBytes
youtube.YoutubeTest.testPlayerResolution
process_count.ProcessCountTest.testProcessCountCombination
process_count.ProcessCountTest.testProcessCountFlashProcess
Cc: dyu@chromium.org vclarke@chromium.org nirnimesh@chromium.org anan...@chromium.org
 Issue 120312  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 27 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=129252

------------------------------------------------------------------------
r129252 | bauerb@chromium.org | Tue Mar 27 13:06:57 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_finder.cc?r1=129252&r2=129251&pathrev=129252

Populate correct variable from plug-in information.


BUG= 120358 
TEST=see bug for manual test

Review URL: http://codereview.chromium.org/9866042
------------------------------------------------------------------------
Status: Fixed
Labels: Merge-Requested
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 28 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=129351

------------------------------------------------------------------------
r129351 | vclarke@google.com | Tue Mar 27 19:47:25 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/functional/PYAUTO_TESTS?r1=129351&r2=129350&pathrev=129351

Disable tests that fail because of Flash infobar.

Disabled tests:
flash.FlashTest.testCanLoadFlash
flash.FlashTest.testFlashIncognitoMode
flash.FlashTest.testFlashLoadsAfterKill
flash.FlashTest.testFlashWithMultipleTabs
flash.FlashTest.testSingleFlashPluginProcess
infobars.InfobarTest.testPluginCrashForMultiTabs
infobars.InfobarTest.testPluginCrashInfobar
plugins.PluginsTest.testBlockAllPlugins
plugins.PluginsTest.testBlockPluginException
process_count.ProcessCountTest.testProcessCountCombination
process_count.ProcessCountTest.testProcessCountFlashProcess
translate.TranslateTest.testSeveralLanguages
youtube.YoutubeTest.testPlayerBytes
youtube.YoutubeTest.testPlayerResolution
youtube.YoutubeTest.testPlayerStatus

BUG= 120358 
TEST=none

Review URL: http://codereview.chromium.org/9836121
------------------------------------------------------------------------

Comment 15 by geki...@gmail.com, Mar 28 2012

can confirm it's fixed in chromium, thank's for the fast work
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 28 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=129409

------------------------------------------------------------------------
r129409 | bauerb@chromium.org | Wed Mar 28 07:33:08 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/functional/PYAUTO_TESTS?r1=129409&r2=129408&pathrev=129409

Revert 129351 - Disable tests that fail because of Flash infobar.

The underlying issue has already been fixed.

Disabled tests:
flash.FlashTest.testCanLoadFlash
flash.FlashTest.testFlashIncognitoMode
flash.FlashTest.testFlashLoadsAfterKill
flash.FlashTest.testFlashWithMultipleTabs
flash.FlashTest.testSingleFlashPluginProcess
infobars.InfobarTest.testPluginCrashForMultiTabs
infobars.InfobarTest.testPluginCrashInfobar
plugins.PluginsTest.testBlockAllPlugins
plugins.PluginsTest.testBlockPluginException
process_count.ProcessCountTest.testProcessCountCombination
process_count.ProcessCountTest.testProcessCountFlashProcess
translate.TranslateTest.testSeveralLanguages
youtube.YoutubeTest.testPlayerBytes
youtube.YoutubeTest.testPlayerResolution
youtube.YoutubeTest.testPlayerStatus

BUG= 120358 
TEST=none

Original review URL: 

TBR=vclarke@google.com

Review URL: http://codereview.chromium.org/9791057
------------------------------------------------------------------------
Labels: -Merge-Requested
Labels: Merge-Requested
Owner: vclarke@chromium.org
Status: Assigned
Request merge of flash pyauto test re-enable to 1084 branch.

Comment 19 by laforge@google.com, Mar 30 2012

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 20 by bugdroid1@chromium.org, Mar 30 2012

Labels: merge-merged-1084
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=129982

------------------------------------------------------------------------
r129982 | kkania@chromium.org | Fri Mar 30 15:37:31 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1084/src/chrome/test/functional/PYAUTO_TESTS?r1=129982&r2=129981&pathrev=129982

Merge 129409 - Revert 129351 - Disable tests that fail because of Flash infobar.

The underlying issue has already been fixed.

Disabled tests:
flash.FlashTest.testCanLoadFlash
flash.FlashTest.testFlashIncognitoMode
flash.FlashTest.testFlashLoadsAfterKill
flash.FlashTest.testFlashWithMultipleTabs
flash.FlashTest.testSingleFlashPluginProcess
infobars.InfobarTest.testPluginCrashForMultiTabs
infobars.InfobarTest.testPluginCrashInfobar
plugins.PluginsTest.testBlockAllPlugins
plugins.PluginsTest.testBlockPluginException
process_count.ProcessCountTest.testProcessCountCombination
process_count.ProcessCountTest.testProcessCountFlashProcess
translate.TranslateTest.testSeveralLanguages
youtube.YoutubeTest.testPlayerBytes
youtube.YoutubeTest.testPlayerResolution
youtube.YoutubeTest.testPlayerStatus

BUG= 120358 
TEST=none

Original review URL: 

TBR=vclarke@google.com

Review URL: http://codereview.chromium.org/9791057

TBR=bauerb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9965039
------------------------------------------------------------------------
Owner: ----
Status: Fixed

Comment 22 by k...@google.com, Aug 8 2012

Labels: -Merge-Approved
Remove merge approval label, this release has passed.
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-Internals -Mstone-19 Type-Bug-Regression M-19 Cr-Internals
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment