New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 11952 link

Starred by 15 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Aug 2009
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

IME support is not implemented

Reported by vic.leiw...@gmail.com, May 14 2009

Issue description

Chrome Version       :   2.0.181 (181.0)
URLs (if applicable) :    www.google.com
Other browsers tested:  no problem
Add OK or FAIL after other browsers where you have tested this issue:
     Safari 4: OK
  Firefox 3.x: OK
         IE 7: OK
         IE 8: OK

What steps will reproduce the problem?
1. on Mac, use any chinese input method
2. open google.com or any websites
3. try to type chinese words.

What is the expected result?
show me a selection of words when i am typing

What happens instead?
I cant see the selection of words under the chinese input method.
instead, all words I entered is in english form. just like english input 
methods's result. 

Please provide any additional information below. Attach a screenshot if
possible.
Mac, 10.5.7


 
Picture 1
83.7 KB View Download

Comment 1 by xlyuan@chromium.org, May 14 2009

Labels: -OS-All OS-Mac

Comment 2 by xlyuan@chromium.org, May 14 2009

Labels: I18N

Comment 3 by hbono@chromium.org, May 15 2009

Labels: -Area-Misc Area-BrowserUI
Status: Available
Summary: IME support (Chinese input method doesnt work)
Thank you for your bug report and sorry for your inconvenience.
The current Chrome (on Mac) does not implement the NSTextInput interface, which is 
required for IME support. We would like to implement it as soon as possible.
Labels: -Pri-2 Pri-1 Mstone-MacBeta
Labels: releasenotes
Summary: IME support is not implemented
Because this doesn't sound Chinese-specific, I'm going to convert it into a general
"IME support is not implemented" tracking bug.  This is also a Mac OS known issue:
IME does not work for non-Roman text input.

Comment 6 by xlyuan@chromium.org, Jun 15 2009

 Issue 14085  has been merged into this issue.

Comment 7 by xlyuan@chromium.org, Jun 17 2009

 Issue 14234  has been merged into this issue.

Comment 8 by jrg@chromium.org, Jul 2 2009

Labels: -Mstone-MacBeta

Comment 9 by js...@chromium.org, Jul 13 2009

Hironori, do you think this can't make it for Mac beta? P1 and not in 'MacBeta' label 
seem contradictory to each other. 
Labels: Mstone-4

Comment 11 by js...@chromium.org, Jul 16 2009

Labels: -Mstone-4 Mstone-3
Adding back to Mstone3 based on Hironori's offline comment, according to which he 
has a patch pending review by Darin and this issue can be resolved at the same time as 
deadkey issue  (which is in the Mstone3 list) is fixed 

Comment 12 by js...@chromium.org, Jul 16 2009

Status: Started
Labels: -Mstone-3 Mstone-MacBeta
 Issue 17500  has been merged into this issue.

Comment 15 by jon@chromium.org, Jul 29 2009

Need at least support for Japanese for beta.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22262 

------------------------------------------------------------------------
r22262 | hbono@chromium.org | 2009-08-03 00:38:06 -0700 (Mon, 03 Aug 2009) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.h?r1=22262&r2=22261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_mac.mm?r1=22262&r2=22261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_web_keyboard_event.h?r1=22262&r2=22261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_web_keyboard_event_mac.mm?r1=22262&r2=22261
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebInputEvent.h?r1=22262&r2=22261
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/mac/WebInputEventFactory.h?r1=22262&r2=22261
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/mac/WebInputEventFactory.mm?r1=22262&r2=22261

Implement the NSTextInput protocol.

This change implements the NSTextInput protocol to integrate dead-keys and IME support into Mac Chromium.
Same as Linux, to improve compatibility with Windows Chrome, this change emulates IPC messages sent on Windows when we input characters to fix  Issue 11952  and  Issue 11981 .
Even though I notice we need more work for fixing edge cases (e.g. disabling IMEs on a password input) also on Mac, it is the good starting point. (Supporting edge-cases requires complicated code and it makes hard to review.)

BUG= 11952  "IME support is not implemented"
BUG= 11981  "Deadkeys do not work"
BUG= 16393  "Mac: Not able to insert any letter using "Special Characters" pallet"
TEST=Open a web page which contains an <input> form (e.g. <http://www.google.com/>), type a '[{' key and an 'A' key on a Canadian-French keyboard, and see a Latin character "U+00E2" is displayed in the <input> form.
TEST=Open a web page which contains an <input> form (e.g. <http://www.google.com/>), enable an Chinese Pinyin IME, type a 'W' key, type an 'O' key, and see a Chinese character is displayed in the <input> form.
TEST=Open a web page which contains a <textarea> form, type a return key, and see a new line is inserted.
Review URL: http://codereview.chromium.org/150206
------------------------------------------------------------------------

With version Chromium 3.0.197.0 (r22375) snapshot build, I confirmed that I can input 
Japanese. Many thanks!!

Comment 18 by Deleted ...@, Aug 4 2009

Latest r22378 works for me too, with Chinese input method, thanks verymuch :)
http://www.screencast.com/users/kcome/folders/Jing/media/a173c8ed-ac62-4083-8788-b6fcfaa5b74d
Labels: -releasenotes
Thanks ! Removing 'releasenotes'. 

Status: Fixed
Status: Verified
3.0.197.12 rev:22622.

 Issue 14234  has been merged into this issue.
Labels: -I18N bulkmove Feature-I18N
Chrome Version       :   2.0.181 (181.0)
URLs (if applicable) :    www.google.com
Other browsers tested:  no problem
Add OK or FAIL after other browsers where you have tested this issue:
     Safari 4: OK
  Firefox 3.x: OK
         IE 7: OK
         IE 8: OK

What steps will reproduce the problem?
1. on Mac, use any chinese input method
2. open google.com or any websites
3. try to type chinese words.

What is the expected result?
show me a selection of words when i am typing

What happens instead?
I cant see the selection of words under the chinese input method.
instead, all words I entered is in english form. just like english input 
methods's result. 

Please provide any additional information below. Attach a screenshot if
possible.
Mac, 10.5.7
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 13 2012

Blocking: -chromium:16393
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Feature-I18N Cr-UI-I18N
Project Member

Comment 26 by bugdroid1@chromium.org, Mar 20 2013

Labels: -Cr-UI-I18N Cr-UI-Internationalization

Sign in to add a comment