New issue
Advanced search Search tips

Issue 118960 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocking:
issue 118914

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

URLFetcher::Create calls in chrome/browser/translate/translate_manager.cc

Project Member Reported by battre@chromium.org, Mar 19 2012

Issue description

We are screening all URLFetcher::Create calls with regards to their cookie settings and picked you as a tenative owner for this because of your modifications in the vincinity of these calls. If you don't consider yourself as an appropriate owner, please feel free to reassign this bug.

Please see  issue 118914  for instructions on what needs to be done.

Please consider these files and close the bug once done:

- src/chrome/browser/translate/translate_manager.cc

Thank you very much.

 

Comment 1 by battre@chromium.org, Mar 19 2012

Blocking: 118914

Comment 2 by mad@google.com, Mar 20 2012

Status: Started
Checking with the server team...

Comment 3 by battre@chromium.org, Mar 20 2012

Awesome. Thanks a lot. Anthony asked me to point out that he won't be very open to changes next week. If you could finish this before, that would be fantastic.

Comment 4 by mad@google.com, Mar 21 2012

I have the code change ready, and I validated that it works...

Just waiting on confirmation from translate server stake holders...

Comment 5 by mad@google.com, Mar 28 2012

Finally got the OK with the condition of adding an hl=<UI Language> query param to the URL. Patch uploaded here: https://chromiumcodereview.appspot.com/9791078/
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=129577

------------------------------------------------------------------------
r129577 | mad@chromium.org | Wed Mar 28 21:41:11 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_manager.cc?r1=129577&r2=129576&pathrev=129577

Stop sending/saving cookies for translate server requests.

Add hl=<UI Language> query param instead.

BUG= 118960 
TEST=browsertest --gtest_filter=TranslateManagerTest.*


Review URL: http://codereview.chromium.org/9791078
------------------------------------------------------------------------

Comment 7 by battre@chromium.org, Mar 29 2012

Status: Fixed
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2012

Blocking: -chromium:118914 chromium:118914
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Feature-Privacy -Mstone-19 Cr-Privacy M-19 Cr-Internals
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment