New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 11896 link

Starred by 29 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Jun 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression
M-3

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Session history broken on various sites (e.g. iGoogle)

Reported by patrickb...@gmail.com, May 13 2009

Issue description

Chrome Version       : 2.0.180.0
URLs (if applicable) : http://www.google.at/ig?hl=en

What steps will reproduce the problem?
1. Open igoogle
2. Stay in igoogle tab and go to another page
3. Press the back button to go back to igoogle

What is the expected result?
Normal back forward navigation possible

What happens instead?
Once you are back in igoogle navigating with back/forward isn't possible 
anymore.
Forward button is inactive
Back button does nothing


This regressed in 2.0.180.0 for me.
Note: If you press the back/forward buttons very fast they work properly.
Win Vista x64
 
Labels: -Area-Misc Area-BrowserUI
Status: Untriaged
Summary: Backward navgiation thr button broken with igoogle
Confirmed on ToT (15958)

The backward navigation thr clicking on the arrow does not work after navigating to
igoogle page, though you can thr the drop-down list (click and hold on the arrow)

I believe we have a similar bug.

Comment 2 by glen@chromium.org, May 13 2009

Status: Available
FWIW, this seems to work the same on Chrome 1 and ToT -- it takes 3-4 "back" clicks to 
get to the previous page.  I don't think this is the intended behavior.

Both Firefox and Safari work as expected, though -- 1 "back" click will take the user 
to the previous page.
Status: Started

Comment 5 by jon@chromium.org, Jun 11 2009

Comment 6 by yuzo@chromium.org, Jun 15 2009

Sorry, I was on vacation.

I'll submit a fix shortly, after syncing and gcl try'ing.

Yuzo

Comment 7 by yuzo@chromium.org, Jun 15 2009

 Issue 14087  has been merged into this issue.
Labels: -Pri-2 Pri-1 Regression Mstone-3 ReleaseBlock-Stable
Summary: Session history broken on various sites (e.g. iGoogle)

Comment 9 by yuzo@chromium.org, Jun 15 2009

Status: Fixed
Sorry for the delay.

Patch submitted as r18373.

Yuzo
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=18373 

------------------------------------------------------------------------
r18373 | yuzo@chromium.org | 2009-06-15 01:20:17 -0700 (Mon, 15 Jun 2009) | 33 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.cc?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.h?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.cc?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.h?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_1.html?r1=18373&r2=18372
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_11.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_12.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_2.html?r1=18373&r2=18372
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_21.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_22.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_3.html?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_4.html?r1=18373&r2=18372
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/history_uitest.cc?r1=18373&r2=18372

Consider a redirect following user gesture as user-initiated in maintaining
navigation entries. Also, ignore redirect- or machine-initiated- new subframe
navigations.

The current code treats all redirects as machine-initiated in processing
navigation to a new page (to fix Bugs  9663  and  10531 ). This is not always
appropriate, because some sites, e.g., www.google.com/ig, use redirect to
implement user-initiated navigation ( Bug 11896 ).

This change assumes that a machine-initiated redirect happens within 300ms
since the last document load was completed, while  a user-initiated one
happens later.

This assumption is not always correct, e.g., a user may cause transition within
300ms. But I cannot think of any better ways to tell if a redirect is machine-
initiated or user-initiated.

I believe this change works good enough, at least better than the status quo.

Review URL: http://codereview.chromium.org/115919

TEST=Open http://www.hp.com and observe it redirects to
http://www.hp.com/#Product . Hit Back button and observe
the former URL is not visited. Open http://www.google.com/ig and
click tabs inside the page, and try hitting Back and Forward to see if the
navigation is right. Open http://www.google.com/codesearch, search for
something, click on a result item, and try hitting Back.

BUG= 11896 , 12820 




------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=18512 

------------------------------------------------------------------------
r18512 | laforge@chromium.org | 2009-06-16 12:07:10 -0700 (Tue, 16 Jun 2009) | 37 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.cc?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.h?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.cc?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.h?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_1.html?r1=18512&r2=18511
   D /trunk/src/chrome/test/data/History/history_length_test_page_11.html
   D /trunk/src/chrome/test/data/History/history_length_test_page_12.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_2.html?r1=18512&r2=18511
   D /trunk/src/chrome/test/data/History/history_length_test_page_21.html
   D /trunk/src/chrome/test/data/History/history_length_test_page_22.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_3.html?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_4.html?r1=18512&r2=18511
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/history_uitest.cc?r1=18512&r2=18511

Revert 18373 - Consider a redirect following user gesture as userinitiated in maintaining
navigation entries. Also, ignore redirect or machineinitiated new subframe
navigations.

The current code treats all redirects as machineinitiated in processing
navigation to a new page (to fix Bugs  9663  and  10531 ). This is not always
appropriate, because some sites, e.g., www.google.com/ig, use redirect to
implement userinitiated navigation ( Bug 11896 ).

This change assumes that a machineinitiated redirect happens within 300ms
since the last document load was completed, while  a userinitiated one
happens later.

This assumption is not always correct, e.g., a user may cause transition within
300ms. But I cannot think of any better ways to tell if a redirect is machine
initiated or userinitiated.

I believe this change works good enough, at least better than the status quo.

Review URL: http://codereview.chromium.org/115919

TEST=Open http://www.hp.com and observe it redirects to
http://www.hp.com/#Product . Hit Back button and observe
the former URL is not visited. Open http://www.google.com/ig and
click tabs inside the page, and try hitting Back and Forward to see if the
navigation is right. Open http://www.google.com/codesearch, search for
something, click on a result item, and try hitting Back.

BUG= 11896 , 12820 





TBR=yuzo@chromium.org

Review URL: http://codereview.chromium.org/125202
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=18522 

------------------------------------------------------------------------
r18522 | laforge@chromium.org | 2009-06-16 13:22:11 -0700 (Tue, 16 Jun 2009) | 41 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.cc?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.h?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.cc?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.h?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_1.html?r1=18522&r2=18521
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_11.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_12.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_2.html?r1=18522&r2=18521
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_21.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_22.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_3.html?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/History/history_length_test_page_4.html?r1=18522&r2=18521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/history_uitest.cc?r1=18522&r2=18521

Revert 18512 - Revert 18373  Consider a redirect following user gesture as userinitiated in maintaining
navigation entries. Also, ignore redirect or machineinitiated new subframe
navigations.

The current code treats all redirects as machineinitiated in processing
navigation to a new page (to fix Bugs  9663  and  10531 ). This is not always
appropriate, because some sites, e.g., www.google.com/ig, use redirect to
implement userinitiated navigation ( Bug 11896 ).

This change assumes that a machineinitiated redirect happens within 300ms
since the last document load was completed, while  a userinitiated one
happens later.

This assumption is not always correct, e.g., a user may cause transition within
300ms. But I cannot think of any better ways to tell if a redirect is machine
initiated or userinitiated.

I believe this change works good enough, at least better than the status quo.

Review URL: http://codereview.chromium.org/115919

TEST=Open http://www.hp.com and observe it redirects to
http://www.hp.com/#Product . Hit Back button and observe
the former URL is not visited. Open http://www.google.com/ig and
click tabs inside the page, and try hitting Back and Forward to see if the
navigation is right. Open http://www.google.com/codesearch, search for
something, click on a result item, and try hitting Back.

BUG= 11896 , 12820 





TBR=yuzo@chromium.org

Review URL: http://codereview.chromium.org/125202

TBR=laforge@chromium.org

Review URL: http://codereview.chromium.org/126221
------------------------------------------------------------------------

 Issue 12930  has been merged into this issue.
 Issue 12820  has been merged into this issue.
 Issue 16935  has been merged into this issue.
 Issue 17186  has been merged into this issue.
 Issue 13197  has been merged into this issue.
 Issue 13177  has been merged into this issue.
Labels: -Regression bulkmove Type-Regression
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-3 -Type-Regression Type-Bug-Regression M-3
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment