New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 118368 link

Starred by 50 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

REGRESSION: Chrome icon missing from Windows Task Manager and Alt+Tab list

Reported by phil.cav...@gmail.com, Mar 15 2012

Issue description

Chrome Version       : 19.0.1068.0 (Official Build 126342) dev-m
Using Windows XP 32-bit SP3

What steps will reproduce the problem?
1. Holding Alt and pressing Tab to show currently open windows

What is the expected result?
Chrome windows shown with Chrome icon

What happens instead?
Generic windows application icon (white box with blue title bar) shown
 
 Issue 119041  has been merged into this issue.
 Issue 119531  has been merged into this issue.
 Issue 118429  has been merged into this issue.
Cc: sail@chromium.org
Labels: -Area-Undefined Area-UI Feature-Browser
sail: Sorry to throw another bug your way, but is there any chance this may be related to the profile overlay on the Chrome App Icon?

Comment 5 by sail@chromium.org, Mar 22 2012

Could be, phil, do you have more than one chrome profile?

Comment 6 by sail@chromium.org, Mar 23 2012

Cc: cpu@chromium.org
This seems similar to  bug 106629  except that bug had a different icon.
I only have one Chrome profile, but it appears to have been fixed (now on version 19.0.1077.3 (Official Build 128359) dev-m)

Comment 8 by mba...@gmail.com, Mar 26 2012

Hi, the bug seems to be fixed, thanks to all the developers.

Chrome: 19.0.1077.3 (Build ufficiale 128359) dev-m

Marco.

Comment 9 by sail@chromium.org, Mar 26 2012

Cc: robertshield@chromium.org
Status: Fixed
Cool, thanks for the feedback.
+robertshield in case this was a install issue.
 Issue 120052  has been merged into this issue.
Seems to be fixed! Thanks!

Comment 12 by msil...@silano.net, Mar 30 2012

Back again with 19.0.1084.1 dev-m....

Comment 13 by mba...@gmail.com, Mar 30 2012

Chrome: 19.0.1084.1 (Build ufficiale 129459) dev-m
AND: 19.0.1085.0 (Build ufficiale 129582) canary
Same environment (XPSP3 32bit,fully patched, etc)

The bug is back (regression?).
I can confirm this bug is present on 19.0.1084.1. I'm on Windows XP. Standalone chrome "application shortcuts" (options > tools > create application shortcut...) show the correct icon, as well as the taskbar icon for the main chrome app. I'm only getting a "generic windows icon" in the alt-tab list.
Confirmed in Win7 also
Untitled.png
38.5 KB View Download

Comment 16 by tobi...@gmail.com, Apr 2 2012

Bump.

Not Fixed on Win7
19.0.1084.1
bug.PNG
14.8 KB View Download

Comment 17 by gene...@gmail.com, Apr 4 2012

Still a problem with 19.0.1084.9 on Win7 64-bit
Fixed for me with Chrome 19.0.1084.9 dev-m on Win7 32-bit

Comment 19 by mba...@gmail.com, Apr 4 2012

Same Version as comment 18... on XPSP3,32bit, bug still present.
...also in Canary build: 20.0.1091.0.

Comment 20 by Deleted ...@, Apr 4 2012

I have the same issue on WinXP 32 bit with Chrome 19.0.1084.9 dev-m
As I said in comment #18 it was fixed for me with Chrome 19.0.1084.9 but since last update (19.0.1084.15), the bug is back   :(
Chrome 19.0.1084.9 Windows 7 x64 SP1, bug is back.

Comment 23 by sail@chromium.org, Apr 7 2012

Cc: ben@chromium.org asvitk...@chromium.org
Owner: sail@chromium.org
Status: Assigned
I can reproduce this on Canary today.

Revision 130433 is good and 130448 is bad.

The problem could be either r130442 or r130448.

Comment 24 by dhw@chromium.org, Apr 7 2012

Labels: -Type-Bug -Pri-2 Type-Regression Pri-1 Feature-OSIntegration OS-Windows
Summary: REGRESSION: Alt+Tab icon missing

Comment 25 by dhw@chromium.org, Apr 7 2012

Cc: pavanv@chromium.org thakis@chromium.org dharani@chromium.org
 Issue 118167  has been merged into this issue.

Comment 26 by dhw@chromium.org, Apr 7 2012

Summary: REGRESSION: Chrome icon missing from Windows Task Manager and Alt+Tab list
laforge had previously marked dup'd  Issue 118167  as ReleaseBlock-Stable, Mstone-19.  Keep that?
Labels: ReleaseBlock-Stable Mstone-19
better safe than sorry

Comment 28 by sail@chromium.org, Apr 9 2012

Owner: asvitk...@chromium.org
Reverting r130448 fixed the bug for me. Over to asvitkine for the fix.
Owner: sail@chromium.org
How can this be a M19 stable blocker when r129376 was the branch point? Clearly r130448 was after the branch point, so it couldn't have broken something in M19...

Or am I misunderstanding this? Assigning back to sail@ for clarification... (Please assign back if r130448 is somehow present in M19 and I'm just confused...)

Comment 30 by sail@chromium.org, Apr 9 2012

Owner: asvitk...@chromium.org
don't know

I'm on trunk and see this bug. Revert and don't see this bug.
Leads me to think you should own this bug.
If you have questions try IMing laforge.
Hmm, I am still seeing the issue after reverting r130448.

Perhaps r130448 is not the cause?

I'll try doing a non-components build in case that makes a difference.
switch.png
10.0 KB View Download
Running bisect-builds.py myself does give me the same range of r130432-r130457.

Now waiting to build non-components to check if reverting r130448
there fixes it (since it didn't under components). If it doesn't,
perhaps it's something else in that range.
I can also confirm that the the current M19 beta does have the issue
and that the r130448 change is _not_ present on the 1084 branch.

So either: 130448 is not responsible, or 130448 is responsible for the
regression in M20 and another bug is responsible for the regression in
M19.

On Tue, Apr 10, 2012 at 11:16 AM, Alexei Svitkine
<asvitkine@chromium.org> wrote:
Looking at 19 official builds, I can confirm the problem there started between 1081.2 and 1082.0.
1081 corresponds to r128864 and 1082 to r129143, so the M19 regression is somewhere between that range.

Comment 37 by laforge@google.com, Apr 10 2012

Labels: -ReleaseBlock-Stable -Mstone-19 Mstone-20
I'm not seeing this issue in 19.0.1084.15 (Beta).  Removing blocker status and punting to M20 to continue investigation.
I finally was able to reproduce what Sailesh was seeing (where reverting r130448 fixed the issue). If I started with a clean profile, then indeed with r130448, the issue was present but with r130448 reverted, the issue was gone.

With an existing profile, reverting r130448 didn't fix the issue.

From the above, I can conclude that r130448 did indeed introduce a cause of the bug, but there is another cause that doesn't always trigger (and was only triggering when using my non-clean profile).

I'm working on a fix for the issue caused by r130448, but don't yet know the source of the second bug.

Comment 39 by sail@chromium.org, Apr 10 2012

Sweet. Thanks for digging into it Alexei!

Comment 40 by dbloch@google.com, Apr 10 2012

FYI.  In #38 lafo...@google.com says he doesn't see this issue in 19.0.1084.15 (Beta).

I'm running 19.0.1084.15 (Official Build 130829) dev-m, and I still see it.
Labels: -Mstone-20 Mstone-19 ReleaseBlock-Stable
I also saw it on beta. Re-adding labels. :(

It's likely the second cause of this bug that I mentioned in comment 38, which is profile-specific...
But the good news is that my fix actually fixed both causes (I've confirmed it fixes the issue on the M19 branch).

CL here:

http://codereview.chromium.org/10031045/
Project Member

Comment 43 by bugdroid1@chromium.org, Apr 10 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=131673

------------------------------------------------------------------------
r131673 | asvitkine@chromium.org | Tue Apr 10 16:33:03 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/win/window_impl.cc?r1=131673&r2=131672&pathrev=131673
 M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/win/window_impl.h?r1=131673&r2=131672&pathrev=131673

Make WindowImpl take into account the icon in the class registrar.

This fixes the bug where an incorrect icon was being
shown in the Windows Task Manager and Task Switcher.

The problem was that the ClassRegistrar was re-using
window classes between different windows, but its
lookup function was not taking into account the icon.

This caused the main Chrome window to take on the
class registered by SingletonHwnd, which did not have
an icon set.

BUG= 118368 ,  117687 
TEST=Launch Chrome and check that Chrome's icon
looks correct in the Task Manager and Task Switcher.

Review URL: http://codereview.chromium.org/10031045
------------------------------------------------------------------------

Comment 44 by armi...@gmail.com, Apr 11 2012

i am using win XP xp3 and chrom 19.0.1084.15 beta-m
still have the issue, 

Labels: Merge-Requested
Labels: -Merge-Requested Merge-Approved

Comment 47 Deleted

Labels: -Merge-Approved Merge-Merged
Status: Fixed
Project Member

Comment 49 by bugdroid1@chromium.org, Apr 11 2012

Labels: merge-merged-1084
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=131756

------------------------------------------------------------------------
r131756 | asvitkine@chromium.org | Wed Apr 11 06:33:26 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1084/src/ui/base/win/window_impl.cc?r1=131756&r2=131755&pathrev=131756
 M http://src.chromium.org/viewvc/chrome/branches/1084/src/ui/base/win/window_impl.h?r1=131756&r2=131755&pathrev=131756

Merge 131673 - Make WindowImpl take into account the icon in the class registrar.

This fixes the bug where an incorrect icon was being
shown in the Windows Task Manager and Task Switcher.

The problem was that the ClassRegistrar was re-using
window classes between different windows, but its
lookup function was not taking into account the icon.

This caused the main Chrome window to take on the
class registered by SingletonHwnd, which did not have
an icon set.

BUG= 118368 ,  117687 
TEST=Launch Chrome and check that Chrome's icon
looks correct in the Task Manager and Task Switcher.

Review URL: http://codereview.chromium.org/10031045

TBR=asvitkine@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10059001
------------------------------------------------------------------------

Comment 50 by dhw@chromium.org, Apr 11 2012

 Issue 122941  has been merged into this issue.

Comment 51 by dhw@chromium.org, Apr 11 2012

 Issue 118186  has been merged into this issue.
Issue still present on 19.0.1084.15 beta-m (Win7)

Comment 53 by ratsu...@gmail.com, Apr 12 2012

Still can repro in latest dev(20.0.1096.1)....

Comment 54 by dharani@google.com, Apr 12 2012

Please note that the fix isn't landed in dev (20.0.1096.1) and beta(19.0.1084.15) yet. The latest canary should have fixed it.

Comment 55 by krtul...@gmail.com, Apr 12 2012

Please note that the latest Canary is 20.0.1097.0 built from r131535.

The above fix in Comment 43 was submitted to ToT in r131673.

So Canary(20.0.1097.0) will not have the fix either :(

Comment 56 by dharani@google.com, Apr 12 2012

krtulmay@: yes, that's right. I'll be pushing out 20.0.1099.1 shortly and will have the fix for sure.

Comment 57 by dhw@chromium.org, Apr 13 2012

 Issue 121984  has been merged into this issue.
Looks fine for me now in 19.0.1084.24 beta-m.  Thanks!
Status: Verified
verified that the icon is displayed in Windows task manager and Alt+Tab list as well on Win7 using 20.0.1105.0 (dev)

Comment 60 by dhw@chromium.org, Apr 25 2012

 Issue 125037  has been merged into this issue.

Comment 61 by mhm@chromium.org, Aug 7 2012

@pananv - These couple days I am having this issue on version 21.0.1180.60 using Windows 2008 Server R2. I see the icon in Alt+Tab list but not in the Task Bar, it is completely missing. Should be reopened?
Please file a new bug.
Project Member

Comment 63 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 64 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-UI -Feature-Browser -Feature-OSIntegration -Mstone-19 Type-Bug-Regression Cr-UI-OSIntegration M-19 Cr-UI Cr-UI-Browser-Core
Project Member

Comment 65 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Components: -UI>OSIntegration Internals>PlatformIntegration

Sign in to add a comment