New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 117916 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Mar 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 113065

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Flash videos turn white on mac when running with --disable-composited-core-animation-plugins

Project Member Reported by vangelis@google.com, Mar 12 2012

Issue description



What steps will reproduce the problem?
1. Start chrome with --disable-composited-core-animation-plugins
2. Open any Flash-based YouTube video such as http://www.youtube.com/watch?v=W9cHfhx9z9M&feature=context&context=G2e4b1b0RVAAAAAAAAAw


What is the expected output? What do you see instead?
The video doesn't play.  In its place there is a white rectangle.

Bisected down to:

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=118158:118173

which includes:
http://trac.webkit.org/log/?action=stop_on_copy&mode=stop_on_copy&rev=105305&stop_rev=105229&limit=100

Unfortunately the flag has the same effect in the M18 branch which means that we cannot easily turn off CA plugin support if needed.

 

Comment 1 by vangelis@google.com, Mar 12 2012

Interestingly enough, other flash content seems to work.  Not sure what's special about youtube videos.

Comment 2 by ronw...@volus.net, Mar 13 2012

Getting the same behavior on Hulu
(18.0.1025.56 beta, OS X 10.6.8)

Comment 3 by vangelis@google.com, Mar 13 2012

I'm pretty sure it this CL that broke it:
http://src.chromium.org/viewvc/chrome?view=rev&revision=118172

WebPluginDelegateProxy::OnAcceleratedSurfaceBuffersSwapped() uses a surface_id.  That id never gets registered with the GpuSurfaceTracker so we're not able to get a handle from it.  By the time we get to AcceleratedSurfaceContainerMac::set_was_painted_to() the surface_handle is zero. 

Unfortunately I don't quite grok the code enough to fix it.  piman, any ideas for a quick fix? 


Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2012

Labels: merge-merged-1025_52
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=126312

------------------------------------------------------------------------
r126312 | vangelis@google.com | Mon Mar 12 19:37:07 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025_52/src/content/plugin/webplugin_accelerated_surface_proxy_mac.cc?r1=126312&r2=126311&pathrev=126312
 M http://src.chromium.org/viewvc/chrome/branches/1025_52/src/webkit/plugins/npapi/plugin_host.cc?r1=126312&r2=126311&pathrev=126312

Re-enabling support for compositing core animation plugins as disabling them currently leaves Flash in a non-functional state.  Please see: http://code.google.com/p/chromium/issues/detail?id=117916


Revert 125981 - Disable support for composited core animation plugins on the mac to
determine whether it helps with memory bloat
TBR=kbr@google.com
Review URL: https://chromiumcodereview.appspot.com/9664031

TBR=vangelis@google.com
Review URL: https://chromiumcodereview.appspot.com/9696026
------------------------------------------------------------------------

Comment 5 by piman@chromium.org, Mar 13 2012

I think the fix is trivial.
I don't have a mac to test at hand, but basically r118172 did a bit of renaming of fields in the GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params, but that structure is also used in that mac-only path, and that was missed in the renaming, so we were just setting the wrong field. https://chromiumcodereview.appspot.com/9693031 fixes that - and restores some naming consistency: that "surface_id" #3 refers to is not a GpuSurfaceTracker-type surface id, it's a handle to an io surface, which goes into the surface_handle field.

Comment 6 by vangelis@google.com, Mar 13 2012

Wow, thanks, Antoine. I looked at this code over and over but couldn't figure out where the surface id was getting lost.  I figured the naming wasn't consistent but I couldn't see where we failed to pass the id .  I can try your patch tomorrow. 

Cc: vandanashah@chromium.org arsids@chromium.org ranavdk@chromium.org gailh@chromium.org jayakrishnat@chromium.org
Labels: GoogleFeedback

Chrome version: 18.0.1025.56
20+ users have reported this issue today in 'GoogleFeedback'.

Users have informed that any flash based video, including Youtube loose the ability to display, instead it shows white box in place of the video. 

Few users specified that it works fine in other browsers like Safari or Firefox. Users are able to hear the audio but not the video.

For more details, refer the user reports below:
http://goto.google.com/148024911
http://goto.google.com/213099073
http://goto.google.com/179998144
http://goto.google.com/179932459
http://goto.google.com/179818404

For further more user reports, refer the below cluster URL:
http://goto.google.com/c2233809
Blocking: 113065
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 14 2012

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=126560

------------------------------------------------------------------------
r126560 | piman@chromium.org | Tue Mar 13 21:24:32 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/webplugin_delegate_proxy.cc?r1=126560&r2=126559&pathrev=126560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_impl.h?r1=126560&r2=126559&pathrev=126560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=126560&r2=126559&pathrev=126560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_mac.cc?r1=126560&r2=126559&pathrev=126560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/plugin/webplugin_proxy.cc?r1=126560&r2=126559&pathrev=126560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/plugin_messages.h?r1=126560&r2=126559&pathrev=126560
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=126560&r2=126559&pathrev=126560

mac: fix flash videos with --disable-composited-core-animation-plugins

http://codereview.chromium.org/9194005 Missed one renaming. This fixes it.


BUG= 117916 
TEST=chrome --disable-composited-core-animation-plugins, load youtube videos


Review URL: http://codereview.chromium.org/9693031
------------------------------------------------------------------------
Verified that piman's patch fixes the issue at ToT/Canary.  Karen, we should probably merge this to M18, or at least consider it if we want to disable compositing for plugins.

Labels: Merge-Requested
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 21 2012

Labels: merge-merged-1025
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=127851

------------------------------------------------------------------------
r127851 | vangelis@google.com | Tue Mar 20 17:50:08 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/content/browser/renderer_host/render_widget_host_mac.cc?r1=127851&r2=127850&pathrev=127851
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/content/browser/renderer_host/render_widget_host.h?r1=127851&r2=127850&pathrev=127851
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/content/renderer/webplugin_delegate_proxy.cc?r1=127851&r2=127850&pathrev=127851
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/content/plugin/webplugin_proxy.cc?r1=127851&r2=127850&pathrev=127851
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/content/common/view_messages.h?r1=127851&r2=127850&pathrev=127851
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/content/common/plugin_messages.h?r1=127851&r2=127850&pathrev=127851
 M http://src.chromium.org/viewvc/chrome/branches/1025/src/content/renderer/render_view_impl.cc?r1=127851&r2=127850&pathrev=127851

Merging trunk rev 126560

mac: fix flash videos with --disable-composited-core-animation-plugins

http://codereview.chromium.org/9194005 Missed one renaming. This fixes it.


BUG= 117916 
TEST=chrome --disable-composited-core-animation-plugins, load youtube videos

TBR=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9801001
------------------------------------------------------------------------
Labels: -Merge-Requested Merge-Merged
piman's fix merged to M18 branch at rev 127851. 

Comment 14 by kareng@google.com, Mar 22 2012

It's ok to remove blocker on this since we turned off right?
Status: Fixed
It's now fixed in both ToT and the M18 branch.

Blocking: chromium:113065
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 13 2012

Blocking: -chromium:113065
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Mstone-18 M-18 Cr-Internals
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment