New issue
Advanced search Search tips

Issue 117720 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: May 2012
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Blocking:
issue 127250

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

In Incognito mode, saved passwords should be autofilled once the username is entered.

Reported by innatere...@gmail.com, Mar 11 2012

Issue description

Chrome Version       : 19.0.1065.0
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) : Any websites you have a password remembered by Chrome

What steps will reproduce the problem?
1.Open an incognito window, navigating to a site which you have a password remembered by Chrome.
2.Type in a correct username.
3.Tap Tab key.

What is the expected result?
The corresponding password automatically filled up.

What happens instead?
Nothing happens besides normal Tab key behavior.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.3 (KHTML, like Gecko) Chrome/19.0.1065.0 Safari/536.3

I am unable to find whether this is the latest intention of the behavior. In the past username and password were automatically filled up like in normal windows. Then you decided to hold off password until user types in correct username. Now the function completely gone in incognito windows.
 
Labels: -Area-Undefined Area-UI Feature-Autofill
From a privacy perspective I would favor disabling autofill in incognito mode as it may fill data accidentally. If one wants to use autofill, using a second profile is probably a better solution.
I have learned a few times that incognito mode is not designed to be a sort of guest mode, e.g.  issue 72865 , and is most likely to be used by the owner him/herself, though some of you may want to against that.
Nonetheless what I reported regressed is right what you had done to address the privacy concern of autofill in incognito,  issue 82777 . Since M19 the behavior no longer consistent with that decision. And I am unable to find this is intentionally changed in change log, so assuming this is a regression for now.
Also, there is a related  issue 99677 , which is opening but appears fixed for long to me.
Labels: -Type-Bug -Pri-2 -OS-Windows -Feature-Autofill Type-Regression Pri-1 OS-All Feature-Passwords Mstone-20 Action-BisectNeeded Feature-Incognito
Owner: isherman@chromium.org
Status: Assigned
Summary: In Incognito mode, saved passwords should be autofilled once the username is entered.
Thanks for the report.  A regression range from bisect-builds.py [1] would be very helpful.
[1] http://www.chromium.org/developers/bisect-builds-py
Works fine in stable and fails in beta and dev.

Ran bisect between latest stable(18.0.1026.168) and beta (19.0.1084.41), following is the bisect result:

You are probably looking for build 124743.
CHANGELOG URL:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk
/src&range=124720:124743
Built at revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=124743
Labels: -Action-BisectNeeded
Status: Started
Thanks for tracking that down, Pavan.

Comment 8 by dyu@chromium.org, May 8 2012

Blocking: 127250

Comment 9 by dharani@google.com, May 9 2012

Labels: ReleaseBlock-Beta
marking it as a blocker to get it in M20.
Project Member

Comment 10 by bugdroid1@chromium.org, May 15 2012

Blocking: -127250 chromium:127250
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=137047

------------------------------------------------------------------------
r137047 | isherman@chromium.org | Mon May 14 18:40:59 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager_unittest.cc?r1=137047&r2=137046&pathrev=137047
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager.h?r1=137047&r2=137046&pathrev=137047
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager_delegate_impl.cc?r1=137047&r2=137046&pathrev=137047
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager_delegate_impl.h?r1=137047&r2=137046&pathrev=137047
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager_delegate.h?r1=137047&r2=137046&pathrev=137047
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/password_manager/password_manager.cc?r1=137047&r2=137046&pathrev=137047
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.cc?r1=137047&r2=137046&pathrev=137047

Re-enable password autofill for Incognito windows

BUG= 117720 
TEST=Password autofill should now work in Incognito windows


Review URL: https://chromiumcodereview.appspot.com/10382049
------------------------------------------------------------------------
Labels: Merge-Requested
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 13 by bugdroid1@chromium.org, May 15 2012

Labels: merge-merged-1132
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=137256

------------------------------------------------------------------------
r137256 | isherman@chromium.org | Tue May 15 14:35:47 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/password_manager/password_manager_delegate.h?r1=137256&r2=137255&pathrev=137256
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/password_manager/password_manager.cc?r1=137256&r2=137255&pathrev=137256
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/autofill/autofill_manager.cc?r1=137256&r2=137255&pathrev=137256
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/password_manager/password_manager_unittest.cc?r1=137256&r2=137255&pathrev=137256
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/password_manager/password_manager.h?r1=137256&r2=137255&pathrev=137256
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/password_manager_delegate_impl.cc?r1=137256&r2=137255&pathrev=137256
 M http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/password_manager_delegate_impl.h?r1=137256&r2=137255&pathrev=137256

Merge 137047 - Re-enable password autofill for Incognito windows

BUG= 117720 
TEST=Password autofill should now work in Incognito windows


Review URL: https://chromiumcodereview.appspot.com/10382049

TBR=isherman@chromium.org
------------------------------------------------------------------------
Status: Fixed
 Issue 128311  has been merged into this issue.
Status: Verified
verified that incognito displays saved passwords using 20.0.1132.11 no Mac OSX

Comment 17 by apn...@gmail.com, Jun 13 2012

Still doesn't autofill for Facebook. Gmail seems to work. I'll try deleting all cookies and history.

Comment 18 by apn...@gmail.com, Jun 13 2012

Confirmed after clearing all cookies and history. Password does not save for Facebook
apnnyc: Please file a new bug for this issue (and post a comment linking to the new bug here).  I am unable to reproduce the issue on https://www.facebook.com

Comment 20 by k...@google.com, Aug 8 2012

Labels: -Merge-Approved
Remove merge approval label, this release has passed.

Comment 21 by k...@google.com, Aug 8 2012

Remove merge approval label, this release has passed.

Comment 22 by k...@google.com, Aug 8 2012

Remove merge approval label, this release has passed.
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 13 2012

Blocking: -chromium:127250 chromium:127250
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Regression -Area-UI -Feature-Passwords -Mstone-20 -Feature-Incognito Type-Bug-Regression Cr-UI M-20 Cr-UI-Browser-Passwords Cr-UI-Browser-Incognito
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 14 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment