Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 117626 Remove all JavaScript getters that take a parameter
Starred by 0 users Project Member Reported by tbreisacher@chromium.org, Mar 10, 2012 Back to list
Status: WontFix
Owner: tbreisacher@chromium.org
Closed: Dec 2015
Cc: arv@chromium.org
Components:
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment
One instance of this has already been fixed: http://codereview.chromium.org/9665012/diff/1/chrome/browser/resources/options2/cookies_list.js

but running the Closure compiler on all of chrome/browser/resources shows there are at least a few others.

According to http://code.google.com/p/v8/issues/detail?id=1998 this is a syntax error, yet v8 accepts it. We should fix all the other cases, otherwise a future v8 DEPS roll including that bug fix will probably break several webui pages.
 
Project Member Comment 1 by bugdroid1@chromium.org, Mar 14, 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=126532

------------------------------------------------------------------------
r126532 | tbreisacher@chromium.org | Tue Mar 13 18:45:43 PDT 2012

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/tracing/timeline_view.js?r1=126532&r2=126531&pathrev=126532
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/tracing/timeline_track.js?r1=126532&r2=126531&pathrev=126532

Get rid of |get x(x)| pattern in tracing/

BUG= 117626 
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9696028
------------------------------------------------------------------------
Project Member Comment 2 by bugdroid1@chromium.org, Mar 10, 2013
Labels: -Area-UI Cr-UI
Labels: Hotlist-Recharge Hotlist-Recharge-Stale
This issue likely requires triage.  The current issue owner may be inactive (i.e. hasn't fixed an issue in the last 30 days or commented in this particular issue in the last 90 days).  It has also not been modified in a year (prior to this update).  Thanks for helping out!

-Anthony
Status: WontFix
Codesearch seems to indicate this is now fixed and v8 correctly treats it as an error.
Sign in to add a comment