Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 117476 CFAllocator spelunking needs to be updated for 10.8
Starred by 36 users Project Member Reported by pawli...@chromium.org, Mar 8 2012 Back to list
Status: Fixed
Owner: a...@chromium.org
Closed: Sep 2012
Cc: sh...@chromium.org, a...@chromium.org, meh...@chromium.org
Components:
OS: Mac
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
Chrome Version       : 19.0.1061.1
OS version               : 10.8 developer preview

What steps will reproduce the problem?
1. Launch Chrome
2. Wait until an AU is available
3. Go to About Chrome

What is the expected result?
Update checked for and installed when I press Update Now

What happens instead?
Error in Console and "Error contacting the update server" (could be paraphrased)

Console: Internals of CFAllocator not known; out-of-memory failures via CFAllocator will not result in termination. http://crbug.com/45650


 
FWIW, Looks like I was trying to update from 19.0.1055.1 to 19.0.1061.1 while on GoogleGuest
Comment 2 by mark@chromium.org, Mar 9 2012
Owner: a...@chromium.org
The update error is bug 114710. It has nothing to do with the CFAllocator error.

Avi’s usually the one to deal with the CFAllocator internals.
Comment 3 by mark@chromium.org, Mar 9 2012
Note from bug 74589, which did this for Lion:

This is necessarily blocked on a source release by Apple of the Lion version of the Darwin code. That will happen when Apple ships Lion. I don't know if that will allow resolution of this issue by M12.

However, some light disassembly might tell us whether we can speculatively enable the OOM killer with a warning as we did for Lion before having the source code to peek at. See http://codereview.chromium.org/6711017 and http://codereview.chromium.org/7471041.
Status: Assigned
Comment 6 by a...@chromium.org, Mar 15 2012
Done for now. Waiting for 10.8 source.
Labels: Mstone-20
Based on WWDC dates and the Chrome release schedule, putting these into M20.
Comment 8 by dharani@google.com, May 8 2012
Labels: -Mstone-20 MovedFrom-20 Mstone-21
M20 has sailed. If this need to be part of M20, add them back with appropriate release blocker labels.
Labels: -MovedFrom-20 -Mstone-21 Mstone-20
Labels: ReleaseBlock-Stable
any updates?
Comment 12 by a...@chromium.org, Jun 4 2012
This cannot be done until Apple releases the source code to 10.8 so that we can verify what we've deduced. That will not happen until 10.8 is released. The timing for this is out of our control.
Labels: -ReleaseBlock-Stable
Since this bug has external dependency, it cannot block chrome stable release. I'm removing the blocker label.
Cc: meh...@chromium.org
Issue 138097 has been merged into this issue.
New text: "2012-07-27 10:30:45.805 Chromium[59364:707] Unsure about the internals of CFAllocator but going to patch them anyway. If there is a crash inside of CFAllocatorAllocate, please report it at http://crbug.com/117476 . If there is a crash and it is NOT inside of CFAllocatorAllocate, it is NOT RELATED. DO NOT REPORT IT THERE but rather FILE A NEW BUG."
Cc: a...@chromium.org sh...@chromium.org
Issue 139355 has been merged into this issue.
Status: ExternalDependency
Waiting for 10.8 code drop.
Comment 18 by sh...@chromium.org, Jul 27 2012
Issue 139355 has been merged into this issue.
Issue 139480 has been merged into this issue.
Comment 20 by Deleted ...@, Jul 31 2012
Seems I cannot use Google Chrome on my 10.8 Macbook Air (mid 2011).  In my business that is unacceptable! 

The 10.8 source was just posted:

http://www.opensource.apple.com/release/mac-os-x-108/
Comment 22 by a...@chromium.org, Aug 1 2012
But not the CF source for 10.8. "coming soon!"
Comment 23 by Deleted ...@, Aug 1 2012
8/1/12 3:48:48.660 PM Google Chrome Helper EH[557]: Unsure about the internals of CFAllocator but going to patch them anyway. If there is a crash inside of CFAllocatorAllocate, please report it at http://crbug.com/117476 . If there is a crash and it is NOT inside of CFAllocatorAllocate, it is NOT RELATED. DO NOT REPORT IT THERE but rather FILE A NEW BUG.

crashes MBA running 10.8

Had similar crash, attaching console logs for time window of crash

MBP (Running 10.8)
console_output_chrome3.log
12.1 KB View Download
Comment 25 by a...@chromium.org, Aug 4 2012
Labels: Restrict-AddIssueComment-Commit
If you are seeing crashes, file a new bug with the crash information. It's pretty clear that the CFAllocator work isn't the cause.

Still waiting for the 10.8 CF release.
Comment 26 by a...@chromium.org, Aug 7 2012
In the future I plan to not have this log line. Either it will crash inside of CFAllocator, in which case it will be obvious from the logs, or it won't crash in which case we won't get complaints that the log line is indicative of a problem that it has nothing to do with.
Project Member Comment 27 by bugdroid1@chromium.org, Aug 7 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=150385

------------------------------------------------------------------------
r150385 | avi@chromium.org | 2012-08-07T19:06:11.006112Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_mac.mm?r1=150385&r2=150384&pathrev=150385

Remove log message for 10.8 CFAllocator patching.

BUG= 117476 
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10854027
------------------------------------------------------------------------
Issue 142227 has been merged into this issue.
Comment 29 by a...@chromium.org, Aug 20 2012
Issue 139355 has been merged into this issue.
Issue 144148 has been merged into this issue.
Status: Assigned
FYI Apple just released CF-744 sources.
Comment 32 by a...@chromium.org, Sep 28 2012
Thanks for the ping. How did you catch it so quickly?

Of course, 6pm on a Friday.
Was checking for the 10.8.2 sources and noticed that CF was no longer "coming soon." Why 6pm on a Friday? --> :(
Comment 34 by a...@chromium.org, Sep 28 2012
I checked it about three hours ago. Looks like you're the lucky one.
Comment 35 by mark@chromium.org, Sep 28 2012
I've been checking daily too. Between the three of us, someone was bound to
catch it not too long after release.

Libm is gone, though.
Project Member Comment 36 by bugdroid1@chromium.org, Sep 29 2012
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=159398

------------------------------------------------------------------------
r159398 | avi@chromium.org | 2012-09-29T14:05:16.723007Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/apple_apsl/CFBase.h?r1=159398&r2=159397&pathrev=159398

Verified CFAllocator on 10.8

BUG= 117476 
TEST=no change


Review URL: https://chromiumcodereview.appspot.com/10982099
------------------------------------------------------------------------
Status: Fixed
Issue 153205 has been merged into this issue.
Issue 157906 has been merged into this issue.
Issue 159357 has been merged into this issue.
Project Member Comment 41 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-Internals -Mstone-20 M-20 Cr-Internals
Project Member Comment 42 by bugdroid1@chromium.org, Mar 14 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment